| Message ID | 20210413181447.2588084-1-niklas.soderlund+renesas@ragnatech.se (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
| Series | arm64: dts: renesas: falcon-csi-dsi: Add GPIO extenders | expand |
Hi Niklas, Thanks for your patch! On Tue, Apr 13, 2021 at 8:17 PM Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> wrote: > We need to configure its GPIOs to power on the MAX96712. ... their GPIOs ... MAX96712s? > > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> > --- a/arch/arm64/boot/dts/renesas/r8a779a0-falcon-csi-dsi.dtsi > +++ b/arch/arm64/boot/dts/renesas/r8a779a0-falcon-csi-dsi.dtsi > @@ -12,4 +12,25 @@ eeprom@52 { > reg = <0x52>; > pagesize = <8>; > }; > + > + pca9654_a: gpio@21 { Please obey numerical sort order by unit-address. > + compatible = "onnn,pca9654"; > + reg = <0x21>; > + gpio-controller; > + #gpio-cells = <2>; > + }; > + > + pca9654_b: gpio@22 { > + compatible = "onnn,pca9654"; > + reg = <0x22>; > + gpio-controller; > + #gpio-cells = <2>; > + }; > + > + pca9654_c: gpio@23 { > + compatible = "onnn,pca9654"; > + reg = <0x23>; > + gpio-controller; > + #gpio-cells = <2>; > + }; Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> No need to resend, will queue in renesas-devel for v5.14 with the above fixed. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
diff --git a/arch/arm64/boot/dts/renesas/r8a779a0-falcon-csi-dsi.dtsi b/arch/arm64/boot/dts/renesas/r8a779a0-falcon-csi-dsi.dtsi index 14d3db5d6c16485d..928b182a76901276 100644 --- a/arch/arm64/boot/dts/renesas/r8a779a0-falcon-csi-dsi.dtsi +++ b/arch/arm64/boot/dts/renesas/r8a779a0-falcon-csi-dsi.dtsi @@ -12,4 +12,25 @@ eeprom@52 { reg = <0x52>; pagesize = <8>; }; + + pca9654_a: gpio@21 { + compatible = "onnn,pca9654"; + reg = <0x21>; + gpio-controller; + #gpio-cells = <2>; + }; + + pca9654_b: gpio@22 { + compatible = "onnn,pca9654"; + reg = <0x22>; + gpio-controller; + #gpio-cells = <2>; + }; + + pca9654_c: gpio@23 { + compatible = "onnn,pca9654"; + reg = <0x23>; + gpio-controller; + #gpio-cells = <2>; + }; };
We need to configure its GPIOs to power on the MAX96712. Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> --- .../dts/renesas/r8a779a0-falcon-csi-dsi.dtsi | 21 +++++++++++++++++++ 1 file changed, 21 insertions(+)