| Message ID | 20210831075442.698-1-caihuoqing@baidu.com (mailing list archive) |
|---|---|
| State | New |
| Delegated to: | Kieran Bingham |
| Headers | show |
| Series | drm: rcar-du: Make use of the helper function devm_platform_ioremap_resource() | expand |
On 31/08/2021 08:54, Cai Huoqing wrote: > Use the devm_platform_ioremap_resource() helper instead of > calling platform_get_resource() and devm_ioremap_resource() > separately > > Signed-off-by: Cai Huoqing <caihuoqing@baidu.com> Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> > --- > drivers/gpu/drm/rcar-du/rcar_du_drv.c | 4 +--- > drivers/gpu/drm/rcar-du/rcar_lvds.c | 4 +--- > 2 files changed, 2 insertions(+), 6 deletions(-) > > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c b/drivers/gpu/drm/rcar-du/rcar_du_drv.c > index 4ac26d08ebb4..ebec4b7269d1 100644 > --- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c > +++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c > @@ -570,7 +570,6 @@ static void rcar_du_shutdown(struct platform_device *pdev) > static int rcar_du_probe(struct platform_device *pdev) > { > struct rcar_du_device *rcdu; > - struct resource *mem; > int ret; > > /* Allocate and initialize the R-Car device structure. */ > @@ -585,8 +584,7 @@ static int rcar_du_probe(struct platform_device *pdev) > platform_set_drvdata(pdev, rcdu); > > /* I/O resources */ > - mem = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - rcdu->mmio = devm_ioremap_resource(&pdev->dev, mem); > + rcdu->mmio = devm_platform_ioremap_resource(pdev, 0); > if (IS_ERR(rcdu->mmio)) > return PTR_ERR(rcdu->mmio); > > diff --git a/drivers/gpu/drm/rcar-du/rcar_lvds.c b/drivers/gpu/drm/rcar-du/rcar_lvds.c > index d061b8de748f..a64d910b0500 100644 > --- a/drivers/gpu/drm/rcar-du/rcar_lvds.c > +++ b/drivers/gpu/drm/rcar-du/rcar_lvds.c > @@ -802,7 +802,6 @@ static int rcar_lvds_probe(struct platform_device *pdev) > { > const struct soc_device_attribute *attr; > struct rcar_lvds *lvds; > - struct resource *mem; > int ret; > > lvds = devm_kzalloc(&pdev->dev, sizeof(*lvds), GFP_KERNEL); > @@ -825,8 +824,7 @@ static int rcar_lvds_probe(struct platform_device *pdev) > lvds->bridge.funcs = &rcar_lvds_bridge_ops; > lvds->bridge.of_node = pdev->dev.of_node; > > - mem = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - lvds->mmio = devm_ioremap_resource(&pdev->dev, mem); > + lvds->mmio = devm_platform_ioremap_resource(pdev, 0); > if (IS_ERR(lvds->mmio)) > return PTR_ERR(lvds->mmio); > >
Hi Cai, Thank you for the patch. On Tue, Aug 31, 2021 at 03:54:42PM +0800, Cai Huoqing wrote: > Use the devm_platform_ioremap_resource() helper instead of > calling platform_get_resource() and devm_ioremap_resource() > separately > > Signed-off-by: Cai Huoqing <caihuoqing@baidu.com> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > drivers/gpu/drm/rcar-du/rcar_du_drv.c | 4 +--- > drivers/gpu/drm/rcar-du/rcar_lvds.c | 4 +--- > 2 files changed, 2 insertions(+), 6 deletions(-) > > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c b/drivers/gpu/drm/rcar-du/rcar_du_drv.c > index 4ac26d08ebb4..ebec4b7269d1 100644 > --- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c > +++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c > @@ -570,7 +570,6 @@ static void rcar_du_shutdown(struct platform_device *pdev) > static int rcar_du_probe(struct platform_device *pdev) > { > struct rcar_du_device *rcdu; > - struct resource *mem; > int ret; > > /* Allocate and initialize the R-Car device structure. */ > @@ -585,8 +584,7 @@ static int rcar_du_probe(struct platform_device *pdev) > platform_set_drvdata(pdev, rcdu); > > /* I/O resources */ > - mem = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - rcdu->mmio = devm_ioremap_resource(&pdev->dev, mem); > + rcdu->mmio = devm_platform_ioremap_resource(pdev, 0); > if (IS_ERR(rcdu->mmio)) > return PTR_ERR(rcdu->mmio); > > diff --git a/drivers/gpu/drm/rcar-du/rcar_lvds.c b/drivers/gpu/drm/rcar-du/rcar_lvds.c > index d061b8de748f..a64d910b0500 100644 > --- a/drivers/gpu/drm/rcar-du/rcar_lvds.c > +++ b/drivers/gpu/drm/rcar-du/rcar_lvds.c > @@ -802,7 +802,6 @@ static int rcar_lvds_probe(struct platform_device *pdev) > { > const struct soc_device_attribute *attr; > struct rcar_lvds *lvds; > - struct resource *mem; > int ret; > > lvds = devm_kzalloc(&pdev->dev, sizeof(*lvds), GFP_KERNEL); > @@ -825,8 +824,7 @@ static int rcar_lvds_probe(struct platform_device *pdev) > lvds->bridge.funcs = &rcar_lvds_bridge_ops; > lvds->bridge.of_node = pdev->dev.of_node; > > - mem = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - lvds->mmio = devm_ioremap_resource(&pdev->dev, mem); > + lvds->mmio = devm_platform_ioremap_resource(pdev, 0); > if (IS_ERR(lvds->mmio)) > return PTR_ERR(lvds->mmio); >
diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c b/drivers/gpu/drm/rcar-du/rcar_du_drv.c index 4ac26d08ebb4..ebec4b7269d1 100644 --- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c +++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c @@ -570,7 +570,6 @@ static void rcar_du_shutdown(struct platform_device *pdev) static int rcar_du_probe(struct platform_device *pdev) { struct rcar_du_device *rcdu; - struct resource *mem; int ret; /* Allocate and initialize the R-Car device structure. */ @@ -585,8 +584,7 @@ static int rcar_du_probe(struct platform_device *pdev) platform_set_drvdata(pdev, rcdu); /* I/O resources */ - mem = platform_get_resource(pdev, IORESOURCE_MEM, 0); - rcdu->mmio = devm_ioremap_resource(&pdev->dev, mem); + rcdu->mmio = devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(rcdu->mmio)) return PTR_ERR(rcdu->mmio); diff --git a/drivers/gpu/drm/rcar-du/rcar_lvds.c b/drivers/gpu/drm/rcar-du/rcar_lvds.c index d061b8de748f..a64d910b0500 100644 --- a/drivers/gpu/drm/rcar-du/rcar_lvds.c +++ b/drivers/gpu/drm/rcar-du/rcar_lvds.c @@ -802,7 +802,6 @@ static int rcar_lvds_probe(struct platform_device *pdev) { const struct soc_device_attribute *attr; struct rcar_lvds *lvds; - struct resource *mem; int ret; lvds = devm_kzalloc(&pdev->dev, sizeof(*lvds), GFP_KERNEL); @@ -825,8 +824,7 @@ static int rcar_lvds_probe(struct platform_device *pdev) lvds->bridge.funcs = &rcar_lvds_bridge_ops; lvds->bridge.of_node = pdev->dev.of_node; - mem = platform_get_resource(pdev, IORESOURCE_MEM, 0); - lvds->mmio = devm_ioremap_resource(&pdev->dev, mem); + lvds->mmio = devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(lvds->mmio)) return PTR_ERR(lvds->mmio);
Use the devm_platform_ioremap_resource() helper instead of calling platform_get_resource() and devm_ioremap_resource() separately Signed-off-by: Cai Huoqing <caihuoqing@baidu.com> --- drivers/gpu/drm/rcar-du/rcar_du_drv.c | 4 +--- drivers/gpu/drm/rcar-du/rcar_lvds.c | 4 +--- 2 files changed, 2 insertions(+), 6 deletions(-)