diff mbox series

[RFC,3/3] arm64: dts: r8a779a0-falcon-cpu: Add TPU support

Message ID 20210901091725.35610-4-wsa+renesas@sang-engineering.com (mailing list archive)
State RFC
Delegated to: Geert Uytterhoeven
Headers show
Series v3u: add support for TPU | expand

Commit Message

Wolfram Sang Sept. 1, 2021, 9:17 a.m. UTC 
From: Duc Nguyen <duc.nguyen.ub@renesas.com>

This patch enables TPU channel 1 for the Falcon board.

Signed-off-by: Duc Nguyen <duc.nguyen.ub@renesas.com>
Signed-off-by: Wolfram Sang <wsa@kernel.org>
---

Do we want this activated upstream? I think it is nice to have.

 arch/arm64/boot/dts/renesas/r8a779a0-falcon-cpu.dtsi | 12 ++++++++++++
 1 file changed, 12 insertions(+)

Comments

Geert Uytterhoeven Sept. 6, 2021, 9:45 a.m. UTC | #1 
Hi Wolfram,

On Wed, Sep 1, 2021 at 11:17 AM Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
> From: Duc Nguyen <duc.nguyen.ub@renesas.com>
>
> This patch enables TPU channel 1 for the Falcon board.
>
> Signed-off-by: Duc Nguyen <duc.nguyen.ub@renesas.com>
> Signed-off-by: Wolfram Sang <wsa@kernel.org>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

> Do we want this activated upstream? I think it is nice to have.

I don't think so, as there is no actual user.

It could be enabled in a DT overlay describing a board connected to
CN4. Or just a simple overlay for testing TPU on CN4.  I'd be happy
to add the latter to
https://git.kernel.org/pub/scm/linux/kernel/git/geert/renesas-drivers.git/log/?h=topic/renesas-overlays

Thanks!

Gr{oetje,eeting}s,

                        Geert
Wolfram Sang Sept. 6, 2021, 9:50 a.m. UTC | #2 
> > Do we want this activated upstream? I think it is nice to have.
> 
> I don't think so, as there is no actual user.

OK.

> It could be enabled in a DT overlay describing a board connected to
> CN4. Or just a simple overlay for testing TPU on CN4.  I'd be happy
> to add the latter to
> https://git.kernel.org/pub/scm/linux/kernel/git/geert/renesas-drivers.git/log/?h=topic/renesas-overlays

With the same argument, let's see if someones actually wants to use it
and adds it as an overly then.

Thanks for fixing the sorting in patch 2/3!
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/renesas/r8a779a0-falcon-cpu.dtsi b/arch/arm64/boot/dts/renesas/r8a779a0-falcon-cpu.dtsi
index a0a1a1da0d87..cf777c2799e8 100644
--- a/arch/arm64/boot/dts/renesas/r8a779a0-falcon-cpu.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a779a0-falcon-cpu.dtsi
@@ -175,6 +175,11 @@  scif_clk_pins: scif_clk {
 		groups = "scif_clk";
 		function = "scif_clk";
 	};
+
+	tpu_pin: tpu {
+		groups = "tpu_to1";
+		function = "tpu";
+	};
 };
 
 &rwdt {
@@ -193,3 +198,10 @@  &scif0 {
 &scif_clk {
 	clock-frequency = <24000000>;
 };
+
+&tpu {
+	pinctrl-0 = <&tpu_pin>;
+	pinctrl-names = "default";
+
+	status = "okay";
+};