| Message ID | 20210907064537.1054268-1-mkl@pengutronix.de (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 54d7a47a008b89fce5a669528274194ca092634d |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
| Series | [v2] can: rcar_canfd: add __maybe_unused annotation to silence warning | expand |
On Tue, Sep 7, 2021 at 8:48 AM Marc Kleine-Budde <mkl@pengutronix.de> wrote: > Since commit > > | dd3bd23eb438 ("can: rcar_canfd: Add Renesas R-Car CAN FD driver") > > the rcar_canfd driver can be compile tested on all architectures. On > non OF enabled archs, or archs where OF is optional (and disabled in > the .config) the compilation throws the following warning: > > | drivers/net/can/rcar/rcar_canfd.c:2020:34: warning: unused variable 'rcar_canfd_of_table' [-Wunused-const-variable] > | static const struct of_device_id rcar_canfd_of_table[] = { > | ^ > > This patch fixes the warning by marking the variable > rcar_canfd_of_table as __maybe_unused. > > Fixes: ac4224087312 ("can: rcar: Kconfig: Add helper dependency on COMPILE_TEST") > Fixes: dd3bd23eb438 ("can: rcar_canfd: Add Renesas R-Car CAN FD driver") > Cc: linux-renesas-soc@vger.kernel.org > Cc: Cai Huoqing <caihuoqing@baidu.com> > Reported-by: kernel test robot <lkp@intel.com> > Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert
diff --git a/drivers/net/can/rcar/rcar_canfd.c b/drivers/net/can/rcar/rcar_canfd.c index c47988d3674e..ff9d0f5ae0dd 100644 --- a/drivers/net/can/rcar/rcar_canfd.c +++ b/drivers/net/can/rcar/rcar_canfd.c @@ -2017,7 +2017,7 @@ static int __maybe_unused rcar_canfd_resume(struct device *dev) static SIMPLE_DEV_PM_OPS(rcar_canfd_pm_ops, rcar_canfd_suspend, rcar_canfd_resume); -static const struct of_device_id rcar_canfd_of_table[] = { +static const __maybe_unused struct of_device_id rcar_canfd_of_table[] = { { .compatible = "renesas,rcar-gen3-canfd", .data = (void *)RENESAS_RCAR_GEN3 }, { .compatible = "renesas,rzg2l-canfd", .data = (void *)RENESAS_RZG2L }, { }
Since commit | dd3bd23eb438 ("can: rcar_canfd: Add Renesas R-Car CAN FD driver") the rcar_canfd driver can be compile tested on all architectures. On non OF enabled archs, or archs where OF is optional (and disabled in the .config) the compilation throws the following warning: | drivers/net/can/rcar/rcar_canfd.c:2020:34: warning: unused variable 'rcar_canfd_of_table' [-Wunused-const-variable] | static const struct of_device_id rcar_canfd_of_table[] = { | ^ This patch fixes the warning by marking the variable rcar_canfd_of_table as __maybe_unused. Fixes: ac4224087312 ("can: rcar: Kconfig: Add helper dependency on COMPILE_TEST") Fixes: dd3bd23eb438 ("can: rcar_canfd: Add Renesas R-Car CAN FD driver") Cc: linux-renesas-soc@vger.kernel.org Cc: Cai Huoqing <caihuoqing@baidu.com> Reported-by: kernel test robot <lkp@intel.com> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de> --- Changes since v1: - moved __maybe_unused in front after "static const" drivers/net/can/rcar/rcar_canfd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)