| Message ID | 20211130100049.129418-2-julien.massot@iot.bzh (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
| Series | Initial Renesas R-Car remoteproc support | expand |
Hi Julien, Thanks for your patch! On Tue, Nov 30, 2021 at 11:01 AM Julien Massot <julien.massot@iot.bzh> wrote: > Renesas R-Car SoCs may contains a Realtime processor. contain > This patch adds binding for this remote processor. bindings > > Signed-off-by: Julien Massot <julien.massot@iot.bzh> > Reviewed-by: Rob Herring <robh@kernel.org> > --- > Changes since v1 > - dropped 'status = "okay";' in the sample > - Add Rob's Reviewed-by tag > > --- > .../remoteproc/renesas,rcar-rproc.yaml | 65 +++++++++++++++++++ > 1 file changed, 65 insertions(+) > create mode 100644 Documentation/devicetree/bindings/remoteproc/renesas,rcar-rproc.yaml > > diff --git a/Documentation/devicetree/bindings/remoteproc/renesas,rcar-rproc.yaml b/Documentation/devicetree/bindings/remoteproc/renesas,rcar-rproc.yaml > new file mode 100644 > index 000000000000..3fe8d49051e6 > --- /dev/null > +++ b/Documentation/devicetree/bindings/remoteproc/renesas,rcar-rproc.yaml > @@ -0,0 +1,65 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: "http://devicetree.org/schemas/remoteproc/renesas,rcar-rproc.yaml#" > +$schema: "http://devicetree.org/meta-schemas/core.yaml#" > + > +title: Renesas R-Car remote processor controller bindings > + > +maintainers: > + - Julien Massot <julien.massot@iot.bzh> > + > +description: | > + This document defines the binding for the remoteproc component that loads and bindings > + boots firmwares on the Renesas R-Car family chipset. > + R-Car gen3 family may have a realtime processor, this processor share peripheral shares > + and RAM with the host processor with the same address map. > + > +properties: > + compatible: > + const: renesas,rcar-cr7 > + > + resets: > + maxItems: 1 > + > + power-domains: > + maxItems: 1 > + > + memory-region: > + description: > + List of phandles to the reserved memory regions associated with the > + remoteproc device. This is variable and describes the memories shared with > + the remote processor (e.g. remoteproc firmware and carveouts, rpmsg carve-out > + vrings, ...). > + (see ../reserved-memory/reserved-memory.yaml) Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Hi Geert, On 12/2/21 14:22, Geert Uytterhoeven wrote: > Hi Julien, > > Thanks for your patch! > > On Tue, Nov 30, 2021 at 11:01 AM Julien Massot <julien.massot@iot.bzh> wrote: >> Renesas R-Car SoCs may contains a Realtime processor. > > contain > >> This patch adds binding for this remote processor. > > bindings > >> >> Signed-off-by: Julien Massot <julien.massot@iot.bzh> >> Reviewed-by: Rob Herring <robh@kernel.org> >> --- >> Changes since v1 >> - dropped 'status = "okay";' in the sample >> - Add Rob's Reviewed-by tag >> >> --- >> .../remoteproc/renesas,rcar-rproc.yaml | 65 +++++++++++++++++++ >> 1 file changed, 65 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/remoteproc/renesas,rcar-rproc.yaml >> >> diff --git a/Documentation/devicetree/bindings/remoteproc/renesas,rcar-rproc.yaml b/Documentation/devicetree/bindings/remoteproc/renesas,rcar-rproc.yaml >> new file mode 100644 >> index 000000000000..3fe8d49051e6 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/remoteproc/renesas,rcar-rproc.yaml >> @@ -0,0 +1,65 @@ >> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: "http://devicetree.org/schemas/remoteproc/renesas,rcar-rproc.yaml#" >> +$schema: "http://devicetree.org/meta-schemas/core.yaml#" >> + >> +title: Renesas R-Car remote processor controller bindings >> + >> +maintainers: >> + - Julien Massot <julien.massot@iot.bzh> >> + >> +description: | >> + This document defines the binding for the remoteproc component that loads and > > bindings > >> + boots firmwares on the Renesas R-Car family chipset. >> + R-Car gen3 family may have a realtime processor, this processor share peripheral > > shares > >> + and RAM with the host processor with the same address map. >> + >> +properties: >> + compatible: >> + const: renesas,rcar-cr7 >> + >> + resets: >> + maxItems: 1 >> + >> + power-domains: >> + maxItems: 1 >> + >> + memory-region: >> + description: >> + List of phandles to the reserved memory regions associated with the >> + remoteproc device. This is variable and describes the memories shared with >> + the remote processor (e.g. remoteproc firmware and carveouts, rpmsg Thanks for fixing all these english mistakes. Will resend this patch soon. > > carve-out Will keep 'carveouts' since this term is intensively used in the remoteproc core. > >> + vrings, ...). >> + (see ../reserved-memory/reserved-memory.yaml) > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Regards,
diff --git a/Documentation/devicetree/bindings/remoteproc/renesas,rcar-rproc.yaml b/Documentation/devicetree/bindings/remoteproc/renesas,rcar-rproc.yaml new file mode 100644 index 000000000000..3fe8d49051e6 --- /dev/null +++ b/Documentation/devicetree/bindings/remoteproc/renesas,rcar-rproc.yaml @@ -0,0 +1,65 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: "http://devicetree.org/schemas/remoteproc/renesas,rcar-rproc.yaml#" +$schema: "http://devicetree.org/meta-schemas/core.yaml#" + +title: Renesas R-Car remote processor controller bindings + +maintainers: + - Julien Massot <julien.massot@iot.bzh> + +description: | + This document defines the binding for the remoteproc component that loads and + boots firmwares on the Renesas R-Car family chipset. + R-Car gen3 family may have a realtime processor, this processor share peripheral + and RAM with the host processor with the same address map. + +properties: + compatible: + const: renesas,rcar-cr7 + + resets: + maxItems: 1 + + power-domains: + maxItems: 1 + + memory-region: + description: + List of phandles to the reserved memory regions associated with the + remoteproc device. This is variable and describes the memories shared with + the remote processor (e.g. remoteproc firmware and carveouts, rpmsg + vrings, ...). + (see ../reserved-memory/reserved-memory.yaml) + +required: + - compatible + - resets + - memory-region + - power-domains + +additionalProperties: false + +examples: + - | + #include <dt-bindings/clock/r8a7795-cpg-mssr.h> + #include <dt-bindings/power/r8a7795-sysc.h> + reserved-memory { + #address-cells = <2>; + #size-cells = <2>; + + cr7_ram: cr7_ram@40040000 { + no-map; + reg = <0x0 0x40040000 0x0 0x1fc0000>; + }; + }; + + cr7_rproc: cr7 { + compatible = "renesas,rcar-cr7"; + memory-region = <&cr7_ram>; + power-domains = <&sysc R8A7795_PD_CR7>; + resets = <&cpg 222>; + }; + +...