| Message ID | 20211203115154.31864-5-biju.das.jz@bp.renesas.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
| Series | Add Mali-G31 GPU support for RZ/G2L SoC | expand |
Hi Biju, On Fri, Dec 3, 2021 at 12:52 PM Biju Das <biju.das.jz@bp.renesas.com> wrote: > The Renesas RZ/G2{L, LC} SoC (a.k.a R9A07G044) has a Bifrost Mali-G31 GPU, > add a compatible string for it. > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> > Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> Thanks for your patch! > --- a/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml > +++ b/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml > @@ -52,7 +64,8 @@ properties: > maxItems: 3 > > resets: > - maxItems: 2 > + minItems: 1 2, as before? > + maxItems: 3 Perhaps you should add reset-names? > > "#cooling-cells": > const: 2 > @@ -113,6 +126,21 @@ allOf: > - sram-supply > - power-domains > - power-domain-names > + - if: > + properties: > + compatible: > + contains: > + const: renesas,r9a07g044-mali > + then: > + properties: > + interrupt-names: > + minItems: 4 > + clock-names: > + minItems: 3 > + required: > + - clock-names > + - power-domains > + - resets reset-names > else: > properties: > power-domains: The rest looks good to me, but I'm no Mali expert. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Hi Geert, Thanks for the feedback. > Subject: Re: [PATCH 4/6] dt-bindings: gpu: mali-bifrost: Document RZ/G2L > support > > Hi Biju, > > On Fri, Dec 3, 2021 at 12:52 PM Biju Das <biju.das.jz@bp.renesas.com> > wrote: > > The Renesas RZ/G2{L, LC} SoC (a.k.a R9A07G044) has a Bifrost Mali-G31 > > GPU, add a compatible string for it. > > > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> > > Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > Thanks for your patch! > > > --- a/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml > > +++ b/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml > > > @@ -52,7 +64,8 @@ properties: > > maxItems: 3 > > > > resets: > > - maxItems: 2 > > + minItems: 1 > > 2, as before? OK. Will do. > > > + maxItems: 3 > > Perhaps you should add reset-names? Agreed. Will remove max items add reset-names instead ("rst", "axi_rst", "ace_rst") > > > > > "#cooling-cells": > > const: 2 > > @@ -113,6 +126,21 @@ allOf: > > - sram-supply > > - power-domains > > - power-domain-names > > + - if: > > + properties: > > + compatible: > > + contains: > > + const: renesas,r9a07g044-mali > > + then: > > + properties: > > + interrupt-names: > > + minItems: 4 > > + clock-names: > > + minItems: 3 > > + required: > > + - clock-names > > + - power-domains > > + - resets > > reset-names Ok. Regards, Biju > > > else: > > properties: > > power-domains: > > The rest looks good to me, but I'm no Mali expert. > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux- > m68k.org > > In personal conversations with technical people, I call myself a hacker. > But when I'm talking to journalists I just say "programmer" or something > like that. > -- Linus Torvalds
diff --git a/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml b/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml index 6f98dd55fb4c..c9fac2498f5e 100644 --- a/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml +++ b/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml @@ -19,6 +19,7 @@ properties: - amlogic,meson-g12a-mali - mediatek,mt8183-mali - realtek,rtd1619-mali + - renesas,r9a07g044-mali - rockchip,px30-mali - rockchip,rk3568-mali - const: arm,mali-bifrost # Mali Bifrost GPU model/revision is fully discoverable @@ -27,19 +28,30 @@ properties: maxItems: 1 interrupts: + minItems: 3 items: - description: Job interrupt - description: MMU interrupt - description: GPU interrupt + - description: EVENT interrupt interrupt-names: + minItems: 3 items: - const: job - const: mmu - const: gpu + - const: event clocks: - maxItems: 1 + minItems: 1 + maxItems: 3 + + clock-names: + items: + - const: gpu + - const: bus + - const: bus_ace mali-supply: true @@ -52,7 +64,8 @@ properties: maxItems: 3 resets: - maxItems: 2 + minItems: 1 + maxItems: 3 "#cooling-cells": const: 2 @@ -113,6 +126,21 @@ allOf: - sram-supply - power-domains - power-domain-names + - if: + properties: + compatible: + contains: + const: renesas,r9a07g044-mali + then: + properties: + interrupt-names: + minItems: 4 + clock-names: + minItems: 3 + required: + - clock-names + - power-domains + - resets else: properties: power-domains:
The Renesas RZ/G2{L, LC} SoC (a.k.a R9A07G044) has a Bifrost Mali-G31 GPU, add a compatible string for it. Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> --- .../bindings/gpu/arm,mali-bifrost.yaml | 32 +++++++++++++++++-- 1 file changed, 30 insertions(+), 2 deletions(-)