| Message ID | 20211221052722.597407-2-yoshihiro.shimoda.uh@renesas.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
| Series | treewide: rcar-dmac: Add support for R-Car S4-8 | expand |
Hi Shimoda-san, Thanks for your patch! On Tue, Dec 21, 2021 at 10:50 AM Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> wrote: > Document the compatible value for the Direct Memory Access Controller > blocks in the Renesas R-Car S4-8 (R8A779F0) SoC. > > The most visible difference with DMAC blocks on other R-Car SoCs > (except R8A779F0) is the move of the per-channel registers to R8A779A0. > a separate register block. > > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Hi Geert-san, Thank you for your review! > From: Geert Uytterhoeven, Sent: Wednesday, December 22, 2021 6:13 PM > > Hi Shimoda-san, > > Thanks for your patch! > > On Tue, Dec 21, 2021 at 10:50 AM Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> wrote: > > Document the compatible value for the Direct Memory Access Controller > > blocks in the Renesas R-Car S4-8 (R8A779F0) SoC. > > > > The most visible difference with DMAC blocks on other R-Car SoCs > > (except R8A779F0) is the move of the per-channel registers to > > R8A779A0. Oops. I'll fix it on v2. > > a separate register block. > > > > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Thanks! Best regards, Yoshihiro Shimoda
diff --git a/Documentation/devicetree/bindings/dma/renesas,rcar-dmac.yaml b/Documentation/devicetree/bindings/dma/renesas,rcar-dmac.yaml index d8142cbd13d3..7c6badf39921 100644 --- a/Documentation/devicetree/bindings/dma/renesas,rcar-dmac.yaml +++ b/Documentation/devicetree/bindings/dma/renesas,rcar-dmac.yaml @@ -44,6 +44,10 @@ properties: - items: - const: renesas,dmac-r8a779a0 # R-Car V3U + - items: + - const: renesas,dmac-r8a779f0 # R-Car S4-8 + - const: renesas,rcar-gen4-dmac + reg: true interrupts: @@ -118,6 +122,7 @@ if: contains: enum: - renesas,dmac-r8a779a0 + - renesas,rcar-gen4-dmac then: properties: reg:
Document the compatible value for the Direct Memory Access Controller blocks in the Renesas R-Car S4-8 (R8A779F0) SoC. The most visible difference with DMAC blocks on other R-Car SoCs (except R8A779F0) is the move of the per-channel registers to a separate register block. Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> --- Documentation/devicetree/bindings/dma/renesas,rcar-dmac.yaml | 5 +++++ 1 file changed, 5 insertions(+)