| Message ID | 20211221052722.597407-3-yoshihiro.shimoda.uh@renesas.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
| Series | treewide: rcar-dmac: Add support for R-Car S4-8 | expand |
> On 12/21/2021 6:27 AM Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> wrote: > > > Add support for R-Car S4-8. We can reuse R-Car V3U code so that > renames variable names as "gen4". > > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> > --- > drivers/dma/sh/rcar-dmac.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/drivers/dma/sh/rcar-dmac.c b/drivers/dma/sh/rcar-dmac.c > index 5c7716fd6bc5..e409c89edca1 100644 > --- a/drivers/dma/sh/rcar-dmac.c > +++ b/drivers/dma/sh/rcar-dmac.c > @@ -2009,7 +2009,7 @@ static const struct rcar_dmac_of_data rcar_dmac_data = { > .chan_offset_stride = 0x80, > }; > > -static const struct rcar_dmac_of_data rcar_v3u_dmac_data = { > +static const struct rcar_dmac_of_data rcar_gen4_dmac_data = { > .chan_offset_base = 0x0, > .chan_offset_stride = 0x1000, > }; > @@ -2018,9 +2018,12 @@ static const struct of_device_id rcar_dmac_of_ids[] = { > { > .compatible = "renesas,rcar-dmac", > .data = &rcar_dmac_data, > + }, { > + .compatible = "renesas,rcar-gen4-dmac", > + .data = &rcar_gen4_dmac_data, > }, { > .compatible = "renesas,dmac-r8a779a0", > - .data = &rcar_v3u_dmac_data, > + .data = &rcar_gen4_dmac_data, > }, > { /* Sentinel */ } > }; > -- > 2.25.1 Reviewed-by: Ulrich Hecht <uli+renesas@fpond.eu> CU Uli
Hi Shimoda-san, On Tue, Dec 21, 2021 at 10:50 AM Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> wrote: > Add support for R-Car S4-8. We can reuse R-Car V3U code so that > renames variable names as "gen4". > > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> Thanks for your patch! Perhaps you want to rename RCAR_V3U_DMACHCLR, too? As some registers do not exist (or are not documented) on R-Car S4-8, perhaps you want to document that in the comments for the register definitions, too? Fortunately none of them are used by the driver. As this patch is correct: Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Hi Geert-san, Thank you for your review! > From: Geert Uytterhoeven, Sent: Wednesday, December 22, 2021 6:17 PM > > Hi Shimoda-san, > > On Tue, Dec 21, 2021 at 10:50 AM Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> wrote: > > Add support for R-Car S4-8. We can reuse R-Car V3U code so that > > renames variable names as "gen4". > > > > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> > > Thanks for your patch! > > Perhaps you want to rename RCAR_V3U_DMACHCLR, too? Yes, I should have to rename it, too. I'll fix it on v2. > As some registers do not exist (or are not documented) on R-Car S4-8, perhaps you want to document that in the comments > for the register definitions, too? Fortunately none of them are used by the driver. You're correct. So, I'll modify the following code: -#define RCAR_DMACHCLR 0x0080 /* Not on R-Car V3U */ +#define RCAR_DMACHCLR 0x0080 /* Not on R-Car Gen4 */ (sorry these tabs are replaced as spaces) Also, I'll add such information in the commit description like below. ----- Add support for R-Car S4-8. We can reuse R-Car V3U code so that renames variable names as "gen4". Note that some registers of R-Car V3U do not exist on R-Car S4-8, but none of them are used by the driver for now. ----- Are they acceptable? > As this patch is correct: > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Thanks! Best regards, Yoshihiro Shimoda
Hi Shimoda-san, On Wed, Dec 22, 2021 at 11:08 AM Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> wrote: > > From: Geert Uytterhoeven, Sent: Wednesday, December 22, 2021 6:17 PM > > As some registers do not exist (or are not documented) on R-Car S4-8, perhaps you want to document that in the comments > > for the register definitions, too? Fortunately none of them are used by the driver. > > You're correct. So, I'll modify the following code: > > -#define RCAR_DMACHCLR 0x0080 /* Not on R-Car V3U */ > +#define RCAR_DMACHCLR 0x0080 /* Not on R-Car Gen4 */ > (sorry these tabs are replaced as spaces) > > Also, I'll add such information in the commit description > like below. > ----- > Add support for R-Car S4-8. We can reuse R-Car V3U code so that > renames variable names as "gen4". > > Note that some registers of R-Car V3U do not exist on R-Car S4-8, > but none of them are used by the driver for now. > ----- > > Are they acceptable? Perfect! Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Hi Geert-san, > From: Geert Uytterhoeven, Sent: Wednesday, December 22, 2021 7:10 PM <snip> > > You're correct. So, I'll modify the following code: > > > > -#define RCAR_DMACHCLR 0x0080 /* Not on R-Car V3U */ > > +#define RCAR_DMACHCLR 0x0080 /* Not on R-Car Gen4 */ > > (sorry these tabs are replaced as spaces) > > > > Also, I'll add such information in the commit description like below. > > ----- > > Add support for R-Car S4-8. We can reuse R-Car V3U code so that > > renames variable names as "gen4". > > > > Note that some registers of R-Car V3U do not exist on R-Car S4-8, but > > none of them are used by the driver for now. > > ----- > > > > Are they acceptable? > > Perfect! Thanks! Thank you for your reply! I'll fix it on v2. Best regards, Yoshihiro Shimoda
diff --git a/drivers/dma/sh/rcar-dmac.c b/drivers/dma/sh/rcar-dmac.c index 5c7716fd6bc5..e409c89edca1 100644 --- a/drivers/dma/sh/rcar-dmac.c +++ b/drivers/dma/sh/rcar-dmac.c @@ -2009,7 +2009,7 @@ static const struct rcar_dmac_of_data rcar_dmac_data = { .chan_offset_stride = 0x80, }; -static const struct rcar_dmac_of_data rcar_v3u_dmac_data = { +static const struct rcar_dmac_of_data rcar_gen4_dmac_data = { .chan_offset_base = 0x0, .chan_offset_stride = 0x1000, }; @@ -2018,9 +2018,12 @@ static const struct of_device_id rcar_dmac_of_ids[] = { { .compatible = "renesas,rcar-dmac", .data = &rcar_dmac_data, + }, { + .compatible = "renesas,rcar-gen4-dmac", + .data = &rcar_gen4_dmac_data, }, { .compatible = "renesas,dmac-r8a779a0", - .data = &rcar_v3u_dmac_data, + .data = &rcar_gen4_dmac_data, }, { /* Sentinel */ } };
Add support for R-Car S4-8. We can reuse R-Car V3U code so that renames variable names as "gen4". Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> --- drivers/dma/sh/rcar-dmac.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)