| Message ID | 20220101182806.19311-7-laurent.pinchart+renesas@ideasonboard.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | b904512bf693db4aaaa81b4db079eccb07600630 |
| Delegated to: | Kieran Bingham |
| Headers | show |
| Series | media: i2c: max9286: Small new features | expand |
Hi Laurent, On Sat, Jan 01, 2022 at 08:28:01PM +0200, Laurent Pinchart wrote: > The MAX9286_DATATYPE_RAW11 value is used to configure the MAX9286 for > 11-bit or 12-bit input data. While 11-bit data is supported on the GMSL > side, CSI-2 doesn't have a RAW11 format. 11-bit data is transferred over > CSI-2 as RAW12. Rename the macro accordingly to avoid confusion. > > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> Makes sense Reviewed-by: Jacopo Mondi <jacopo+renesas@jmondi.org> Thanks j > --- > drivers/media/i2c/max9286.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/i2c/max9286.c b/drivers/media/i2c/max9286.c > index 75374034724f..576d9c6fac14 100644 > --- a/drivers/media/i2c/max9286.c > +++ b/drivers/media/i2c/max9286.c > @@ -71,7 +71,7 @@ > #define MAX9286_DATATYPE_USER_YUV_12BIT (10 << 0) > #define MAX9286_DATATYPE_USER_24BIT (9 << 0) > #define MAX9286_DATATYPE_RAW14 (8 << 0) > -#define MAX9286_DATATYPE_RAW11 (7 << 0) > +#define MAX9286_DATATYPE_RAW12 (7 << 0) > #define MAX9286_DATATYPE_RAW10 (6 << 0) > #define MAX9286_DATATYPE_RAW8 (5 << 0) > #define MAX9286_DATATYPE_YUV422_10BIT (4 << 0) > -- > Regards, > > Laurent Pinchart >
diff --git a/drivers/media/i2c/max9286.c b/drivers/media/i2c/max9286.c index 75374034724f..576d9c6fac14 100644 --- a/drivers/media/i2c/max9286.c +++ b/drivers/media/i2c/max9286.c @@ -71,7 +71,7 @@ #define MAX9286_DATATYPE_USER_YUV_12BIT (10 << 0) #define MAX9286_DATATYPE_USER_24BIT (9 << 0) #define MAX9286_DATATYPE_RAW14 (8 << 0) -#define MAX9286_DATATYPE_RAW11 (7 << 0) +#define MAX9286_DATATYPE_RAW12 (7 << 0) #define MAX9286_DATATYPE_RAW10 (6 << 0) #define MAX9286_DATATYPE_RAW8 (5 << 0) #define MAX9286_DATATYPE_YUV422_10BIT (4 << 0)
The MAX9286_DATATYPE_RAW11 value is used to configure the MAX9286 for 11-bit or 12-bit input data. While 11-bit data is supported on the GMSL side, CSI-2 doesn't have a RAW11 format. 11-bit data is transferred over CSI-2 as RAW12. Rename the macro accordingly to avoid confusion. Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> --- drivers/media/i2c/max9286.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)