| Message ID | 20220316131100.30685-2-biju.das.jz@bp.renesas.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Kieran Bingham |
| Headers | show |
| Series | Add RZ/G2L Display support | expand |
On Wed, 16 Mar 2022 13:10:54 +0000, Biju Das wrote: > Extend the Renesas DU display bindings to support the r9a07g044l > DU module found on RZ/G2L LCDC. > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> > --- > v1->v2: > * Updated commit description. > * Removed LCDC references > * Changed clock name from du.0->aclk > * Changed reset name from du.0->du > RFC->v1: > * Changed minItems->maxItems for renesas,vsps. > RFC: > https://patchwork.kernel.org/project/linux-renesas-soc/patch/20220112174612.10773-18-biju.das.jz@bp.renesas.com/ > --- > .../bindings/display/renesas,du.yaml | 54 +++++++++++++++++++ > 1 file changed, 54 insertions(+) > Reviewed-by: Rob Herring <robh@kernel.org>
Hi Biju, On Wed, Mar 16, 2022 at 2:11 PM Biju Das <biju.das.jz@bp.renesas.com> wrote: > Extend the Renesas DU display bindings to support the r9a07g044l > DU module found on RZ/G2L LCDC. > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> Thanks for your patch! > --- a/Documentation/devicetree/bindings/display/renesas,du.yaml > +++ b/Documentation/devicetree/bindings/display/renesas,du.yaml > @@ -40,6 +40,7 @@ properties: > - renesas,du-r8a77990 # for R-Car E3 compatible DU > - renesas,du-r8a77995 # for R-Car D3 compatible DU > - renesas,du-r8a779a0 # for R-Car V3U compatible DU > + - renesas,du-r9a07g044l # for RZ/G2L compatible DU "renesas,du-r9a07g044"? Both RZ/G2L and RZ/G2LC have an LCDC. I believe the lack of parallel data support on RZ/G2LC is just a limitation of the package? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Hi Geert, Thanks for the feedback > Subject: Re: [PATCH v2 1/7] dt-bindings: display: renesas,du: Document > r9a07g044l bindings > > Hi Biju, > > On Wed, Mar 16, 2022 at 2:11 PM Biju Das <biju.das.jz@bp.renesas.com> > wrote: > > Extend the Renesas DU display bindings to support the r9a07g044l DU > > module found on RZ/G2L LCDC. > > > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> > > Thanks for your patch! > > > --- a/Documentation/devicetree/bindings/display/renesas,du.yaml > > +++ b/Documentation/devicetree/bindings/display/renesas,du.yaml > > @@ -40,6 +40,7 @@ properties: > > - renesas,du-r8a77990 # for R-Car E3 compatible DU > > - renesas,du-r8a77995 # for R-Car D3 compatible DU > > - renesas,du-r8a779a0 # for R-Car V3U compatible DU > > + - renesas,du-r9a07g044l # for RZ/G2L compatible DU > > "renesas,du-r9a07g044"? Both RZ/G2L and RZ/G2LC have an LCDC. > I believe the lack of parallel data support on RZ/G2LC is just a > limitation of the package? From the block diagram 24-bit video data from DU is connected to both DSI and parallel interface. However, SoC packaging wise RZ/G2LC supports only DSI interface. RZ/G2L supports both DSI and parallel interface RZ/G2LC supports only DSI interface OK, we could use "renesas,du-r9a07g044" as well. Regards, Biju
Hi Biju, Thank you for the patch. On Wed, Mar 16, 2022 at 01:10:54PM +0000, Biju Das wrote: > Extend the Renesas DU display bindings to support the r9a07g044l > DU module found on RZ/G2L LCDC. Stupid question, but as this DU and the R-Car DU are completely different pieces of hardware, wouldn't a separate bindings file make sense ? The DT description in this patch looks good to me. > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> > --- > v1->v2: > * Updated commit description. > * Removed LCDC references > * Changed clock name from du.0->aclk > * Changed reset name from du.0->du > RFC->v1: > * Changed minItems->maxItems for renesas,vsps. > RFC: > https://patchwork.kernel.org/project/linux-renesas-soc/patch/20220112174612.10773-18-biju.das.jz@bp.renesas.com/ > --- > .../bindings/display/renesas,du.yaml | 54 +++++++++++++++++++ > 1 file changed, 54 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/renesas,du.yaml b/Documentation/devicetree/bindings/display/renesas,du.yaml > index 13efea574584..f560608bf4e8 100644 > --- a/Documentation/devicetree/bindings/display/renesas,du.yaml > +++ b/Documentation/devicetree/bindings/display/renesas,du.yaml > @@ -40,6 +40,7 @@ properties: > - renesas,du-r8a77990 # for R-Car E3 compatible DU > - renesas,du-r8a77995 # for R-Car D3 compatible DU > - renesas,du-r8a779a0 # for R-Car V3U compatible DU > + - renesas,du-r9a07g044l # for RZ/G2L compatible DU > > reg: > maxItems: 1 > @@ -824,6 +825,59 @@ allOf: > - reset-names > - renesas,vsps > > + - if: > + properties: > + compatible: > + contains: > + enum: > + - renesas,du-r9a07g044l > + then: > + properties: > + clocks: > + items: > + - description: Main clock > + - description: Register access clock > + - description: Video clock > + > + clock-names: > + items: > + - const: aclk > + - const: pclk > + - const: vclk > + > + interrupts: > + maxItems: 1 > + > + resets: > + maxItems: 1 > + > + reset-names: > + items: > + - const: du > + > + ports: > + properties: > + port@0: > + description: DPAD 0 > + port@1: > + description: DSI 0 > + port@2: false > + port@3: false > + > + required: > + - port@0 > + - port@1 > + > + renesas,vsps: > + maxItems: 1 > + > + required: > + - clock-names > + - interrupts > + - resets > + - reset-names > + - renesas,vsps > + > additionalProperties: false > > examples:
Hi Laurent, Thanks for the feedback. > Subject: Re: [PATCH v2 1/7] dt-bindings: display: renesas,du: Document > r9a07g044l bindings > > Hi Biju, > > Thank you for the patch. > > On Wed, Mar 16, 2022 at 01:10:54PM +0000, Biju Das wrote: > > Extend the Renesas DU display bindings to support the r9a07g044l DU > > module found on RZ/G2L LCDC. > > Stupid question, but as this DU and the R-Car DU are completely different > pieces of hardware, wouldn't a separate bindings file make sense ? OK, will create separate bindings for RZ/G2L DU Cheers, Biju > > The DT description in this patch looks good to me. > > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> > > --- > > v1->v2: > > * Updated commit description. > > * Removed LCDC references > > * Changed clock name from du.0->aclk > > * Changed reset name from du.0->du > > RFC->v1: > > * Changed minItems->maxItems for renesas,vsps. > > RFC: > > > > --- > > .../bindings/display/renesas,du.yaml | 54 +++++++++++++++++++ > > 1 file changed, 54 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/display/renesas,du.yaml > > b/Documentation/devicetree/bindings/display/renesas,du.yaml > > index 13efea574584..f560608bf4e8 100644 > > --- a/Documentation/devicetree/bindings/display/renesas,du.yaml > > +++ b/Documentation/devicetree/bindings/display/renesas,du.yaml > > @@ -40,6 +40,7 @@ properties: > > - renesas,du-r8a77990 # for R-Car E3 compatible DU > > - renesas,du-r8a77995 # for R-Car D3 compatible DU > > - renesas,du-r8a779a0 # for R-Car V3U compatible DU > > + - renesas,du-r9a07g044l # for RZ/G2L compatible DU > > > > reg: > > maxItems: 1 > > @@ -824,6 +825,59 @@ allOf: > > - reset-names > > - renesas,vsps > > > > + - if: > > + properties: > > + compatible: > > + contains: > > + enum: > > + - renesas,du-r9a07g044l > > + then: > > + properties: > > + clocks: > > + items: > > + - description: Main clock > > + - description: Register access clock > > + - description: Video clock > > + > > + clock-names: > > + items: > > + - const: aclk > > + - const: pclk > > + - const: vclk > > + > > + interrupts: > > + maxItems: 1 > > + > > + resets: > > + maxItems: 1 > > + > > + reset-names: > > + items: > > + - const: du > > + > > + ports: > > + properties: > > + port@0: > > + description: DPAD 0 > > + port@1: > > + description: DSI 0 > > + port@2: false > > + port@3: false > > + > > + required: > > + - port@0 > > + - port@1 > > + > > + renesas,vsps: > > + maxItems: 1 > > + > > + required: > > + - clock-names > > + - interrupts > > + - resets > > + - reset-names > > + - renesas,vsps > > + > > additionalProperties: false > > > > examples: > > -- > Regards, > > Laurent Pinchart
diff --git a/Documentation/devicetree/bindings/display/renesas,du.yaml b/Documentation/devicetree/bindings/display/renesas,du.yaml index 13efea574584..f560608bf4e8 100644 --- a/Documentation/devicetree/bindings/display/renesas,du.yaml +++ b/Documentation/devicetree/bindings/display/renesas,du.yaml @@ -40,6 +40,7 @@ properties: - renesas,du-r8a77990 # for R-Car E3 compatible DU - renesas,du-r8a77995 # for R-Car D3 compatible DU - renesas,du-r8a779a0 # for R-Car V3U compatible DU + - renesas,du-r9a07g044l # for RZ/G2L compatible DU reg: maxItems: 1 @@ -824,6 +825,59 @@ allOf: - reset-names - renesas,vsps + - if: + properties: + compatible: + contains: + enum: + - renesas,du-r9a07g044l + then: + properties: + clocks: + items: + - description: Main clock + - description: Register access clock + - description: Video clock + + clock-names: + items: + - const: aclk + - const: pclk + - const: vclk + + interrupts: + maxItems: 1 + + resets: + maxItems: 1 + + reset-names: + items: + - const: du + + ports: + properties: + port@0: + description: DPAD 0 + port@1: + description: DSI 0 + port@2: false + port@3: false + + required: + - port@0 + - port@1 + + renesas,vsps: + maxItems: 1 + + required: + - clock-names + - interrupts + - resets + - reset-names + - renesas,vsps + additionalProperties: false examples:
Extend the Renesas DU display bindings to support the r9a07g044l DU module found on RZ/G2L LCDC. Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> --- v1->v2: * Updated commit description. * Removed LCDC references * Changed clock name from du.0->aclk * Changed reset name from du.0->du RFC->v1: * Changed minItems->maxItems for renesas,vsps. RFC: https://patchwork.kernel.org/project/linux-renesas-soc/patch/20220112174612.10773-18-biju.das.jz@bp.renesas.com/ --- .../bindings/display/renesas,du.yaml | 54 +++++++++++++++++++ 1 file changed, 54 insertions(+)