| Message ID | 20220405184716.1578385-2-miquel.raynal@bootlin.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
| Series | RZN1 RTC support | expand |
On 05/04/2022 20:47, Miquel Raynal wrote: > Add new binding file for this RTC. > > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> > --- > .../bindings/rtc/renesas,rzn1-rtc.yaml | 69 +++++++++++++++++++ > 1 file changed, 69 insertions(+) > create mode 100644 Documentation/devicetree/bindings/rtc/renesas,rzn1-rtc.yaml > > diff --git a/Documentation/devicetree/bindings/rtc/renesas,rzn1-rtc.yaml b/Documentation/devicetree/bindings/rtc/renesas,rzn1-rtc.yaml > new file mode 100644 > index 000000000000..903f0cd361fa > --- /dev/null > +++ b/Documentation/devicetree/bindings/rtc/renesas,rzn1-rtc.yaml > @@ -0,0 +1,69 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/rtc/renesas,rzn1-rtc.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Renesas RZ/N1 SoCs Real-Time Clock DT bindings > + > +maintainers: > + - Miquel Raynal <miquel.raynal@bootlin.com> > + > +allOf: > + - $ref: rtc.yaml# > + > +properties: > + compatible: > + oneOf: Why oneOf? > + - items: > + - enum: > + - renesas,r9a06g032-rtc > + - const: renesas,rzn1-rtc > + > + reg: > + maxItems: 1 > + > + interrupts: > + minItems: 3 > + maxItems: 3 > + > + interrupt-names: > + items: > + - const: alarm > + - const: timer > + - const: pps > + > + clocks: > + maxItems: 1 > + > + clock-names: > + const: hclk > + > + start-year: true You don't need this, it's coming from rtc.yaml. Best regards, Krzysztof
Hi Krzysztof, krzysztof.kozlowski@linaro.org wrote on Thu, 7 Apr 2022 09:37:39 +0200: > On 05/04/2022 20:47, Miquel Raynal wrote: > > Add new binding file for this RTC. > > > > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> > > --- > > .../bindings/rtc/renesas,rzn1-rtc.yaml | 69 +++++++++++++++++++ > > 1 file changed, 69 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/rtc/renesas,rzn1-rtc.yaml > > > > diff --git a/Documentation/devicetree/bindings/rtc/renesas,rzn1-rtc.yaml b/Documentation/devicetree/bindings/rtc/renesas,rzn1-rtc.yaml > > new file mode 100644 > > index 000000000000..903f0cd361fa > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/rtc/renesas,rzn1-rtc.yaml > > @@ -0,0 +1,69 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/rtc/renesas,rzn1-rtc.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Renesas RZ/N1 SoCs Real-Time Clock DT bindings > > + > > +maintainers: > > + - Miquel Raynal <miquel.raynal@bootlin.com> > > + > > +allOf: > > + - $ref: rtc.yaml# > > + > > +properties: > > + compatible: > > + oneOf: > > Why oneOf? Right, copy-paste leftover. > > > + - items: > > + - enum: > > + - renesas,r9a06g032-rtc > > + - const: renesas,rzn1-rtc > > + > > + reg: > > + maxItems: 1 > > + > > + interrupts: > > + minItems: 3 > > + maxItems: 3 > > + > > + interrupt-names: > > + items: > > + - const: alarm > > + - const: timer > > + - const: pps > > + > > + clocks: > > + maxItems: 1 > > + > > + clock-names: > > + const: hclk > > + > > + start-year: true > > You don't need this, it's coming from rtc.yaml. Right. Thanks, Miquèl
diff --git a/Documentation/devicetree/bindings/rtc/renesas,rzn1-rtc.yaml b/Documentation/devicetree/bindings/rtc/renesas,rzn1-rtc.yaml new file mode 100644 index 000000000000..903f0cd361fa --- /dev/null +++ b/Documentation/devicetree/bindings/rtc/renesas,rzn1-rtc.yaml @@ -0,0 +1,69 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/rtc/renesas,rzn1-rtc.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Renesas RZ/N1 SoCs Real-Time Clock DT bindings + +maintainers: + - Miquel Raynal <miquel.raynal@bootlin.com> + +allOf: + - $ref: rtc.yaml# + +properties: + compatible: + oneOf: + - items: + - enum: + - renesas,r9a06g032-rtc + - const: renesas,rzn1-rtc + + reg: + maxItems: 1 + + interrupts: + minItems: 3 + maxItems: 3 + + interrupt-names: + items: + - const: alarm + - const: timer + - const: pps + + clocks: + maxItems: 1 + + clock-names: + const: hclk + + start-year: true + +required: + - compatible + - reg + - interrupts + - interrupt-names + - clocks + - clock-names + - start-year + +unevaluatedProperties: false + +examples: + - | + #include <dt-bindings/interrupt-controller/arm-gic.h> + #include <dt-bindings/clock/r9a06g032-sysctrl.h> + rtc@40006000 { + compatible = "renesas,r9a06g032-rtc", "renesas,rzn1-rtc"; + reg = <0x40006000 0x1000>; + interrupts = <GIC_SPI 66 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 67 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 68 IRQ_TYPE_EDGE_RISING>; + interrupt-names = "alarm", "timer", "pps"; + clocks = <&sysctrl R9A06G032_HCLK_RTC>; + clock-names = "hclk"; + start-year = <2000>; + };
Add new binding file for this RTC. Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> --- .../bindings/rtc/renesas,rzn1-rtc.yaml | 69 +++++++++++++++++++ 1 file changed, 69 insertions(+) create mode 100644 Documentation/devicetree/bindings/rtc/renesas,rzn1-rtc.yaml