| Message ID | 20220613131033.10053-2-wsa+renesas@sang-engineering.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 872f918469a572585003128509a842f39559aef6 |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
| Series | [1/2] arm64: dts: renesas: r8a779f0: Add HSCIF 0+1 nodes | expand |
Hi Wolfram, Thanks for your patch! On Mon, Jun 13, 2022 at 3:10 PM Wolfram Sang <wsa+renesas@sang-engineering.com> wrote: > Every loader before Linux utilizes HSCIF0 with a speed of 1843200bps. > Make Linux behave the same. Is that true for all boards? Was there a firmware flag day? I.e. the U-Boot on the Spider in Magnus' lab has "baudrate=115200" in its environment, while I can read the output from ICUMXA Loader to U-Boot, and Linux just fine. > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Hi Geert, > I.e. the U-Boot on the Spider in Magnus' lab has "baudrate=115200" > in its environment, while I can read the output from ICUMXA Loader > to U-Boot, and Linux just fine. Earlier U-Boot may have no HSCIF support. Recent ones have and the installer suggests to set baudrate to highspeed. ICUMXA loaders never worked for me in 115200. I can keep my patch local if you prefer 115200.
Hi Wolfram, On Wed, Jun 15, 2022 at 11:37 AM Wolfram Sang <wsa+renesas@sang-engineering.com> wrote: > > I.e. the U-Boot on the Spider in Magnus' lab has "baudrate=115200" > > in its environment, while I can read the output from ICUMXA Loader > > to U-Boot, and Linux just fine. > > Earlier U-Boot may have no HSCIF support. Recent ones have and the > installer suggests to set baudrate to highspeed. ICUMXA loaders never > worked for me in 115200. > > I can keep my patch local if you prefer 115200. As all active white-hawk users are now suffering from this, I will queue your patch in renesas-devel for v6.2. Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
diff --git a/arch/arm64/boot/dts/renesas/r8a779f0-spider-cpu.dtsi b/arch/arm64/boot/dts/renesas/r8a779f0-spider-cpu.dtsi index 41aa8591b3b1..3208d2148768 100644 --- a/arch/arm64/boot/dts/renesas/r8a779f0-spider-cpu.dtsi +++ b/arch/arm64/boot/dts/renesas/r8a779f0-spider-cpu.dtsi @@ -31,6 +31,14 @@ &extalr_clk { clock-frequency = <32768>; }; +&hscif0 { + pinctrl-0 = <&hscif0_pins>; + pinctrl-names = "default"; + + uart-has-rtscts; + status = "okay"; +}; + &i2c4 { pinctrl-0 = <&i2c4_pins>; pinctrl-names = "default"; @@ -50,16 +58,16 @@ &pfc { pinctrl-0 = <&scif_clk_pins>; pinctrl-names = "default"; + hscif0_pins: hscif0 { + groups = "hscif0_data", "hscif0_ctrl"; + function = "hscif0"; + }; + i2c4_pins: i2c4 { groups = "i2c4"; function = "i2c4"; }; - scif3_pins: scif3 { - groups = "scif3_data", "scif3_ctrl"; - function = "scif3"; - }; - scif_clk_pins: scif_clk { groups = "scif_clk"; function = "scif_clk"; @@ -71,14 +79,6 @@ &rwdt { status = "okay"; }; -&scif3 { - pinctrl-0 = <&scif3_pins>; - pinctrl-names = "default"; - - uart-has-rtscts; - status = "okay"; -}; - &scif_clk { clock-frequency = <24000000>; }; diff --git a/arch/arm64/boot/dts/renesas/r8a779f0-spider.dts b/arch/arm64/boot/dts/renesas/r8a779f0-spider.dts index 2e3b719cc749..954ba227bfa7 100644 --- a/arch/arm64/boot/dts/renesas/r8a779f0-spider.dts +++ b/arch/arm64/boot/dts/renesas/r8a779f0-spider.dts @@ -14,11 +14,11 @@ / { compatible = "renesas,spider-breakout", "renesas,spider-cpu", "renesas,r8a779f0"; aliases { - serial0 = &scif3; + serial0 = &hscif0; }; chosen { - stdout-path = "serial0:115200n8"; + stdout-path = "serial0:1843200n8"; }; };
Every loader before Linux utilizes HSCIF0 with a speed of 1843200bps. Make Linux behave the same. Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> --- .../boot/dts/renesas/r8a779f0-spider-cpu.dtsi | 26 +++++++++---------- .../boot/dts/renesas/r8a779f0-spider.dts | 4 +-- 2 files changed, 15 insertions(+), 15 deletions(-)