| Message ID | 20220616170821.1348169-1-steve@sk2.org (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | ad4fd3b1dfd3e3496bd21a5caee35540112fe95e |
| Delegated to: | Kieran Bingham |
| Headers | show |
| Series | [v2] drm: shmobile: Use backlight helper | expand |
Hi Stephen, Thank you for the patch. On Thu, Jun 16, 2022 at 07:08:21PM +0200, Stephen Kitt wrote: > This started with work on the removal of backlight_properties' > deprecated fb_blank field, much of which can be taken care of by using > helper functions provided by backlight.h instead of directly accessing > fields in backlight_properties. This patch series doesn't involve > fb_blank, but it still seems useful to use helper functions where > appropriate. > > Instead of retrieving the backlight brightness in struct > backlight_properties manually, and then checking whether the backlight > should be on at all, use backlight_get_brightness() which does all > this and insulates this from future changes. > > Signed-off-by: Stephen Kitt <steve@sk2.org> > Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > Cc: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> > Cc: David Airlie <airlied@linux.ie> > Cc: Daniel Vetter <daniel@ffwll.ch> > Cc: dri-devel@lists.freedesktop.org Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > Changes since v1: clarified commit message, this doesn't touch fb_blank > --- > drivers/gpu/drm/shmobile/shmob_drm_backlight.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/shmobile/shmob_drm_backlight.c b/drivers/gpu/drm/shmobile/shmob_drm_backlight.c > index f6628a5ee95f..794573badfe8 100644 > --- a/drivers/gpu/drm/shmobile/shmob_drm_backlight.c > +++ b/drivers/gpu/drm/shmobile/shmob_drm_backlight.c > @@ -18,11 +18,7 @@ static int shmob_drm_backlight_update(struct backlight_device *bdev) > struct shmob_drm_connector *scon = bl_get_data(bdev); > struct shmob_drm_device *sdev = scon->connector.dev->dev_private; > const struct shmob_drm_backlight_data *bdata = &sdev->pdata->backlight; > - int brightness = bdev->props.brightness; > - > - if (bdev->props.power != FB_BLANK_UNBLANK || > - bdev->props.state & BL_CORE_SUSPENDED) > - brightness = 0; > + int brightness = backlight_get_brightness(bdev); > > return bdata->set_brightness(brightness); > } > > base-commit: f2906aa863381afb0015a9eb7fefad885d4e5a56
Quoting Stephen Kitt (2022-06-16 18:08:21) > This started with work on the removal of backlight_properties' > deprecated fb_blank field, much of which can be taken care of by using > helper functions provided by backlight.h instead of directly accessing > fields in backlight_properties. This patch series doesn't involve > fb_blank, but it still seems useful to use helper functions where > appropriate. > > Instead of retrieving the backlight brightness in struct > backlight_properties manually, and then checking whether the backlight > should be on at all, use backlight_get_brightness() which does all > this and insulates this from future changes. > > Signed-off-by: Stephen Kitt <steve@sk2.org> > Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > Cc: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> Hi Stephen, This looks reasonable to me too. Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> > Cc: David Airlie <airlied@linux.ie> > Cc: Daniel Vetter <daniel@ffwll.ch> > Cc: dri-devel@lists.freedesktop.org > --- > Changes since v1: clarified commit message, this doesn't touch fb_blank > --- > drivers/gpu/drm/shmobile/shmob_drm_backlight.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/shmobile/shmob_drm_backlight.c b/drivers/gpu/drm/shmobile/shmob_drm_backlight.c > index f6628a5ee95f..794573badfe8 100644 > --- a/drivers/gpu/drm/shmobile/shmob_drm_backlight.c > +++ b/drivers/gpu/drm/shmobile/shmob_drm_backlight.c > @@ -18,11 +18,7 @@ static int shmob_drm_backlight_update(struct backlight_device *bdev) > struct shmob_drm_connector *scon = bl_get_data(bdev); > struct shmob_drm_device *sdev = scon->connector.dev->dev_private; > const struct shmob_drm_backlight_data *bdata = &sdev->pdata->backlight; > - int brightness = bdev->props.brightness; > - > - if (bdev->props.power != FB_BLANK_UNBLANK || > - bdev->props.state & BL_CORE_SUSPENDED) > - brightness = 0; > + int brightness = backlight_get_brightness(bdev); > > return bdata->set_brightness(brightness); > } > > base-commit: f2906aa863381afb0015a9eb7fefad885d4e5a56 > -- > 2.30.2 >
On Thu, Jun 16, 2022 at 07:08:21PM +0200, Stephen Kitt wrote: > This started with work on the removal of backlight_properties' > deprecated fb_blank field, much of which can be taken care of by using > helper functions provided by backlight.h instead of directly accessing > fields in backlight_properties. This patch series doesn't involve > fb_blank, but it still seems useful to use helper functions where > appropriate. > > Instead of retrieving the backlight brightness in struct > backlight_properties manually, and then checking whether the backlight > should be on at all, use backlight_get_brightness() which does all > this and insulates this from future changes. > > Signed-off-by: Stephen Kitt <steve@sk2.org> > Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > Cc: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> > Cc: David Airlie <airlied@linux.ie> > Cc: Daniel Vetter <daniel@ffwll.ch> > Cc: dri-devel@lists.freedesktop.org Thanks, added to drm-misc (drm-misc-next) Sam
diff --git a/drivers/gpu/drm/shmobile/shmob_drm_backlight.c b/drivers/gpu/drm/shmobile/shmob_drm_backlight.c index f6628a5ee95f..794573badfe8 100644 --- a/drivers/gpu/drm/shmobile/shmob_drm_backlight.c +++ b/drivers/gpu/drm/shmobile/shmob_drm_backlight.c @@ -18,11 +18,7 @@ static int shmob_drm_backlight_update(struct backlight_device *bdev) struct shmob_drm_connector *scon = bl_get_data(bdev); struct shmob_drm_device *sdev = scon->connector.dev->dev_private; const struct shmob_drm_backlight_data *bdata = &sdev->pdata->backlight; - int brightness = bdev->props.brightness; - - if (bdev->props.power != FB_BLANK_UNBLANK || - bdev->props.state & BL_CORE_SUSPENDED) - brightness = 0; + int brightness = backlight_get_brightness(bdev); return bdata->set_brightness(brightness); }
This started with work on the removal of backlight_properties' deprecated fb_blank field, much of which can be taken care of by using helper functions provided by backlight.h instead of directly accessing fields in backlight_properties. This patch series doesn't involve fb_blank, but it still seems useful to use helper functions where appropriate. Instead of retrieving the backlight brightness in struct backlight_properties manually, and then checking whether the backlight should be on at all, use backlight_get_brightness() which does all this and insulates this from future changes. Signed-off-by: Stephen Kitt <steve@sk2.org> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Cc: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> Cc: David Airlie <airlied@linux.ie> Cc: Daniel Vetter <daniel@ffwll.ch> Cc: dri-devel@lists.freedesktop.org --- Changes since v1: clarified commit message, this doesn't touch fb_blank --- drivers/gpu/drm/shmobile/shmob_drm_backlight.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) base-commit: f2906aa863381afb0015a9eb7fefad885d4e5a56