| Message ID | 20220628122330.28323-1-wsa+renesas@sang-engineering.com (mailing list archive) |
|---|---|
| State | Under Review |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
| Series | [RFC] arm64: dts: renesas: ebisu: add port node to ak4613 | expand |
Hi Wolfram Thank you for contacting me, and sorry for my bug. > My Ebisu complains about the missing node when booting: > > OF: graph: no port node found in /soc/i2c@e66d0000/codec@10 > ------------[ cut here ]------------ > WARNING: CPU: 1 PID: 37 at sound/soc/codecs/ak4613.c:873 ak4613_i2c_probe+0x274/0x2a0 > CPU: 1 PID: 37 Comm: kworker/u4:2 Not tainted 5.19.0-rc3-arm64-renesas-00003-g57c83727d651 #50 > Hardware name: Renesas Ebisu board based on r8a77990 (DT) > > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> > --- > > Hi Morimoto-san, I have never done any sound stuff with R-Car. Is this > the correct approach which I copied over from Salvator boards? Could you try this patch ? It should goto linus tree, but it seems not yet ?? https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=ec3ad554b956d5dbefa1962c419f164ba223e6b3 Thank you for your help !! Best regards --- Kuninori Morimoto
Hi Morimoto-san, > Thank you for contacting me, > and sorry for my bug. No worries, bugs happen all the time to all of us. > Could you try this patch ? Thank you! It works \o/ > It should goto linus tree, but it seems not yet ?? It is also not in renesas-drivers, this is why I am still seeing this issue. Now I know. > Thank you for your help !! Thank YOU! :D All the best, Wolfram
Hi Wolfram, On Wed, Jun 29, 2022 at 8:34 AM Wolfram Sang <wsa+renesas@sang-engineering.com> wrote: > > Thank you for contacting me, > > and sorry for my bug. > > No worries, bugs happen all the time to all of us. > > > Could you try this patch ? > > Thank you! It works \o/ > > > It should goto linus tree, but it seems not yet ?? > > It is also not in renesas-drivers, this is why I am still seeing this > issue. Now I know. Strange, I thought it was included. "git show --pretty=fuller" shows it was committed by Mark Bown on June 8. Looks like the branch with the commit was not included in sound-asoc/for-next, only in sound-asoc/fixes, when I made last renesas-drivers. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
diff --git a/arch/arm64/boot/dts/renesas/ebisu.dtsi b/arch/arm64/boot/dts/renesas/ebisu.dtsi index 8fc03491a11c..cec23a3287c0 100644 --- a/arch/arm64/boot/dts/renesas/ebisu.dtsi +++ b/arch/arm64/boot/dts/renesas/ebisu.dtsi @@ -478,6 +478,12 @@ ak4613: codec@10 { asahi-kasei,out4-single-end; asahi-kasei,out5-single-end; asahi-kasei,out6-single-end; + + port { + ak4613_endpoint: endpoint { + remote-endpoint = <&rsnd_endpoint0>; + }; + }; }; cs2000: clk-multiplier@4f { @@ -708,13 +714,23 @@ &rcar_sound { <&audio_clk_a>, <&cs2000>, <&audio_clk_c>, <&cpg CPG_CORE R8A77990_CLK_ZA2>; - rcar_sound,dai { - dai0 { - playback = <&ssi0>, <&src0>, <&dvc0>; - capture = <&ssi1>, <&src1>, <&dvc1>; + ports { + #address-cells = <1>; + #size-cells = <0>; + rsnd_port0: port@0 { + reg = <0>; + rsnd_endpoint0: endpoint { + remote-endpoint = <&ak4613_endpoint>; + + dai-format = "left_j"; + bitclock-master = <&rsnd_endpoint0>; + frame-master = <&rsnd_endpoint0>; + + playback = <&ssi0>, <&src0>, <&dvc0>; + capture = <&ssi1>, <&src1>, <&dvc1>; + }; }; }; - }; &rpc {
My Ebisu complains about the missing node when booting: OF: graph: no port node found in /soc/i2c@e66d0000/codec@10 ------------[ cut here ]------------ WARNING: CPU: 1 PID: 37 at sound/soc/codecs/ak4613.c:873 ak4613_i2c_probe+0x274/0x2a0 CPU: 1 PID: 37 Comm: kworker/u4:2 Not tainted 5.19.0-rc3-arm64-renesas-00003-g57c83727d651 #50 Hardware name: Renesas Ebisu board based on r8a77990 (DT) Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> --- Hi Morimoto-san, I have never done any sound stuff with R-Car. Is this the correct approach which I copied over from Salvator boards? All the best, Wolfram arch/arm64/boot/dts/renesas/ebisu.dtsi | 26 +++++++++++++++++++++----- 1 file changed, 21 insertions(+), 5 deletions(-)