| Message ID | 20220630162515.37302-1-clement.leger@bootlin.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
| Series | [net-next,v2] dt-bindings: net: dsa: renesas,rzn1-a5psw: add interrupts description | expand |
On Thu, 30 Jun 2022 18:25:15 +0200, Clément Léger wrote: > Describe the switch interrupts (dlr, switch, prp, hub, pattern) which > are connected to the GIC. > > Signed-off-by: Clément Léger <clement.leger@bootlin.com> > --- > Changes in V2: > - Fix typo in interrupt-names property. > > .../bindings/net/dsa/renesas,rzn1-a5psw.yaml | 23 +++++++++++++++++++ > 1 file changed, 23 insertions(+) > Reviewed-by: Rob Herring <robh@kernel.org>
Hi Clément, On Thu, Jun 30, 2022 at 6:26 PM Clément Léger <clement.leger@bootlin.com> wrote: > Describe the switch interrupts (dlr, switch, prp, hub, pattern) which > are connected to the GIC. > > Signed-off-by: Clément Léger <clement.leger@bootlin.com> > --- > Changes in V2: > - Fix typo in interrupt-names property. Thanks for the update! Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> but some suggestions below. > --- a/Documentation/devicetree/bindings/net/dsa/renesas,rzn1-a5psw.yaml > +++ b/Documentation/devicetree/bindings/net/dsa/renesas,rzn1-a5psw.yaml > @@ -26,6 +26,22 @@ properties: > reg: > maxItems: 1 > > + interrupts: > + items: > + - description: DLR interrupt Device Level Ring (DLR) interrupt? > + - description: Switch interrupt > + - description: PRP interrupt Parallel Redundancy Protocol (PRP) interrupt? > + - description: Integrated HUB module interrupt > + - description: RX Pattern interrupt Receive Pattern Match interrupt? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Le Fri, 1 Jul 2022 09:45:51 +0200, Geert Uytterhoeven <geert@linux-m68k.org> a écrit : > Hi Clément, > > On Thu, Jun 30, 2022 at 6:26 PM Clément Léger <clement.leger@bootlin.com> wrote: > > Describe the switch interrupts (dlr, switch, prp, hub, pattern) which > > are connected to the GIC. > > > > Signed-off-by: Clément Léger <clement.leger@bootlin.com> > > --- > > Changes in V2: > > - Fix typo in interrupt-names property. > > Thanks for the update! > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > but some suggestions below. > > > --- a/Documentation/devicetree/bindings/net/dsa/renesas,rzn1-a5psw.yaml > > +++ b/Documentation/devicetree/bindings/net/dsa/renesas,rzn1-a5psw.yaml > > @@ -26,6 +26,22 @@ properties: > > reg: > > maxItems: 1 > > > > + interrupts: > > + items: > > + - description: DLR interrupt > > Device Level Ring (DLR) interrupt? > > > + - description: Switch interrupt > > + - description: PRP interrupt > > Parallel Redundancy Protocol (PRP) interrupt? > > > + - description: Integrated HUB module interrupt > > + - description: RX Pattern interrupt > > Receive Pattern Match interrupt? Hi Geert, I'll modify that and send a V3, thanks for your comments ! > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds
diff --git a/Documentation/devicetree/bindings/net/dsa/renesas,rzn1-a5psw.yaml b/Documentation/devicetree/bindings/net/dsa/renesas,rzn1-a5psw.yaml index 103b1ef5af1b..e68c7e353100 100644 --- a/Documentation/devicetree/bindings/net/dsa/renesas,rzn1-a5psw.yaml +++ b/Documentation/devicetree/bindings/net/dsa/renesas,rzn1-a5psw.yaml @@ -26,6 +26,22 @@ properties: reg: maxItems: 1 + interrupts: + items: + - description: DLR interrupt + - description: Switch interrupt + - description: PRP interrupt + - description: Integrated HUB module interrupt + - description: RX Pattern interrupt + + interrupt-names: + items: + - const: dlr + - const: switch + - const: prp + - const: hub + - const: ptrn + power-domains: maxItems: 1 @@ -76,6 +92,7 @@ examples: - | #include <dt-bindings/gpio/gpio.h> #include <dt-bindings/clock/r9a06g032-sysctrl.h> + #include <dt-bindings/interrupt-controller/arm-gic.h> switch@44050000 { compatible = "renesas,r9a06g032-a5psw", "renesas,rzn1-a5psw"; @@ -83,6 +100,12 @@ examples: clocks = <&sysctrl R9A06G032_HCLK_SWITCH>, <&sysctrl R9A06G032_CLK_SWITCH>; clock-names = "hclk", "clk"; power-domains = <&sysctrl>; + interrupts = <GIC_SPI 40 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 42 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 43 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 44 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 45 IRQ_TYPE_LEVEL_HIGH>; + interrupt-names = "dlr", "switch", "prp", "hub", "ptrn"; dsa,member = <0 0>;
Describe the switch interrupts (dlr, switch, prp, hub, pattern) which are connected to the GIC. Signed-off-by: Clément Léger <clement.leger@bootlin.com> --- Changes in V2: - Fix typo in interrupt-names property. .../bindings/net/dsa/renesas,rzn1-a5psw.yaml | 23 +++++++++++++++++++ 1 file changed, 23 insertions(+)