| Message ID | 20220705015036.106937-1-yang.lee@linux.alibaba.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
| Series | [-next] pinctrl: renesas: remove unneeded semicolon | expand |
On Tue, Jul 5, 2022 at 3:50 AM Yang Li <yang.lee@linux.alibaba.com> wrote: > Eliminate the following coccicheck warnings: > ./drivers/pinctrl/renesas/pinctrl-rzv2m.c:487:3-4: Unneeded semicolon > ./drivers/pinctrl/renesas/pinctrl-rzv2m.c:519:3-4: Unneeded semicolon > ./drivers/pinctrl/renesas/pinctrl-rzv2m.c:591:4-5: Unneeded semicolon > ./drivers/pinctrl/renesas/pinctrl-rzv2m.c:620:4-5: Unneeded semicolon > > Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> As the original commit has not been pulled into the pinctrl tree yet, I will amend the original commit in renesas-pinctrl-for-v5.20. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
diff --git a/drivers/pinctrl/renesas/pinctrl-rzv2m.c b/drivers/pinctrl/renesas/pinctrl-rzv2m.c index 1afc6bb4386a..e8c18198bebd 100644 --- a/drivers/pinctrl/renesas/pinctrl-rzv2m.c +++ b/drivers/pinctrl/renesas/pinctrl-rzv2m.c @@ -484,7 +484,7 @@ static int rzv2m_pinctrl_pinconf_get(struct pinctrl_dev *pctldev, break; default: bias = PIN_CONFIG_BIAS_DISABLE; - }; + } if (bias != param) return -EINVAL; @@ -516,7 +516,7 @@ static int rzv2m_pinctrl_pinconf_get(struct pinctrl_dev *pctldev, break; default: return -EINVAL; - }; + } break; @@ -588,7 +588,7 @@ static int rzv2m_pinctrl_pinconf_set(struct pinctrl_dev *pctldev, break; default: val = 1; - }; + } rzv2m_rmw_pin_config(pctrl, PUPD(port), bit, PUPD_MASK, val); break; @@ -617,7 +617,7 @@ static int rzv2m_pinctrl_pinconf_set(struct pinctrl_dev *pctldev, break; default: return -EINVAL; - }; + } for (index = 0; index < 4; index++) { if (arg == drv_strengths[index])
Eliminate the following coccicheck warnings: ./drivers/pinctrl/renesas/pinctrl-rzv2m.c:487:3-4: Unneeded semicolon ./drivers/pinctrl/renesas/pinctrl-rzv2m.c:519:3-4: Unneeded semicolon ./drivers/pinctrl/renesas/pinctrl-rzv2m.c:591:4-5: Unneeded semicolon ./drivers/pinctrl/renesas/pinctrl-rzv2m.c:620:4-5: Unneeded semicolon Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> --- drivers/pinctrl/renesas/pinctrl-rzv2m.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)