Message ID | 20220708071306.4354-2-jslaby@suse.cz (mailing list archive) |
---|---|
State | Mainlined |
Commit | 0e704f6c42dc64f081d0b1738d06b2dee9524f27 |
Delegated to: | Geert Uytterhoeven |
Headers | show |
Series | None | expand |
Hi Jiri, On Fri, Jul 8, 2022 at 9:13 AM Jiri Slaby <jslaby@suse.cz> wrote: > From: Andi Kleen <ak@linux.intel.com> > > A variable pointing to const isn't const itself. It'd have to contain > "const" keyword after "*" too. Therefore, cpg_pll_config cannot be put > to "rodata". Hence use __initdata instead of __initconst to fix this. > > [js] more explanatory commit message. > > Cc: Geert Uytterhoeven <geert+renesas@glider.be> > Cc: Michael Turquette <mturquette@baylibre.com> > Cc: linux-renesas-soc@vger.kernel.org > Cc: linux-clk@vger.kernel.org > Cc: Martin Liska <mliska@suse.cz> > Acked-by: Stephen Boyd <sboyd@kernel.org> > Signed-off-by: Andi Kleen <ak@linux.intel.com> > Signed-off-by: Jiri Slaby <jslaby@suse.cz> Already queued as commit 0e704f6c42dc64f0 ("clk: renesas: rcar-gen4: Fix initconst confusion for cpg_pll_config") in renesas-clk-for-v5.20, and next-20220706 and later. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
diff --git a/drivers/clk/renesas/rcar-gen4-cpg.c b/drivers/clk/renesas/rcar-gen4-cpg.c index c7ed43d6aa67..e27832e5114f 100644 --- a/drivers/clk/renesas/rcar-gen4-cpg.c +++ b/drivers/clk/renesas/rcar-gen4-cpg.c @@ -23,7 +23,7 @@ #include "rcar-gen4-cpg.h" #include "rcar-cpg-lib.h" -static const struct rcar_gen4_cpg_pll_config *cpg_pll_config __initconst; +static const struct rcar_gen4_cpg_pll_config *cpg_pll_config __initdata; static unsigned int cpg_clk_extalr __initdata; static u32 cpg_mode __initdata;