| Message ID | 20220713100603.3391-2-wsa+renesas@sang-engineering.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
| Series | clocksource: sh_cmt: add Gen4 and r8a779f0 support | expand |
On 13/07/2022 12:06, Wolfram Sang wrote: > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> Krzysztof ? > --- > .../devicetree/bindings/timer/renesas,cmt.yaml | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/Documentation/devicetree/bindings/timer/renesas,cmt.yaml b/Documentation/devicetree/bindings/timer/renesas,cmt.yaml > index 53dd6d9f518f..7cc1ec4b4e38 100644 > --- a/Documentation/devicetree/bindings/timer/renesas,cmt.yaml > +++ b/Documentation/devicetree/bindings/timer/renesas,cmt.yaml > @@ -83,6 +83,11 @@ properties: > - renesas,r8a779a0-cmt0 # 32-bit CMT0 on R-Car V3U > - const: renesas,rcar-gen3-cmt0 # 32-bit CMT0 on R-Car Gen3 and RZ/G2 > > + - items: > + - enum: > + - renesas,r8a779f0-cmt0 # 32-bit CMT0 on R-Car S4-8 > + - const: renesas,rcar-gen4-cmt0 # 32-bit CMT0 on R-Car Gen4 > + > - items: > - enum: > - renesas,r8a774a1-cmt1 # 48-bit CMT on RZ/G2M > @@ -100,6 +105,11 @@ properties: > - renesas,r8a779a0-cmt1 # 48-bit CMT on R-Car V3U > - const: renesas,rcar-gen3-cmt1 # 48-bit CMT on R-Car Gen3 and RZ/G2 > > + - items: > + - enum: > + - renesas,r8a779f0-cmt1 # 48-bit CMT on R-Car S4-8 > + - const: renesas,rcar-gen4-cmt1 # 48-bit CMT on R-Car Gen4 > + > reg: > maxItems: 1 >
On Wed, 13 Jul 2022 12:06:01 +0200, Wolfram Sang wrote: > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> > --- > .../devicetree/bindings/timer/renesas,cmt.yaml | 10 ++++++++++ > 1 file changed, 10 insertions(+) > Acked-by: Rob Herring <robh@kernel.org>
Hi Wolfram, On Wed, Jul 13, 2022 at 12:06 PM Wolfram Sang <wsa+renesas@sang-engineering.com> wrote: > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> Thanks for your patch! > --- a/Documentation/devicetree/bindings/timer/renesas,cmt.yaml > +++ b/Documentation/devicetree/bindings/timer/renesas,cmt.yaml > @@ -83,6 +83,11 @@ properties: > - renesas,r8a779a0-cmt0 # 32-bit CMT0 on R-Car V3U > - const: renesas,rcar-gen3-cmt0 # 32-bit CMT0 on R-Car Gen3 and RZ/G2 > > + - items: > + - enum: > + - renesas,r8a779f0-cmt0 # 32-bit CMT0 on R-Car S4-8 > + - const: renesas,rcar-gen4-cmt0 # 32-bit CMT0 on R-Car Gen4 > + > - items: > - enum: > - renesas,r8a774a1-cmt1 # 48-bit CMT on RZ/G2M > @@ -100,6 +105,11 @@ properties: > - renesas,r8a779a0-cmt1 # 48-bit CMT on R-Car V3U > - const: renesas,rcar-gen3-cmt1 # 48-bit CMT on R-Car Gen3 and RZ/G2 > > + - items: > + - enum: > + - renesas,r8a779f0-cmt1 # 48-bit CMT on R-Car S4-8 > + - const: renesas,rcar-gen4-cmt1 # 48-bit CMT on R-Car Gen4 > + > reg: > maxItems: 1 The above is correct, but you forgot to update the conditional sections specifying the number of interrupts. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
On 16/07/2022 00:35, Daniel Lezcano wrote: > On 13/07/2022 12:06, Wolfram Sang wrote: >> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> > > Krzysztof ? You got now Rob's. :) Best regards, Krzysztof
Hi Wolfram, On Tue, Jul 19, 2022 at 9:57 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote: > On Wed, Jul 13, 2022 at 12:06 PM Wolfram Sang > <wsa+renesas@sang-engineering.com> wrote: > > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> > > Thanks for your patch! > > > --- a/Documentation/devicetree/bindings/timer/renesas,cmt.yaml > > +++ b/Documentation/devicetree/bindings/timer/renesas,cmt.yaml > > @@ -83,6 +83,11 @@ properties: > > - renesas,r8a779a0-cmt0 # 32-bit CMT0 on R-Car V3U > > - const: renesas,rcar-gen3-cmt0 # 32-bit CMT0 on R-Car Gen3 and RZ/G2 > > > > + - items: > > + - enum: > > + - renesas,r8a779f0-cmt0 # 32-bit CMT0 on R-Car S4-8 > > + - const: renesas,rcar-gen4-cmt0 # 32-bit CMT0 on R-Car Gen4 > > + > > - items: > > - enum: > > - renesas,r8a774a1-cmt1 # 48-bit CMT on RZ/G2M > > @@ -100,6 +105,11 @@ properties: > > - renesas,r8a779a0-cmt1 # 48-bit CMT on R-Car V3U > > - const: renesas,rcar-gen3-cmt1 # 48-bit CMT on R-Car Gen3 and RZ/G2 > > > > + - items: > > + - enum: > > + - renesas,r8a779f0-cmt1 # 48-bit CMT on R-Car S4-8 > > + - const: renesas,rcar-gen4-cmt1 # 48-bit CMT on R-Car Gen4 > > + > > reg: > > maxItems: 1 > > The above is correct, but you forgot to update the conditional sections > specifying the number of interrupts. However, it would have been nice to adhere to the existing sort order in the file... I will prepare a patch for both issues... Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
diff --git a/Documentation/devicetree/bindings/timer/renesas,cmt.yaml b/Documentation/devicetree/bindings/timer/renesas,cmt.yaml index 53dd6d9f518f..7cc1ec4b4e38 100644 --- a/Documentation/devicetree/bindings/timer/renesas,cmt.yaml +++ b/Documentation/devicetree/bindings/timer/renesas,cmt.yaml @@ -83,6 +83,11 @@ properties: - renesas,r8a779a0-cmt0 # 32-bit CMT0 on R-Car V3U - const: renesas,rcar-gen3-cmt0 # 32-bit CMT0 on R-Car Gen3 and RZ/G2 + - items: + - enum: + - renesas,r8a779f0-cmt0 # 32-bit CMT0 on R-Car S4-8 + - const: renesas,rcar-gen4-cmt0 # 32-bit CMT0 on R-Car Gen4 + - items: - enum: - renesas,r8a774a1-cmt1 # 48-bit CMT on RZ/G2M @@ -100,6 +105,11 @@ properties: - renesas,r8a779a0-cmt1 # 48-bit CMT on R-Car V3U - const: renesas,rcar-gen3-cmt1 # 48-bit CMT on R-Car Gen3 and RZ/G2 + - items: + - enum: + - renesas,r8a779f0-cmt1 # 48-bit CMT on R-Car S4-8 + - const: renesas,rcar-gen4-cmt1 # 48-bit CMT on R-Car Gen4 + reg: maxItems: 1
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> --- .../devicetree/bindings/timer/renesas,cmt.yaml | 10 ++++++++++ 1 file changed, 10 insertions(+)