| Message ID | 20220717174454.46616-5-sam@ravnborg.org (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 1f020495458396766496ee067130f507a4d718e4 |
| Delegated to: | Kieran Bingham |
| Headers | show |
| Series | drm bridge updates | expand |
Hi Sam, Thank you for the patch. On Sun, Jul 17, 2022 at 07:44:46PM +0200, Sam Ravnborg wrote: > There are no users left of drm_bridge_chain_mode_fixup() and we > do not want to have this function available, so drop it. > > Signed-off-by: Sam Ravnborg <sam@ravnborg.org> > Reviewed-by: Maxime Ripard <mripard@kernel.org> > Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> > Cc: Maxime Ripard <mripard@kernel.org> > Cc: Thomas Zimmermann <tzimmermann@suse.de> > Cc: David Airlie <airlied@linux.ie> > Cc: Daniel Vetter <daniel@ffwll.ch> Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> > --- > drivers/gpu/drm/drm_bridge.c | 37 ------------------------------------ > include/drm/drm_bridge.h | 3 --- > 2 files changed, 40 deletions(-) > > diff --git a/drivers/gpu/drm/drm_bridge.c b/drivers/gpu/drm/drm_bridge.c > index bb7fc09267af..b6f56d8f3547 100644 > --- a/drivers/gpu/drm/drm_bridge.c > +++ b/drivers/gpu/drm/drm_bridge.c > @@ -430,43 +430,6 @@ void drm_bridge_detach(struct drm_bridge *bridge) > * needed, in order to gradually transition to the new model. > */ > > -/** > - * drm_bridge_chain_mode_fixup - fixup proposed mode for all bridges in the > - * encoder chain > - * @bridge: bridge control structure > - * @mode: desired mode to be set for the bridge > - * @adjusted_mode: updated mode that works for this bridge > - * > - * Calls &drm_bridge_funcs.mode_fixup for all the bridges in the > - * encoder chain, starting from the first bridge to the last. > - * > - * Note: the bridge passed should be the one closest to the encoder > - * > - * RETURNS: > - * true on success, false on failure > - */ > -bool drm_bridge_chain_mode_fixup(struct drm_bridge *bridge, > - const struct drm_display_mode *mode, > - struct drm_display_mode *adjusted_mode) > -{ > - struct drm_encoder *encoder; > - > - if (!bridge) > - return true; > - > - encoder = bridge->encoder; > - list_for_each_entry_from(bridge, &encoder->bridge_chain, chain_node) { > - if (!bridge->funcs->mode_fixup) > - continue; > - > - if (!bridge->funcs->mode_fixup(bridge, mode, adjusted_mode)) > - return false; > - } > - > - return true; > -} > -EXPORT_SYMBOL(drm_bridge_chain_mode_fixup); > - > /** > * drm_bridge_chain_mode_valid - validate the mode against all bridges in the > * encoder chain. > diff --git a/include/drm/drm_bridge.h b/include/drm/drm_bridge.h > index 1eca9c4c3346..7496f41535b1 100644 > --- a/include/drm/drm_bridge.h > +++ b/include/drm/drm_bridge.h > @@ -845,9 +845,6 @@ drm_bridge_chain_get_first_bridge(struct drm_encoder *encoder) > #define drm_for_each_bridge_in_chain(encoder, bridge) \ > list_for_each_entry(bridge, &(encoder)->bridge_chain, chain_node) > > -bool drm_bridge_chain_mode_fixup(struct drm_bridge *bridge, > - const struct drm_display_mode *mode, > - struct drm_display_mode *adjusted_mode); > enum drm_mode_status > drm_bridge_chain_mode_valid(struct drm_bridge *bridge, > const struct drm_display_info *info,
diff --git a/drivers/gpu/drm/drm_bridge.c b/drivers/gpu/drm/drm_bridge.c index bb7fc09267af..b6f56d8f3547 100644 --- a/drivers/gpu/drm/drm_bridge.c +++ b/drivers/gpu/drm/drm_bridge.c @@ -430,43 +430,6 @@ void drm_bridge_detach(struct drm_bridge *bridge) * needed, in order to gradually transition to the new model. */ -/** - * drm_bridge_chain_mode_fixup - fixup proposed mode for all bridges in the - * encoder chain - * @bridge: bridge control structure - * @mode: desired mode to be set for the bridge - * @adjusted_mode: updated mode that works for this bridge - * - * Calls &drm_bridge_funcs.mode_fixup for all the bridges in the - * encoder chain, starting from the first bridge to the last. - * - * Note: the bridge passed should be the one closest to the encoder - * - * RETURNS: - * true on success, false on failure - */ -bool drm_bridge_chain_mode_fixup(struct drm_bridge *bridge, - const struct drm_display_mode *mode, - struct drm_display_mode *adjusted_mode) -{ - struct drm_encoder *encoder; - - if (!bridge) - return true; - - encoder = bridge->encoder; - list_for_each_entry_from(bridge, &encoder->bridge_chain, chain_node) { - if (!bridge->funcs->mode_fixup) - continue; - - if (!bridge->funcs->mode_fixup(bridge, mode, adjusted_mode)) - return false; - } - - return true; -} -EXPORT_SYMBOL(drm_bridge_chain_mode_fixup); - /** * drm_bridge_chain_mode_valid - validate the mode against all bridges in the * encoder chain. diff --git a/include/drm/drm_bridge.h b/include/drm/drm_bridge.h index 1eca9c4c3346..7496f41535b1 100644 --- a/include/drm/drm_bridge.h +++ b/include/drm/drm_bridge.h @@ -845,9 +845,6 @@ drm_bridge_chain_get_first_bridge(struct drm_encoder *encoder) #define drm_for_each_bridge_in_chain(encoder, bridge) \ list_for_each_entry(bridge, &(encoder)->bridge_chain, chain_node) -bool drm_bridge_chain_mode_fixup(struct drm_bridge *bridge, - const struct drm_display_mode *mode, - struct drm_display_mode *adjusted_mode); enum drm_mode_status drm_bridge_chain_mode_valid(struct drm_bridge *bridge, const struct drm_display_info *info,