| Message ID | 20220815111708.22302-1-prabhakar.mahadev-lad.rj@bp.renesas.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
| Series | dt-bindings: soc: renesas: Move renesas.yaml from arm to soc | expand |
On Mon, Aug 15, 2022 at 12:17:08PM +0100, Lad Prabhakar wrote: > renesas.yaml lists out all the Renesas SoC's and the platforms/EVK's which > is either ARM32/ARM64. It would rather make sense if we move renesas.yaml > to the soc/renesas folder instead. This is in preparation for adding a new > SoC (RZ/Five) from Renesas which is based on RISC-V. Please post this as part of the above. bindings/soc/ is just a dumping ground for stuff that doesn't fit anywhere. We've mostly cleaned bindings/arm/ of that, so I don't really want to start that again. I would propose bindings/board/ instead if we move in this direction. > > While at it drop the old entry for renesas.yaml from MAINTAINERS file and > there is no need to update the new file path of renesas.yaml as we already > have an entry for Documentation/devicetree/bindings/soc/renesas/ folder. > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > --- > .../devicetree/bindings/{arm => soc/renesas}/renesas.yaml | 2 +- > MAINTAINERS | 1 - > 2 files changed, 1 insertion(+), 2 deletions(-) > rename Documentation/devicetree/bindings/{arm => soc/renesas}/renesas.yaml (99%) > > diff --git a/Documentation/devicetree/bindings/arm/renesas.yaml b/Documentation/devicetree/bindings/soc/renesas/renesas.yaml > similarity index 99% > rename from Documentation/devicetree/bindings/arm/renesas.yaml > rename to Documentation/devicetree/bindings/soc/renesas/renesas.yaml > index ff80152f092f..7aae35c5f6aa 100644 > --- a/Documentation/devicetree/bindings/arm/renesas.yaml > +++ b/Documentation/devicetree/bindings/soc/renesas/renesas.yaml > @@ -1,7 +1,7 @@ > # SPDX-License-Identifier: GPL-2.0 > %YAML 1.2 > --- > -$id: http://devicetree.org/schemas/arm/renesas.yaml# > +$id: http://devicetree.org/schemas/soc/renesas/renesas.yaml# > $schema: http://devicetree.org/meta-schemas/core.yaml# > > title: Renesas SH-Mobile, R-Mobile, and R-Car Platform Device Tree Bindings > diff --git a/MAINTAINERS b/MAINTAINERS > index e3058091899f..e42a7524e3f1 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -2658,7 +2658,6 @@ S: Supported > Q: http://patchwork.kernel.org/project/linux-renesas-soc/list/ > C: irc://irc.libera.chat/renesas-soc > T: git git://git.kernel.org/pub/scm/linux/kernel/git/geert/renesas-devel.git next > -F: Documentation/devicetree/bindings/arm/renesas.yaml > F: Documentation/devicetree/bindings/hwinfo/renesas,prr.yaml > F: Documentation/devicetree/bindings/soc/renesas/ > F: arch/arm64/boot/dts/renesas/ > -- > 2.17.1 > >
Hi Rob, On Tue, Aug 16, 2022 at 6:41 PM Rob Herring <robh@kernel.org> wrote: > > On Mon, Aug 15, 2022 at 12:17:08PM +0100, Lad Prabhakar wrote: > > renesas.yaml lists out all the Renesas SoC's and the platforms/EVK's which > > is either ARM32/ARM64. It would rather make sense if we move renesas.yaml > > to the soc/renesas folder instead. This is in preparation for adding a new > > SoC (RZ/Five) from Renesas which is based on RISC-V. > > Please post this as part of the above. > Sure, I just wanted to get some feedback on this so had it posted separately. > bindings/soc/ is just a dumping ground for stuff that doesn't fit > anywhere. We've mostly cleaned bindings/arm/ of that, so I don't really > want to start that again. I would propose bindings/board/ instead if we > move in this direction. > OK. So to clarify, how do we separate it further bindings/board/<based on SoC vendor> or bindings/board/<board manufacturer>? Cheers, Prabhakar
On Tue, Aug 16, 2022 at 12:40 PM Lad, Prabhakar <prabhakar.csengg@gmail.com> wrote: > > Hi Rob, > > On Tue, Aug 16, 2022 at 6:41 PM Rob Herring <robh@kernel.org> wrote: > > > > On Mon, Aug 15, 2022 at 12:17:08PM +0100, Lad Prabhakar wrote: > > > renesas.yaml lists out all the Renesas SoC's and the platforms/EVK's which > > > is either ARM32/ARM64. It would rather make sense if we move renesas.yaml > > > to the soc/renesas folder instead. This is in preparation for adding a new > > > SoC (RZ/Five) from Renesas which is based on RISC-V. > > > > Please post this as part of the above. > > > Sure, I just wanted to get some feedback on this so had it posted separately. > > > bindings/soc/ is just a dumping ground for stuff that doesn't fit > > anywhere. We've mostly cleaned bindings/arm/ of that, so I don't really > > want to start that again. I would propose bindings/board/ instead if we > > move in this direction. > > > OK. So to clarify, how do we separate it further bindings/board/<based > on SoC vendor> or bindings/board/<board manufacturer>? The latter doesn't work with how the schemas are structured. Rob
Hi Lad,
I love your patch! Perhaps something to improve:
[auto build test WARNING on geert-renesas-devel/next]
[also build test WARNING on linus/master v6.0-rc1 next-20220816]
[cannot apply to robh/for-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Lad-Prabhakar/dt-bindings-soc-renesas-Move-renesas-yaml-from-arm-to-soc/20220815-191822
base: https://git.kernel.org/pub/scm/linux/kernel/git/geert/renesas-devel.git next
reproduce: make htmldocs
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> Warning: MAINTAINERS references a file that doesn't exist: Documentation/devicetree/bindings/arm/renesas.yaml
Hi Rob, On Tue, Aug 16, 2022 at 7:41 PM Rob Herring <robh@kernel.org> wrote: > On Mon, Aug 15, 2022 at 12:17:08PM +0100, Lad Prabhakar wrote: > > renesas.yaml lists out all the Renesas SoC's and the platforms/EVK's which > > is either ARM32/ARM64. It would rather make sense if we move renesas.yaml > > to the soc/renesas folder instead. This is in preparation for adding a new > > SoC (RZ/Five) from Renesas which is based on RISC-V. > > Please post this as part of the above. > > bindings/soc/ is just a dumping ground for stuff that doesn't fit > anywhere. We've mostly cleaned bindings/arm/ of that, so I don't really Note that the target of this move is not .../bindings/soc/, but .../bindings/soc/renesas/, so it's a bit less of a dumping ground. Perhaps this is also a good opportunity to split renesas.yaml per family or product group (renesas,{rmobile,rcar-gen[1234],rza,rzg,rzn,...}.yaml? A fine-grained split may cause headaches with RZ/G2UL and RZ/Five sharing the same SoC Base, but a coarse-grained split keeping all RZ/G (after all RZ/Five is part of RZ/G) or even all RZ series together should work. > want to start that again. I would propose bindings/board/ instead if we > move in this direction. .../bindings/board has the issue with the same boards used with multiple pin-compatible SoCs, SiPs, and SoMs. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
On 17/08/2022 12:30, Geert Uytterhoeven wrote: > Hi Rob, > > On Tue, Aug 16, 2022 at 7:41 PM Rob Herring <robh@kernel.org> wrote: >> On Mon, Aug 15, 2022 at 12:17:08PM +0100, Lad Prabhakar wrote: >>> renesas.yaml lists out all the Renesas SoC's and the platforms/EVK's which >>> is either ARM32/ARM64. It would rather make sense if we move renesas.yaml >>> to the soc/renesas folder instead. This is in preparation for adding a new >>> SoC (RZ/Five) from Renesas which is based on RISC-V. >> >> Please post this as part of the above. >> >> bindings/soc/ is just a dumping ground for stuff that doesn't fit >> anywhere. We've mostly cleaned bindings/arm/ of that, so I don't really > > Note that the target of this move is not .../bindings/soc/, but bindings/soc/ means bindings/soc/vendor/, so it means bindings/soc/renesas/. There are no files in bindings/soc/ directly. > .../bindings/soc/renesas/, so it's a bit less of a dumping ground. Therefore it is still dumping ground. > Perhaps this is also a good opportunity to split renesas.yaml per > family or product group > (renesas,{rmobile,rcar-gen[1234],rza,rzg,rzn,...}.yaml? > A fine-grained split may cause headaches with RZ/G2UL and RZ/Five > sharing the same SoC Base, but a coarse-grained split keeping all RZ/G > (after all RZ/Five is part of RZ/G) or even all RZ series together should work. > >> want to start that again. I would propose bindings/board/ instead if we >> move in this direction. > > .../bindings/board has the issue with the same boards used with > multiple pin-compatible SoCs, SiPs, and SoMs. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/arm/renesas.yaml b/Documentation/devicetree/bindings/soc/renesas/renesas.yaml similarity index 99% rename from Documentation/devicetree/bindings/arm/renesas.yaml rename to Documentation/devicetree/bindings/soc/renesas/renesas.yaml index ff80152f092f..7aae35c5f6aa 100644 --- a/Documentation/devicetree/bindings/arm/renesas.yaml +++ b/Documentation/devicetree/bindings/soc/renesas/renesas.yaml @@ -1,7 +1,7 @@ # SPDX-License-Identifier: GPL-2.0 %YAML 1.2 --- -$id: http://devicetree.org/schemas/arm/renesas.yaml# +$id: http://devicetree.org/schemas/soc/renesas/renesas.yaml# $schema: http://devicetree.org/meta-schemas/core.yaml# title: Renesas SH-Mobile, R-Mobile, and R-Car Platform Device Tree Bindings diff --git a/MAINTAINERS b/MAINTAINERS index e3058091899f..e42a7524e3f1 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2658,7 +2658,6 @@ S: Supported Q: http://patchwork.kernel.org/project/linux-renesas-soc/list/ C: irc://irc.libera.chat/renesas-soc T: git git://git.kernel.org/pub/scm/linux/kernel/git/geert/renesas-devel.git next -F: Documentation/devicetree/bindings/arm/renesas.yaml F: Documentation/devicetree/bindings/hwinfo/renesas,prr.yaml F: Documentation/devicetree/bindings/soc/renesas/ F: arch/arm64/boot/dts/renesas/
renesas.yaml lists out all the Renesas SoC's and the platforms/EVK's which is either ARM32/ARM64. It would rather make sense if we move renesas.yaml to the soc/renesas folder instead. This is in preparation for adding a new SoC (RZ/Five) from Renesas which is based on RISC-V. While at it drop the old entry for renesas.yaml from MAINTAINERS file and there is no need to update the new file path of renesas.yaml as we already have an entry for Documentation/devicetree/bindings/soc/renesas/ folder. Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> --- .../devicetree/bindings/{arm => soc/renesas}/renesas.yaml | 2 +- MAINTAINERS | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) rename Documentation/devicetree/bindings/{arm => soc/renesas}/renesas.yaml (99%)