| Message ID | 20220824103515.54931-2-wsa+renesas@sang-engineering.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
| Series | r8a779f0: enable MSIOF | expand |
Hi Wolfram, On Wed, Aug 24, 2022 at 12:36 PM Wolfram Sang <wsa+renesas@sang-engineering.com> wrote: > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> Thanks for your patch! > --- > For V3U, we also used "msiX" as clock names, so I followed that. I > wonder, though, if we shouldn't keep using "msiofX" and rename V3U as > well? I think we should use "msiofX" for R-Car S4, as that's what's used in the documentation. I can fix that while applying. On R-Car V3U we used "msiX", to follow the documentation. > --- a/drivers/clk/renesas/r8a779f0-cpg-mssr.c > +++ b/drivers/clk/renesas/r8a779f0-cpg-mssr.c > @@ -131,6 +131,10 @@ static const struct mssr_mod_clk r8a779f0_mod_clks[] __initconst = { > DEF_MOD("i2c3", 521, R8A779F0_CLK_S0D6_PER), > DEF_MOD("i2c4", 522, R8A779F0_CLK_S0D6_PER), > DEF_MOD("i2c5", 523, R8A779F0_CLK_S0D6_PER), > + DEF_MOD("msi0", 618, R8A779F0_CLK_MSO), > + DEF_MOD("msi1", 619, R8A779F0_CLK_MSO), > + DEF_MOD("msi2", 620, R8A779F0_CLK_MSO), > + DEF_MOD("msi3", 621, R8A779F0_CLK_MSO), > DEF_MOD("pcie0", 624, R8A779F0_CLK_S0D2), > DEF_MOD("pcie1", 625, R8A779F0_CLK_S0D2), > DEF_MOD("scif0", 702, R8A779F0_CLK_S0D12_PER), Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> i.e. will queue in renesas-clk-for-v6.1, with the clock names fixed. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Hi Geert, > > For V3U, we also used "msiX" as clock names, so I followed that. I > > wonder, though, if we shouldn't keep using "msiofX" and rename V3U as > > well? > > I think we should use "msiofX" for R-Car S4, as that's what's used > in the documentation. I can fix that while applying. > On R-Car V3U we used "msiX", to follow the documentation. Ok. Thank you for the clarification and the assistance! Happy hacking, Wolfram
diff --git a/drivers/clk/renesas/r8a779f0-cpg-mssr.c b/drivers/clk/renesas/r8a779f0-cpg-mssr.c index 0faf13060ce8..adaed73097d7 100644 --- a/drivers/clk/renesas/r8a779f0-cpg-mssr.c +++ b/drivers/clk/renesas/r8a779f0-cpg-mssr.c @@ -131,6 +131,10 @@ static const struct mssr_mod_clk r8a779f0_mod_clks[] __initconst = { DEF_MOD("i2c3", 521, R8A779F0_CLK_S0D6_PER), DEF_MOD("i2c4", 522, R8A779F0_CLK_S0D6_PER), DEF_MOD("i2c5", 523, R8A779F0_CLK_S0D6_PER), + DEF_MOD("msi0", 618, R8A779F0_CLK_MSO), + DEF_MOD("msi1", 619, R8A779F0_CLK_MSO), + DEF_MOD("msi2", 620, R8A779F0_CLK_MSO), + DEF_MOD("msi3", 621, R8A779F0_CLK_MSO), DEF_MOD("pcie0", 624, R8A779F0_CLK_S0D2), DEF_MOD("pcie1", 625, R8A779F0_CLK_S0D2), DEF_MOD("scif0", 702, R8A779F0_CLK_S0D12_PER),
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> --- For V3U, we also used "msiX" as clock names, so I followed that. I wonder, though, if we shouldn't keep using "msiofX" and rename V3U as well? drivers/clk/renesas/r8a779f0-cpg-mssr.c | 4 ++++ 1 file changed, 4 insertions(+)