| Message ID | 20220829214256.5583-1-prabhakar.mahadev-lad.rj@bp.renesas.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
| Series | dt-bindings: mmc: renesas,sdhi: Add iommus property | expand |
Hi Prabhakar, Thanks for your patch! On Mon, Aug 29, 2022 at 11:43 PM Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> wrote: > The SDHI block on Renesas R-Car and RZ/G2 SoC's make use of IOMMU. blocks ... SoCs > This patch fixes the below dtbs_check warnings: > arch/arm64/boot/dts/renesas/r8a774e1-hihope-rzg2h-ex-idk-1110wr.dtb: mmc@ee100000: Unevaluated properties are not allowed ('iommus' was unexpected) > From schema: Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > --- a/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml > +++ b/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml > @@ -77,6 +77,9 @@ properties: > > clock-names: true > > + iommus: > + maxItems: 1 I would insert iommus below dma-names, as iommus belongs to dmas, logically (yes I know dmas is not used on R-Car Gen3 and RZ/G2, as SDHI has its own DMA controller). > + > dmas: > minItems: 4 > maxItems: 4 Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Hi Geert, Thank you for the review. On Tue, Aug 30, 2022 at 8:06 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote: > > Hi Prabhakar, > > Thanks for your patch! > > On Mon, Aug 29, 2022 at 11:43 PM Lad Prabhakar > <prabhakar.mahadev-lad.rj@bp.renesas.com> wrote: > > The SDHI block on Renesas R-Car and RZ/G2 SoC's make use of IOMMU. > > blocks ... SoCs > > > This patch fixes the below dtbs_check warnings: > > arch/arm64/boot/dts/renesas/r8a774e1-hihope-rzg2h-ex-idk-1110wr.dtb: mmc@ee100000: Unevaluated properties are not allowed ('iommus' was unexpected) > > From schema: Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml > > > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > > > --- a/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml > > +++ b/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml > > @@ -77,6 +77,9 @@ properties: > > > > clock-names: true > > > > + iommus: > > + maxItems: 1 > > I would insert iommus below dma-names, as iommus belongs to dmas, > logically (yes I know dmas is not used on R-Car Gen3 and RZ/G2, as > SDHI has its own DMA controller). > Ok, I will move it after dmas along with an updated commit message and send a v2. Cheers, Prabhakar
diff --git a/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml b/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml index 3ea94d842c33..be420a325ed3 100644 --- a/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml +++ b/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml @@ -77,6 +77,9 @@ properties: clock-names: true + iommus: + maxItems: 1 + dmas: minItems: 4 maxItems: 4
The SDHI block on Renesas R-Car and RZ/G2 SoC's make use of IOMMU. This patch fixes the below dtbs_check warnings: arch/arm64/boot/dts/renesas/r8a774e1-hihope-rzg2h-ex-idk-1110wr.dtb: mmc@ee100000: Unevaluated properties are not allowed ('iommus' was unexpected) From schema: Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> --- Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml | 3 +++ 1 file changed, 3 insertions(+)