[v4,68/68] clk: Forbid to register a mux without determine_rate

Commit Message

Maxime Ripard May 5, 2023, 11:26 a.m. UTC

The determine_rate hook allows to select the proper parent and its rate
for a given clock configuration. On another hand, set_parent is there to
change the parent of a mux.

Some clocks provide a set_parent hook but don't implement
determine_rate. In such a case, set_parent is pretty much useless since
the clock framework will always assume the current parent is to be used,
and we will thus never change it.

This situation can be solved in two ways:
  - either we don't need to change the parent, and we thus shouldn't
    implement set_parent;
  - or we don't want to change the parent, in this case we should set
    CLK_SET_RATE_NO_REPARENT;
  - or we're missing a determine_rate implementation.

The latter is probably just an oversight from the driver's author, and
we should thus raise their awareness about the fact that the current
state of the driver is confusing.

All the drivers in-tree have been converted by now, so let's prevent any
clock with set_parent but without determine_rate to register so that it
can't sneak in again in the future.

Cc: Abel Vesa <[e-mail]>
Cc: Alessandro Zummo <[e-mail]>
Cc: Alexandre Belloni <[e-mail]>
Cc: Alexandre Torgue <[e-mail]>
Cc: "Andreas Färber" <[e-mail]>
Cc: AngeloGioacchino Del Regno <[e-mail]>
Cc: Baolin Wang <[e-mail]>
Cc: Charles Keepax <[e-mail]>
Cc: Chen-Yu Tsai <[e-mail]>
Cc: Chen-Yu Tsai <[e-mail]>
Cc: Chunyan Zhang <[e-mail]>
Cc: Claudiu Beznea <[e-mail]>
Cc: Daniel Vetter <[e-mail]>
Cc: David Airlie <[e-mail]>
Cc: David Lechner <[e-mail]>
Cc: Dinh Nguyen <[e-mail]>
Cc: Fabio Estevam <[e-mail]>
Cc: Geert Uytterhoeven <[e-mail]>
Cc: Jaroslav Kysela <[e-mail]>
Cc: Jernej Skrabec <[e-mail]>
Cc: Jonathan Hunter <[e-mail]>
Cc: Kishon Vijay Abraham I <[e-mail]>
Cc: Liam Girdwood <[e-mail]>
Cc: Linus Walleij <[e-mail]>
Cc: Luca Ceresoli <[e-mail]>
Cc: Manivannan Sadhasivam <[e-mail]>
Cc: Mark Brown <[e-mail]>
Cc: Markus Schneider-Pargmann <[e-mail]>
Cc: Max Filippov <[e-mail]>
Cc: Maxime Coquelin <[e-mail]>
Cc: Mikko Perttunen <[e-mail]>
Cc: Miles Chen <[e-mail]>
Cc: Nicolas Ferre <[e-mail]>
Cc: Orson Zhai <[e-mail]>
Cc: Paul Cercueil <[e-mail]>
Cc: Peng Fan <[e-mail]>
Cc: Peter De Schrijver <[e-mail]>
Cc: Prashant Gaikwad <[e-mail]>
Cc: Richard Fitzgerald <[e-mail]>
Cc: Samuel Holland <[e-mail]>
Cc: Sascha Hauer <[e-mail]>
Cc: Sekhar Nori <[e-mail]>
Cc: Shawn Guo <[e-mail]>
Cc: Takashi Iwai <[e-mail]>
Cc: Thierry Reding <[e-mail]>
Cc: Ulf Hansson <[e-mail]>
Cc: Vinod Koul <[e-mail]>
Cc: [e-mail]
Cc: [e-mail]
Cc: [e-mail]
Cc: [e-mail]
Cc: [e-mail]
Cc: [e-mail]
Cc: [e-mail]
Cc: [e-mail]
Cc: [e-mail]
Cc: [e-mail]
Cc: NXP Linux Team <[e-mail]>
Cc: [e-mail]
Cc: Pengutronix Kernel Team <[e-mail]>
Reviewed-by: AngeloGioacchino Del Regno <[e-mail]>
Signed-off-by: Maxime Ripard <[e-mail]>
---
 drivers/clk/clk.c | 7 +++++++
 1 file changed, 7 insertions(+)

Patch

diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
index e4a1d5f9694c..c8f9227c29c9 100644
--- a/drivers/clk/clk.c
+++ b/drivers/clk/clk.c
@@ -3775,6 +3775,13 @@  static int __clk_core_init(struct clk_core *core)
 		goto out;
 	}
 
+	if (core->ops->set_parent && !core->ops->determine_rate) {
+		pr_err("%s: %s must implement .set_parent & .determine_rate\n",
+			__func__, core->name);
+		ret = -EINVAL;
+		goto out;
+	}
+
 	if (core->num_parents > 1 && !core->ops->get_parent) {
 		pr_err("%s: %s must implement .get_parent as it has multi parents\n",
 		       __func__, core->name);