| Message ID | 20221103205546.24836-4-wsa+renesas@sang-engineering.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
| Series | r8a779g0: add TMU support | expand |
On 03/11/2022 16:55, Wolfram Sang wrote: You need to describe the bug and its impact to justify Fixes tag (thus AUTOSEL backporting). > Fixes: 495e36c3a313 ("arm64: dts: renesas: white-hawk-cpu: Enable watchdog timer") But I doubt that there is a bug here. Style (like order of things) is not a bug. > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> > --- > arch/arm64/boot/dts/renesas/r8a779g0-white-hawk-cpu.dtsi | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/arch/arm64/boot/dts/renesas/r8a779g0-white-hawk-cpu.dtsi b/arch/arm64/boot/dts/renesas/r8a779g0-white-hawk-cpu.dtsi > index bb4dd08781ca..c10740aee9f6 100644 > --- a/arch/arm64/boot/dts/renesas/r8a779g0-white-hawk-cpu.dtsi > +++ b/arch/arm64/boot/dts/renesas/r8a779g0-white-hawk-cpu.dtsi > @@ -271,11 +271,11 @@ user@1200000 { > }; > }; > > -&scif_clk { > - clock-frequency = <24000000>; > -}; > - > &rwdt { > timeout-sec = <60>; > status = "okay"; > }; > + > +&scif_clk { > + clock-frequency = <24000000>; > +}; Best regards, Krzysztof
On Thu, Nov 3, 2022 at 9:55 PM Wolfram Sang <wsa+renesas@sang-engineering.com> wrote: > Fixes: 495e36c3a313 ("arm64: dts: renesas: white-hawk-cpu: Enable watchdog timer") > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> i.e. will queue in renesas-devel for v6.2. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
> But I doubt that there is a bug here. Style (like order of things) is > not a bug. Okay, I'll be more strict next time. Geert, could you kindly drop the Fixes tag or shall I resend?
Hi Wolfram, On Fri, Nov 4, 2022 at 12:15 PM Wolfram Sang <wsa+renesas@sang-engineering.com> wrote: > > But I doubt that there is a bug here. Style (like order of things) is > > not a bug. > > Okay, I'll be more strict next time. Geert, could you kindly drop the > Fixes tag or shall I resend? Consider it done, no need to resend. BTW, I guess the stable machinery will pick it up anyway... Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
diff --git a/arch/arm64/boot/dts/renesas/r8a779g0-white-hawk-cpu.dtsi b/arch/arm64/boot/dts/renesas/r8a779g0-white-hawk-cpu.dtsi index bb4dd08781ca..c10740aee9f6 100644 --- a/arch/arm64/boot/dts/renesas/r8a779g0-white-hawk-cpu.dtsi +++ b/arch/arm64/boot/dts/renesas/r8a779g0-white-hawk-cpu.dtsi @@ -271,11 +271,11 @@ user@1200000 { }; }; -&scif_clk { - clock-frequency = <24000000>; -}; - &rwdt { timeout-sec = <60>; status = "okay"; }; + +&scif_clk { + clock-frequency = <24000000>; +};
Fixes: 495e36c3a313 ("arm64: dts: renesas: white-hawk-cpu: Enable watchdog timer") Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> --- arch/arm64/boot/dts/renesas/r8a779g0-white-hawk-cpu.dtsi | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)