| Message ID | 20230118135259.19249-1-fabrizio.castro.jz@renesas.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 722f78466588a78826d2e604c7fe30054bc11d36 |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
| Series | arm64: dts: renesas: r9a09g011: Reword ethernet status | expand |
Hi Fabrizio, Thank you for the patch. On Wed, Jan 18, 2023 at 01:52:59PM +0000, Fabrizio Castro wrote: > Although of_fdt_device_is_available returns true when the DT > property "status" is assigned "ok" or "okay", and false for every > other value, it's become common practice to assign "disabled" > when we want of_fdt_device_is_available to return false. > For some reason, the status property of the ethernet node was > assigned "disable" when originally added to the kernel. Change > it to "disabled" for consistency. > > Signed-off-by: Fabrizio Castro <fabrizio.castro.jz@renesas.com> Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> > --- > arch/arm64/boot/dts/renesas/r9a09g011.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/renesas/r9a09g011.dtsi b/arch/arm64/boot/dts/renesas/r9a09g011.dtsi > index dd35a8ff72ee..b0c066c5e0ba 100644 > --- a/arch/arm64/boot/dts/renesas/r9a09g011.dtsi > +++ b/arch/arm64/boot/dts/renesas/r9a09g011.dtsi > @@ -165,7 +165,7 @@ avb: ethernet@a3300000 { > power-domains = <&cpg>; > #address-cells = <1>; > #size-cells = <0>; > - status = "disable"; > + status = "disabled"; > }; > > cpg: clock-controller@a3500000 {
On Wed, Jan 18, 2023 at 2:53 PM Fabrizio Castro <fabrizio.castro.jz@renesas.com> wrote: > Although of_fdt_device_is_available returns true when the DT > property "status" is assigned "ok" or "okay", and false for every > other value, it's become common practice to assign "disabled" > when we want of_fdt_device_is_available to return false. > For some reason, the status property of the ethernet node was > assigned "disable" when originally added to the kernel. Change > it to "disabled" for consistency. > > Signed-off-by: Fabrizio Castro <fabrizio.castro.jz@renesas.com> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> i.e. will queue in renesas-devel for v6.3. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
diff --git a/arch/arm64/boot/dts/renesas/r9a09g011.dtsi b/arch/arm64/boot/dts/renesas/r9a09g011.dtsi index dd35a8ff72ee..b0c066c5e0ba 100644 --- a/arch/arm64/boot/dts/renesas/r9a09g011.dtsi +++ b/arch/arm64/boot/dts/renesas/r9a09g011.dtsi @@ -165,7 +165,7 @@ avb: ethernet@a3300000 { power-domains = <&cpg>; #address-cells = <1>; #size-cells = <0>; - status = "disable"; + status = "disabled"; }; cpg: clock-controller@a3500000 {
Although of_fdt_device_is_available returns true when the DT property "status" is assigned "ok" or "okay", and false for every other value, it's become common practice to assign "disabled" when we want of_fdt_device_is_available to return false. For some reason, the status property of the ethernet node was assigned "disable" when originally added to the kernel. Change it to "disabled" for consistency. Signed-off-by: Fabrizio Castro <fabrizio.castro.jz@renesas.com> --- arch/arm64/boot/dts/renesas/r9a09g011.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)