Message ID | 20230310123510.675685-4-yoshihiro.shimoda.uh@renesas.com (mailing list archive) |
---|---|
State | Superseded |
Delegated to: | Geert Uytterhoeven |
Headers | show |
Series | PCI: rcar-gen4: Add R-Car Gen4 PCIe support | expand |
On Fri, Mar 10, 2023 at 09:35:00PM +0900, Yoshihiro Shimoda wrote: > Document bindings for Renesas R-Car Gen4 and R-Car S4-8 (R8A779F0) > PCIe host module. > > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> > Reviewed-by: Rob Herring <robh@kernel.org> Looks good. Reviewed-by: Serge Semin <fancer.lancer@gmail.com> > --- > .../bindings/pci/rcar-gen4-pci-host.yaml | 108 ++++++++++++++++++ > 1 file changed, 108 insertions(+) > create mode 100644 Documentation/devicetree/bindings/pci/rcar-gen4-pci-host.yaml > > diff --git a/Documentation/devicetree/bindings/pci/rcar-gen4-pci-host.yaml b/Documentation/devicetree/bindings/pci/rcar-gen4-pci-host.yaml > new file mode 100644 > index 000000000000..d838d7c50410 > --- /dev/null > +++ b/Documentation/devicetree/bindings/pci/rcar-gen4-pci-host.yaml > @@ -0,0 +1,108 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +# Copyright (C) 2022 Renesas Electronics Corp. > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/pci/rcar-gen4-pci-host.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Renesas R-Car Gen4 PCIe Host > + > +maintainers: > + - Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> > + > +allOf: > + - $ref: snps,dw-pcie.yaml# > + > +properties: > + compatible: > + items: > + - const: renesas,r8a779f0-pcie # R-Car S4-8 > + - const: renesas,rcar-gen4-pcie # R-Car Gen4 > + > + reg: > + maxItems: 5 > + > + reg-names: > + items: > + - const: dbi > + - const: atu > + - const: dma > + - const: app > + - const: config > + > + interrupts: > + maxItems: 4 > + > + interrupt-names: > + items: > + - const: msi > + - const: dma > + - const: sft_ce > + - const: app Just curious what is this IRQ used for? -Serge(y) > + > + clocks: > + maxItems: 1 > + > + power-domains: > + maxItems: 1 > + > + resets: > + maxItems: 1 > + > + max-link-speed: > + maximum: 4 > + > + num-lanes: > + maximum: 4 > + > +required: > + - compatible > + - reg > + - interrupts > + - clocks > + - power-domains > + > +unevaluatedProperties: false > + > +examples: > + - | > + #include <dt-bindings/clock/r8a779f0-cpg-mssr.h> > + #include <dt-bindings/interrupt-controller/arm-gic.h> > + #include <dt-bindings/power/r8a779f0-sysc.h> > + > + soc { > + #address-cells = <2>; > + #size-cells = <2>; > + > + pcie: pcie@e65d0000 { > + compatible = "renesas,r8a779f0-pcie", "renesas,rcar-gen4-pcie"; > + reg = <0 0xe65d0000 0 0x3000>, <0 0xe65d3000 0 0x2000>, > + <0 0xe65d5000 0 0x1200>, <0 0xe65d6200 0 0x0e00>, > + <0 0xfe000000 0 0x400000>; > + reg-names = "dbi", "atu", "dma", "app", "config"; > + #address-cells = <3>; > + #size-cells = <2>; > + bus-range = <0x00 0xff>; > + device_type = "pci"; > + ranges = <0x81000000 0 0x00000000 0 0xfe000000 0 0x00400000 > + 0x82000000 0 0x30000000 0 0x30000000 0 0x10000000>; > + dma-ranges = <0x42000000 0 0x40000000 0 0x40000000 0 0x80000000>; > + interrupts = <GIC_SPI 416 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 417 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 418 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 422 IRQ_TYPE_LEVEL_HIGH>; > + interrupt-names = "msi", "dma", "sft_ce", "app"; > + #interrupt-cells = <1>; > + interrupt-map-mask = <0 0 0 7>; > + interrupt-map = <0 0 0 1 &gic GIC_SPI 416 IRQ_TYPE_LEVEL_HIGH > + 0 0 0 2 &gic GIC_SPI 416 IRQ_TYPE_LEVEL_HIGH > + 0 0 0 3 &gic GIC_SPI 416 IRQ_TYPE_LEVEL_HIGH > + 0 0 0 4 &gic GIC_SPI 416 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&cpg CPG_MOD 624>; > + power-domains = <&sysc R8A779F0_PD_ALWAYS_ON>; > + resets = <&cpg 624>; > + num-lanes = <2>; > + snps,enable-cdm-check; > + max-link-speed = <2>; > + }; > + }; > -- > 2.25.1 > >
Hi Serge, > From: Serge Semin, Sent: Tuesday, March 21, 2023 8:36 PM > > On Fri, Mar 10, 2023 at 09:35:00PM +0900, Yoshihiro Shimoda wrote: > > Document bindings for Renesas R-Car Gen4 and R-Car S4-8 (R8A779F0) > > PCIe host module. > > > > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> > > Reviewed-by: Rob Herring <robh@kernel.org> > > Looks good. > Reviewed-by: Serge Semin <fancer.lancer@gmail.com> Thank you for your review! > > --- > > .../bindings/pci/rcar-gen4-pci-host.yaml | 108 ++++++++++++++++++ > > 1 file changed, 108 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/pci/rcar-gen4-pci-host.yaml > > > > diff --git a/Documentation/devicetree/bindings/pci/rcar-gen4-pci-host.yaml > b/Documentation/devicetree/bindings/pci/rcar-gen4-pci-host.yaml > > new file mode 100644 > > index 000000000000..d838d7c50410 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/pci/rcar-gen4-pci-host.yaml > > @@ -0,0 +1,108 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +# Copyright (C) 2022 Renesas Electronics Corp. > > +%YAML 1.2 > > +--- > > +$id: <snip> > > +$schema: <snip> > > + > > +title: Renesas R-Car Gen4 PCIe Host > > + > > +maintainers: > > + - Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> > > + > > +allOf: > > + - $ref: snps,dw-pcie.yaml# > > + > > +properties: > > + compatible: > > + items: > > + - const: renesas,r8a779f0-pcie # R-Car S4-8 > > + - const: renesas,rcar-gen4-pcie # R-Car Gen4 > > + > > + reg: > > + maxItems: 5 > > + > > + reg-names: > > + items: > > + - const: dbi > > + - const: atu > > + - const: dma > > + - const: app > > + - const: config > > + > > + interrupts: > > + maxItems: 4 > > + > > + interrupt-names: > > + items: > > + - const: msi > > + - const: dma > > + - const: sft_ce > > > + - const: app > > Just curious what is this IRQ used for? The pcie-rcar-gen4 drivers (host and endpoint) doesn't use this IRQ, But the hardware issues the IRQ when it receives a vendor defined message from remote device. Best regards, Yoshihiro Shimoda > -Serge(y) > > > + > > + clocks: > > + maxItems: 1 > > + > > + power-domains: > > + maxItems: 1 > > + > > + resets: > > + maxItems: 1 > > + > > + max-link-speed: > > + maximum: 4 > > + > > + num-lanes: > > + maximum: 4 > > + > > +required: > > + - compatible > > + - reg > > + - interrupts > > + - clocks > > + - power-domains > > + > > +unevaluatedProperties: false > > + > > +examples: > > + - | > > + #include <dt-bindings/clock/r8a779f0-cpg-mssr.h> > > + #include <dt-bindings/interrupt-controller/arm-gic.h> > > + #include <dt-bindings/power/r8a779f0-sysc.h> > > + > > + soc { > > + #address-cells = <2>; > > + #size-cells = <2>; > > + > > + pcie: pcie@e65d0000 { > > + compatible = "renesas,r8a779f0-pcie", "renesas,rcar-gen4-pcie"; > > + reg = <0 0xe65d0000 0 0x3000>, <0 0xe65d3000 0 0x2000>, > > + <0 0xe65d5000 0 0x1200>, <0 0xe65d6200 0 0x0e00>, > > + <0 0xfe000000 0 0x400000>; > > + reg-names = "dbi", "atu", "dma", "app", "config"; > > + #address-cells = <3>; > > + #size-cells = <2>; > > + bus-range = <0x00 0xff>; > > + device_type = "pci"; > > + ranges = <0x81000000 0 0x00000000 0 0xfe000000 0 0x00400000 > > + 0x82000000 0 0x30000000 0 0x30000000 0 0x10000000>; > > + dma-ranges = <0x42000000 0 0x40000000 0 0x40000000 0 0x80000000>; > > + interrupts = <GIC_SPI 416 IRQ_TYPE_LEVEL_HIGH>, > > + <GIC_SPI 417 IRQ_TYPE_LEVEL_HIGH>, > > + <GIC_SPI 418 IRQ_TYPE_LEVEL_HIGH>, > > + <GIC_SPI 422 IRQ_TYPE_LEVEL_HIGH>; > > + interrupt-names = "msi", "dma", "sft_ce", "app"; > > + #interrupt-cells = <1>; > > + interrupt-map-mask = <0 0 0 7>; > > + interrupt-map = <0 0 0 1 &gic GIC_SPI 416 IRQ_TYPE_LEVEL_HIGH > > + 0 0 0 2 &gic GIC_SPI 416 IRQ_TYPE_LEVEL_HIGH > > + 0 0 0 3 &gic GIC_SPI 416 IRQ_TYPE_LEVEL_HIGH > > + 0 0 0 4 &gic GIC_SPI 416 IRQ_TYPE_LEVEL_HIGH>; > > + clocks = <&cpg CPG_MOD 624>; > > + power-domains = <&sysc R8A779F0_PD_ALWAYS_ON>; > > + resets = <&cpg 624>; > > + num-lanes = <2>; > > + snps,enable-cdm-check; > > + max-link-speed = <2>; > > + }; > > + }; > > -- > > 2.25.1 > > > >
On Wed, Mar 22, 2023 at 12:35:19AM +0000, Yoshihiro Shimoda wrote: > Hi Serge, > > > From: Serge Semin, Sent: Tuesday, March 21, 2023 8:36 PM > > > > On Fri, Mar 10, 2023 at 09:35:00PM +0900, Yoshihiro Shimoda wrote: > > > Document bindings for Renesas R-Car Gen4 and R-Car S4-8 (R8A779F0) > > > PCIe host module. > > > > > > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> > > > Reviewed-by: Rob Herring <robh@kernel.org> > > > > Looks good. > > Reviewed-by: Serge Semin <fancer.lancer@gmail.com> > > Thank you for your review! > > > > --- > > > .../bindings/pci/rcar-gen4-pci-host.yaml | 108 ++++++++++++++++++ > > > 1 file changed, 108 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/pci/rcar-gen4-pci-host.yaml > > > > > > diff --git a/Documentation/devicetree/bindings/pci/rcar-gen4-pci-host.yaml > > b/Documentation/devicetree/bindings/pci/rcar-gen4-pci-host.yaml > > > new file mode 100644 > > > index 000000000000..d838d7c50410 > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/pci/rcar-gen4-pci-host.yaml > > > @@ -0,0 +1,108 @@ > > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > > +# Copyright (C) 2022 Renesas Electronics Corp. > > > +%YAML 1.2 > > > +--- > > > +$id: > <snip> > > > +$schema: > <snip> > > > + > > > +title: Renesas R-Car Gen4 PCIe Host > > > + > > > +maintainers: > > > + - Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> > > > + > > > +allOf: > > > + - $ref: snps,dw-pcie.yaml# > > > + > > > +properties: > > > + compatible: > > > + items: > > > + - const: renesas,r8a779f0-pcie # R-Car S4-8 > > > + - const: renesas,rcar-gen4-pcie # R-Car Gen4 > > > + > > > + reg: > > > + maxItems: 5 > > > + > > > + reg-names: > > > + items: > > > + - const: dbi > > > + - const: atu > > > + - const: dma > > > + - const: app > > > + - const: config > > > + > > > + interrupts: > > > + maxItems: 4 > > > + > > > + interrupt-names: > > > + items: > > > + - const: msi > > > + - const: dma > > > + - const: sft_ce > > > > > + - const: app > > > > Just curious what is this IRQ used for? > > The pcie-rcar-gen4 drivers (host and endpoint) doesn't use this IRQ, > But the hardware issues the IRQ when it receives a vendor defined message > from remote device. Ok. Thanks for clarification. -Serge(y) > > Best regards, > Yoshihiro Shimoda > > > -Serge(y) > > > > > + > > > + clocks: > > > + maxItems: 1 > > > + > > > + power-domains: > > > + maxItems: 1 > > > + > > > + resets: > > > + maxItems: 1 > > > + > > > + max-link-speed: > > > + maximum: 4 > > > + > > > + num-lanes: > > > + maximum: 4 > > > + > > > +required: > > > + - compatible > > > + - reg > > > + - interrupts > > > + - clocks > > > + - power-domains > > > + > > > +unevaluatedProperties: false > > > + > > > +examples: > > > + - | > > > + #include <dt-bindings/clock/r8a779f0-cpg-mssr.h> > > > + #include <dt-bindings/interrupt-controller/arm-gic.h> > > > + #include <dt-bindings/power/r8a779f0-sysc.h> > > > + > > > + soc { > > > + #address-cells = <2>; > > > + #size-cells = <2>; > > > + > > > + pcie: pcie@e65d0000 { > > > + compatible = "renesas,r8a779f0-pcie", "renesas,rcar-gen4-pcie"; > > > + reg = <0 0xe65d0000 0 0x3000>, <0 0xe65d3000 0 0x2000>, > > > + <0 0xe65d5000 0 0x1200>, <0 0xe65d6200 0 0x0e00>, > > > + <0 0xfe000000 0 0x400000>; > > > + reg-names = "dbi", "atu", "dma", "app", "config"; > > > + #address-cells = <3>; > > > + #size-cells = <2>; > > > + bus-range = <0x00 0xff>; > > > + device_type = "pci"; > > > + ranges = <0x81000000 0 0x00000000 0 0xfe000000 0 0x00400000 > > > + 0x82000000 0 0x30000000 0 0x30000000 0 0x10000000>; > > > + dma-ranges = <0x42000000 0 0x40000000 0 0x40000000 0 0x80000000>; > > > + interrupts = <GIC_SPI 416 IRQ_TYPE_LEVEL_HIGH>, > > > + <GIC_SPI 417 IRQ_TYPE_LEVEL_HIGH>, > > > + <GIC_SPI 418 IRQ_TYPE_LEVEL_HIGH>, > > > + <GIC_SPI 422 IRQ_TYPE_LEVEL_HIGH>; > > > + interrupt-names = "msi", "dma", "sft_ce", "app"; > > > + #interrupt-cells = <1>; > > > + interrupt-map-mask = <0 0 0 7>; > > > + interrupt-map = <0 0 0 1 &gic GIC_SPI 416 IRQ_TYPE_LEVEL_HIGH > > > + 0 0 0 2 &gic GIC_SPI 416 IRQ_TYPE_LEVEL_HIGH > > > + 0 0 0 3 &gic GIC_SPI 416 IRQ_TYPE_LEVEL_HIGH > > > + 0 0 0 4 &gic GIC_SPI 416 IRQ_TYPE_LEVEL_HIGH>; > > > + clocks = <&cpg CPG_MOD 624>; > > > + power-domains = <&sysc R8A779F0_PD_ALWAYS_ON>; > > > + resets = <&cpg 624>; > > > + num-lanes = <2>; > > > + snps,enable-cdm-check; > > > + max-link-speed = <2>; > > > + }; > > > + }; > > > -- > > > 2.25.1 > > > > > >
diff --git a/Documentation/devicetree/bindings/pci/rcar-gen4-pci-host.yaml b/Documentation/devicetree/bindings/pci/rcar-gen4-pci-host.yaml new file mode 100644 index 000000000000..d838d7c50410 --- /dev/null +++ b/Documentation/devicetree/bindings/pci/rcar-gen4-pci-host.yaml @@ -0,0 +1,108 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +# Copyright (C) 2022 Renesas Electronics Corp. +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/pci/rcar-gen4-pci-host.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Renesas R-Car Gen4 PCIe Host + +maintainers: + - Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> + +allOf: + - $ref: snps,dw-pcie.yaml# + +properties: + compatible: + items: + - const: renesas,r8a779f0-pcie # R-Car S4-8 + - const: renesas,rcar-gen4-pcie # R-Car Gen4 + + reg: + maxItems: 5 + + reg-names: + items: + - const: dbi + - const: atu + - const: dma + - const: app + - const: config + + interrupts: + maxItems: 4 + + interrupt-names: + items: + - const: msi + - const: dma + - const: sft_ce + - const: app + + clocks: + maxItems: 1 + + power-domains: + maxItems: 1 + + resets: + maxItems: 1 + + max-link-speed: + maximum: 4 + + num-lanes: + maximum: 4 + +required: + - compatible + - reg + - interrupts + - clocks + - power-domains + +unevaluatedProperties: false + +examples: + - | + #include <dt-bindings/clock/r8a779f0-cpg-mssr.h> + #include <dt-bindings/interrupt-controller/arm-gic.h> + #include <dt-bindings/power/r8a779f0-sysc.h> + + soc { + #address-cells = <2>; + #size-cells = <2>; + + pcie: pcie@e65d0000 { + compatible = "renesas,r8a779f0-pcie", "renesas,rcar-gen4-pcie"; + reg = <0 0xe65d0000 0 0x3000>, <0 0xe65d3000 0 0x2000>, + <0 0xe65d5000 0 0x1200>, <0 0xe65d6200 0 0x0e00>, + <0 0xfe000000 0 0x400000>; + reg-names = "dbi", "atu", "dma", "app", "config"; + #address-cells = <3>; + #size-cells = <2>; + bus-range = <0x00 0xff>; + device_type = "pci"; + ranges = <0x81000000 0 0x00000000 0 0xfe000000 0 0x00400000 + 0x82000000 0 0x30000000 0 0x30000000 0 0x10000000>; + dma-ranges = <0x42000000 0 0x40000000 0 0x40000000 0 0x80000000>; + interrupts = <GIC_SPI 416 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 417 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 418 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 422 IRQ_TYPE_LEVEL_HIGH>; + interrupt-names = "msi", "dma", "sft_ce", "app"; + #interrupt-cells = <1>; + interrupt-map-mask = <0 0 0 7>; + interrupt-map = <0 0 0 1 &gic GIC_SPI 416 IRQ_TYPE_LEVEL_HIGH + 0 0 0 2 &gic GIC_SPI 416 IRQ_TYPE_LEVEL_HIGH + 0 0 0 3 &gic GIC_SPI 416 IRQ_TYPE_LEVEL_HIGH + 0 0 0 4 &gic GIC_SPI 416 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&cpg CPG_MOD 624>; + power-domains = <&sysc R8A779F0_PD_ALWAYS_ON>; + resets = <&cpg 624>; + num-lanes = <2>; + snps,enable-cdm-check; + max-link-speed = <2>; + }; + };