| Message ID | 20230319155910.1706294-1-trix@redhat.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | a88b3c9eef83b605ef7016471a56db9129ae2529 |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
| Series | usb: gadget: udc: remove unused usbf_ep_dma_reg_clrset function | expand |
Hi Tom, On Sun, 19 Mar 2023 11:59:10 -0400 Tom Rix <trix@redhat.com> wrote: > clang with W=1 reports > drivers/usb/gadget/udc/renesas_usbf.c:548:20: error: unused function > 'usbf_ep_dma_reg_clrset' [-Werror,-Wunused-function] > static inline void usbf_ep_dma_reg_clrset(struct usbf_ep *ep, uint offset, > ^ > This function is not used, so remove it. > > Signed-off-by: Tom Rix <trix@redhat.com> > --- > drivers/usb/gadget/udc/renesas_usbf.c | 11 ----------- > 1 file changed, 11 deletions(-) > > diff --git a/drivers/usb/gadget/udc/renesas_usbf.c b/drivers/usb/gadget/udc/renesas_usbf.c > index cb23e62e8a87..84ac9fe4ce7f 100644 > --- a/drivers/usb/gadget/udc/renesas_usbf.c > +++ b/drivers/usb/gadget/udc/renesas_usbf.c > @@ -545,17 +545,6 @@ static inline void usbf_ep_dma_reg_bitclr(struct usbf_ep *ep, uint offset, > usbf_ep_dma_reg_writel(ep, offset, tmp); > } > > -static inline void usbf_ep_dma_reg_clrset(struct usbf_ep *ep, uint offset, > - u32 clr, u32 set) > -{ > - u32 tmp; > - > - tmp = usbf_ep_dma_reg_readl(ep, offset); > - tmp &= ~clr; > - tmp |= set; > - usbf_ep_dma_reg_writel(ep, offset, tmp); > -} > - > static void usbf_ep0_send_null(struct usbf_ep *ep0, bool is_data1) > { > u32 set; Yes, indeed. Acked-by: Herve Codina <herve.codina@bootlin.com> Thanks for the patch. Regards, Hervé
diff --git a/drivers/usb/gadget/udc/renesas_usbf.c b/drivers/usb/gadget/udc/renesas_usbf.c index cb23e62e8a87..84ac9fe4ce7f 100644 --- a/drivers/usb/gadget/udc/renesas_usbf.c +++ b/drivers/usb/gadget/udc/renesas_usbf.c @@ -545,17 +545,6 @@ static inline void usbf_ep_dma_reg_bitclr(struct usbf_ep *ep, uint offset, usbf_ep_dma_reg_writel(ep, offset, tmp); } -static inline void usbf_ep_dma_reg_clrset(struct usbf_ep *ep, uint offset, - u32 clr, u32 set) -{ - u32 tmp; - - tmp = usbf_ep_dma_reg_readl(ep, offset); - tmp &= ~clr; - tmp |= set; - usbf_ep_dma_reg_writel(ep, offset, tmp); -} - static void usbf_ep0_send_null(struct usbf_ep *ep0, bool is_data1) { u32 set;
clang with W=1 reports drivers/usb/gadget/udc/renesas_usbf.c:548:20: error: unused function 'usbf_ep_dma_reg_clrset' [-Werror,-Wunused-function] static inline void usbf_ep_dma_reg_clrset(struct usbf_ep *ep, uint offset, ^ This function is not used, so remove it. Signed-off-by: Tom Rix <trix@redhat.com> --- drivers/usb/gadget/udc/renesas_usbf.c | 11 ----------- 1 file changed, 11 deletions(-)