diff mbox series

[RFC,v2,3/3] arm64: dts: renesas: ulcb-kf: add node for GPS

Message ID 20230620103909.37582-4-wsa+renesas@sang-engineering.com (mailing list archive)
State Superseded
Delegated to: Geert Uytterhoeven
Headers show
Series gnss: updates to support the Renesas KingFisher board | expand

Commit Message

Wolfram Sang June 20, 2023, 10:39 a.m. UTC 
From: Wolfram Sang <wsa@kernel.org>

Add the node for the GPS receiver and its VCC supply.

Signed-off-by: Wolfram Sang <wsa@kernel.org>
---
Changes since RFC v1:
* rebased because of patches dropped and refactored
* added static vcc-suplly

@Geert: Not sure if we need so many fixed 3v3 regulators. Most of the
other ones more or less directly derive from d_3v3. Or do you prefer it
this way?

 arch/arm64/boot/dts/renesas/ulcb-kf.dtsi | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

Comments

Geert Uytterhoeven June 20, 2023, 11:24 a.m. UTC | #1 
Hi Wolfram,

On Tue, Jun 20, 2023 at 12:39 PM Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
> From: Wolfram Sang <wsa@kernel.org>
>
> Add the node for the GPS receiver and its VCC supply.
>
> Signed-off-by: Wolfram Sang <wsa@kernel.org>
> ---
> Changes since RFC v1:
> * rebased because of patches dropped and refactored
> * added static vcc-suplly

Thanks for the update!

> @Geert: Not sure if we need so many fixed 3v3 regulators. Most of the
> other ones more or less directly derive from d_3v3. Or do you prefer it
> this way?

Probably all of them should refer to &reg_3p3v instead...

> --- a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
> +++ b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
> @@ -39,6 +39,13 @@ accel_3v3: regulator-acc-3v3 {
>                 regulator-max-microvolt = <3300000>;
>         };
>
> +       d_3v3: regulator-d-3v3 {

... but if you want to keep it like this for now, please name
it appropriately (s/d/gnss/g).

> +               compatible = "regulator-fixed";
> +               regulator-name = "d-3v3";
> +               regulator-min-microvolt = <3300000>;
> +               regulator-max-microvolt = <3300000>;
> +       };
> +
>         hdmi_1v8: regulator-hdmi-1v8 {
>                 compatible = "regulator-fixed";
>                 regulator-name = "hdmi-1v8";

The rest LGTM.

Gr{oetje,eeting}s,

                        Geert


--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
Wolfram Sang June 20, 2023, 12:47 p.m. UTC | #2 
> > @Geert: Not sure if we need so many fixed 3v3 regulators. Most of the
> > other ones more or less directly derive from d_3v3. Or do you prefer it
> > this way?
> 
> Probably all of them should refer to &reg_3p3v instead...

Yes, I like this. I will refactor it into a seperate series.
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
index e62f5359f64b..dd1ffc31c874 100644
--- a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
+++ b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
@@ -39,6 +39,13 @@  accel_3v3: regulator-acc-3v3 {
 		regulator-max-microvolt = <3300000>;
 	};
 
+	d_3v3: regulator-d-3v3 {
+		compatible = "regulator-fixed";
+		regulator-name = "d-3v3";
+		regulator-min-microvolt = <3300000>;
+		regulator-max-microvolt = <3300000>;
+	};
+
 	hdmi_1v8: regulator-hdmi-1v8 {
 		compatible = "regulator-fixed";
 		regulator-name = "hdmi-1v8";
@@ -434,6 +441,13 @@  &scif1 {
 	pinctrl-names = "default";
 
 	status = "okay";
+
+	gnss {
+		compatible = "u-blox,neo-m8";
+		reset-gpios = <&gpio_exp_75 6 GPIO_ACTIVE_LOW>;
+		vcc-supply = <&d_3v3>;
+		current-speed = <9600>;
+	};
 };
 
 &sdhi3 {