| Message ID | 20230703132343.353878-1-biju.das.jz@bp.renesas.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
| Series | mfd: Add module build support for RZ/G2L MTU3a | expand |
On Mon, Jul 3, 2023 at 3:23 PM Biju Das <biju.das.jz@bp.renesas.com> wrote: > Modified Kconfig to enable module build support for RZ/G2L MTU3a driver. > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> As drivers/mfd/rz-mtu3.c already has the needed MODULE_*() lines: drivers/mfd/rz-mtu3.c:MODULE_DEVICE_TABLE(of, rz_mtu3_of_match); drivers/mfd/rz-mtu3.c:MODULE_AUTHOR("Biju Das <biju.das.jz@bp.renesas.com>"); drivers/mfd/rz-mtu3.c:MODULE_DESCRIPTION("Renesas RZ/G2L MTU3a Core Driver"); drivers/mfd/rz-mtu3.c:MODULE_LICENSE("GPL"); Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert
Hi Geert, Thanks for the feedback. > -----Original Message----- > From: Geert Uytterhoeven <geert@linux-m68k.org> > Sent: Wednesday, July 5, 2023 12:44 PM > To: Biju Das <biju.das.jz@bp.renesas.com> > Cc: Lee Jones <lee@kernel.org>; Prabhakar Mahadev Lad > <prabhakar.mahadev-lad.rj@bp.renesas.com>; linux-renesas- > soc@vger.kernel.org > Subject: Re: [PATCH] mfd: Add module build support for RZ/G2L MTU3a > > On Mon, Jul 3, 2023 at 3:23 PM Biju Das <biju.das.jz@bp.renesas.com> > wrote: > > Modified Kconfig to enable module build support for RZ/G2L MTU3a > driver. > > > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> > > As drivers/mfd/rz-mtu3.c already has the needed MODULE_*() lines: > > drivers/mfd/rz-mtu3.c:MODULE_DEVICE_TABLE(of, rz_mtu3_of_match); > drivers/mfd/rz-mtu3.c:MODULE_AUTHOR("Biju Das > <biju.das.jz@bp.renesas.com>"); drivers/mfd/rz- > mtu3.c:MODULE_DESCRIPTION("Renesas RZ/G2L MTU3a Core Driver"); > drivers/mfd/rz-mtu3.c:MODULE_LICENSE("GPL"); You mean, I missed adding linux/module.h as I got compilation error While backporting to 5.10 cip kernel? Cheers, Biju > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux- > m68k.org > > In personal conversations with technical people, I call myself a hacker. > But when I'm talking to journalists I just say "programmer" or something > like that. > -- Linus Torvalds
Hi Biju, On Mon, Jul 10, 2023 at 7:04 PM Biju Das <biju.das.jz@bp.renesas.com> wrote: > > -----Original Message----- > > From: Geert Uytterhoeven <geert@linux-m68k.org> > > Sent: Wednesday, July 5, 2023 12:44 PM > > To: Biju Das <biju.das.jz@bp.renesas.com> > > Cc: Lee Jones <lee@kernel.org>; Prabhakar Mahadev Lad > > <prabhakar.mahadev-lad.rj@bp.renesas.com>; linux-renesas- > > soc@vger.kernel.org > > Subject: Re: [PATCH] mfd: Add module build support for RZ/G2L MTU3a > > > > On Mon, Jul 3, 2023 at 3:23 PM Biju Das <biju.das.jz@bp.renesas.com> > > wrote: > > > Modified Kconfig to enable module build support for RZ/G2L MTU3a > > driver. > > > > > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> > > > > As drivers/mfd/rz-mtu3.c already has the needed MODULE_*() lines: > > > > drivers/mfd/rz-mtu3.c:MODULE_DEVICE_TABLE(of, rz_mtu3_of_match); > > drivers/mfd/rz-mtu3.c:MODULE_AUTHOR("Biju Das > > <biju.das.jz@bp.renesas.com>"); drivers/mfd/rz- > > mtu3.c:MODULE_DESCRIPTION("Renesas RZ/G2L MTU3a Core Driver"); > > drivers/mfd/rz-mtu3.c:MODULE_LICENSE("GPL"); > > You mean, I missed adding linux/module.h as I got compilation error > While backporting to 5.10 cip kernel? No, I didn't mean that. I just clarified that the MODULE_*() machinery was already there, so it's fine to make the driver modular. I hadn't noticed the include was forgotten. Doh... Gr{oetje,eeting}s, Geert
Hi Geert, Thanks for clarification. > Subject: Re: [PATCH] mfd: Add module build support for RZ/G2L MTU3a > > Hi Biju, > > On Mon, Jul 10, 2023 at 7:04 PM Biju Das <biju.das.jz@bp.renesas.com> > wrote: > > > -----Original Message----- > > > From: Geert Uytterhoeven <geert@linux-m68k.org> > > > Sent: Wednesday, July 5, 2023 12:44 PM > > > To: Biju Das <biju.das.jz@bp.renesas.com> > > > Cc: Lee Jones <lee@kernel.org>; Prabhakar Mahadev Lad > > > <prabhakar.mahadev-lad.rj@bp.renesas.com>; linux-renesas- > > > soc@vger.kernel.org > > > Subject: Re: [PATCH] mfd: Add module build support for RZ/G2L MTU3a > > > > > > On Mon, Jul 3, 2023 at 3:23 PM Biju Das <biju.das.jz@bp.renesas.com> > > > wrote: > > > > Modified Kconfig to enable module build support for RZ/G2L MTU3a > > > driver. > > > > > > > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> > > > > > > As drivers/mfd/rz-mtu3.c already has the needed MODULE_*() lines: > > > > > > drivers/mfd/rz-mtu3.c:MODULE_DEVICE_TABLE(of, rz_mtu3_of_match); > > > drivers/mfd/rz-mtu3.c:MODULE_AUTHOR("Biju Das > > > <biju.das.jz@bp.renesas.com>"); drivers/mfd/rz- > > > mtu3.c:MODULE_DESCRIPTION("Renesas RZ/G2L MTU3a Core Driver"); > > > drivers/mfd/rz-mtu3.c:MODULE_LICENSE("GPL"); > > > > You mean, I missed adding linux/module.h as I got compilation error > > While backporting to 5.10 cip kernel? > > No, I didn't mean that. I just clarified that the MODULE_*() machinery > was already there, so it's fine to make the driver modular. > I hadn't noticed the include was forgotten. Doh... OK, will send v2 with missing include file. Cheers, Biju
diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig index 6f5b259a6d6a..fb02a2913d46 100644 --- a/drivers/mfd/Kconfig +++ b/drivers/mfd/Kconfig @@ -1348,7 +1348,7 @@ config MFD_SC27XX_PMIC and it also adds the irq_chip parts for handling the PMIC chip events. config RZ_MTU3 - bool "Renesas RZ/G2L MTU3a core driver" + tristate "Renesas RZ/G2L MTU3a core driver" depends on (ARCH_RZG2L && OF) || COMPILE_TEST help Select this option to enable Renesas RZ/G2L MTU3a core driver for
Modified Kconfig to enable module build support for RZ/G2L MTU3a driver. Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> --- drivers/mfd/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)