| Message ID | 20230705114206.3585188-2-yoshihiro.shimoda.uh@renesas.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
| Series | PCI: rcar-gen4: Add R-Car Gen4 PCIe support | expand |
On Wed, Jul 05, 2023 at 08:41:47PM +0900, Yoshihiro Shimoda wrote: > Add "Implicit Message Routing" and "INTx Mechanism Messages" macros > to send a message by a PCIe driver. Adding to the patch log why they are needed would shed some light to the patch context for the reviewers unfamiliar with the series. Normally the submitters provide the context of the preparation patches to simplify the review. Adding a reference to the respective part of the PCIe specification would be also appropriate here. Other than that no objection from my side: Reviewed-by: Serge Semin <fancer.lancer@gmail.com> -Serge(y) > > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> > --- > drivers/pci/pci.h | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > > diff --git a/drivers/pci/pci.h b/drivers/pci/pci.h > index a4c397434057..45673cc9c724 100644 > --- a/drivers/pci/pci.h > +++ b/drivers/pci/pci.h > @@ -13,6 +13,24 @@ > > #define PCIE_LINK_RETRAIN_TIMEOUT_MS 1000 > > +/* Implicit Message Routing (r[2:0]) */ > +#define PCI_MSG_TYPE_R_ROUTING_RC 0 > +#define PCI_MSG_TYPE_R_ROUTING_ADDR 1 > +#define PCI_MSG_TYPE_R_ROUTING_ID 2 > +#define PCI_MSG_TYPE_R_ROUTING_BC 3 > +#define PCI_MSG_TYPE_R_ROUTING_LOCAL 4 > +#define PCI_MSG_TYPE_R_ROUTING_GATHER 5 > + > +/* INTx Mechanism Messages */ > +#define PCI_MSG_CODE_ASSERT_INTA 0x20 > +#define PCI_MSG_CODE_ASSERT_INTB 0x21 > +#define PCI_MSG_CODE_ASSERT_INTC 0x22 > +#define PCI_MSG_CODE_ASSERT_INTD 0x23 > +#define PCI_MSG_CODE_DEASSERT_INTA 0x24 > +#define PCI_MSG_CODE_DEASSERT_INTB 0x25 > +#define PCI_MSG_CODE_DEASSERT_INTC 0x26 > +#define PCI_MSG_CODE_DEASSERT_INTD 0x27 > + > extern const unsigned char pcie_link_speed[]; > extern bool pci_early_dump; > > -- > 2.25.1 >
diff --git a/drivers/pci/pci.h b/drivers/pci/pci.h index a4c397434057..45673cc9c724 100644 --- a/drivers/pci/pci.h +++ b/drivers/pci/pci.h @@ -13,6 +13,24 @@ #define PCIE_LINK_RETRAIN_TIMEOUT_MS 1000 +/* Implicit Message Routing (r[2:0]) */ +#define PCI_MSG_TYPE_R_ROUTING_RC 0 +#define PCI_MSG_TYPE_R_ROUTING_ADDR 1 +#define PCI_MSG_TYPE_R_ROUTING_ID 2 +#define PCI_MSG_TYPE_R_ROUTING_BC 3 +#define PCI_MSG_TYPE_R_ROUTING_LOCAL 4 +#define PCI_MSG_TYPE_R_ROUTING_GATHER 5 + +/* INTx Mechanism Messages */ +#define PCI_MSG_CODE_ASSERT_INTA 0x20 +#define PCI_MSG_CODE_ASSERT_INTB 0x21 +#define PCI_MSG_CODE_ASSERT_INTC 0x22 +#define PCI_MSG_CODE_ASSERT_INTD 0x23 +#define PCI_MSG_CODE_DEASSERT_INTA 0x24 +#define PCI_MSG_CODE_DEASSERT_INTB 0x25 +#define PCI_MSG_CODE_DEASSERT_INTC 0x26 +#define PCI_MSG_CODE_DEASSERT_INTD 0x27 + extern const unsigned char pcie_link_speed[]; extern bool pci_early_dump;
Add "Implicit Message Routing" and "INTx Mechanism Messages" macros to send a message by a PCIe driver. Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> --- drivers/pci/pci.h | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+)