diff mbox series

[2/6] dt-bindings: timer: renesas,rz-mtu3: Fix overflow/underflow interrupt names

Message ID 20230720131016.331793-3-biju.das.jz@bp.renesas.com (mailing list archive)
State Superseded
Delegated to: Geert Uytterhoeven
Headers show
Series Add RZ/G2UL MTU3a support | expand

Commit Message

Biju Das July 20, 2023, 1:10 p.m. UTC
As per R01UH0914EJ0130 Rev.1.30 HW manual the MTU3 overflow/underflow
interrupt names starts with 'tci' instead of 'tgi'.

Fix this documentation issue by replacing below overflow/underflow
interrupt names:
 - tgiv0->tciv0
 - tgiv1->tciv1
 - tgiu1->tciu1
 - tgiv2->tciv2
 - tgiu2->tciu2
 - tgiv3->tciv3
 - tgiv4->tciv4
 - tgiv6->tciv6
 - tgiv7->tciv7
 - tgiv8->tciv8
 - tgiu8->tciu8

Fixes: 0a9d6b54297e ("dt-bindings: timer: Document RZ/G2L MTU3a bindings")
Cc: stable@kernel.org
Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
---
 .../bindings/timer/renesas,rz-mtu3.yaml       | 38 +++++++++----------
 1 file changed, 19 insertions(+), 19 deletions(-)

Comments

Conor Dooley July 20, 2023, 5:19 p.m. UTC | #1
On Thu, Jul 20, 2023 at 02:10:12PM +0100, Biju Das wrote:
> As per R01UH0914EJ0130 Rev.1.30 HW manual the MTU3 overflow/underflow
> interrupt names starts with 'tci' instead of 'tgi'.
> 
> Fix this documentation issue by replacing below overflow/underflow
> interrupt names:
>  - tgiv0->tciv0
>  - tgiv1->tciv1
>  - tgiu1->tciu1
>  - tgiv2->tciv2
>  - tgiu2->tciu2
>  - tgiv3->tciv3
>  - tgiv4->tciv4
>  - tgiv6->tciv6
>  - tgiv7->tciv7
>  - tgiv8->tciv8
>  - tgiu8->tciu8
> 
> Fixes: 0a9d6b54297e ("dt-bindings: timer: Document RZ/G2L MTU3a bindings")
> Cc: stable@kernel.org
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>

I assume this means that nothing is actually using these interrupt
names?
Biju Das July 20, 2023, 5:52 p.m. UTC | #2
Hi Conor Dooley,

Thanks for the feedback.

> -----Original Message-----
> From: Conor Dooley <conor@kernel.org>
> Sent: Thursday, July 20, 2023 6:19 PM
> To: Biju Das <biju.das.jz@bp.renesas.com>
> Cc: Rob Herring <robh+dt@kernel.org>; Krzysztof Kozlowski
> <krzysztof.kozlowski+dt@linaro.org>; Conor Dooley <conor+dt@kernel.org>;
> Daniel Lezcano <daniel.lezcano@linaro.org>; Thomas Gleixner
> <tglx@linutronix.de>; Geert Uytterhoeven <geert+renesas@glider.be>;
> Magnus Damm <magnus.damm@gmail.com>; Lee Jones <lee@kernel.org>; linux-
> iio@vger.kernel.org; linux-renesas-soc@vger.kernel.org;
> devicetree@vger.kernel.org; Fabrizio Castro
> <fabrizio.castro.jz@renesas.com>; Prabhakar Mahadev Lad
> <prabhakar.mahadev-lad.rj@bp.renesas.com>; stable@kernel.org
> Subject: Re: [PATCH 2/6] dt-bindings: timer: renesas,rz-mtu3: Fix
> overflow/underflow interrupt names
> 
> On Thu, Jul 20, 2023 at 02:10:12PM +0100, Biju Das wrote:
> > As per R01UH0914EJ0130 Rev.1.30 HW manual the MTU3 overflow/underflow
> > interrupt names starts with 'tci' instead of 'tgi'.
> >
> > Fix this documentation issue by replacing below overflow/underflow
> > interrupt names:
> >  - tgiv0->tciv0
> >  - tgiv1->tciv1
> >  - tgiu1->tciu1
> >  - tgiv2->tciv2
> >  - tgiu2->tciu2
> >  - tgiv3->tciv3
> >  - tgiv4->tciv4
> >  - tgiv6->tciv6
> >  - tgiv7->tciv7
> >  - tgiv8->tciv8
> >  - tgiu8->tciu8
> >
> > Fixes: 0a9d6b54297e ("dt-bindings: timer: Document RZ/G2L MTU3a
> > bindings")
> > Cc: stable@kernel.org
> > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> 
> I assume this means that nothing is actually using these interrupt
> names?

Yes, That is correct. Corresponding driver doesn't have interrupt support.

Cheers,
Biju
Conor Dooley July 20, 2023, 5:59 p.m. UTC | #3
On Thu, Jul 20, 2023 at 05:52:00PM +0000, Biju Das wrote:
> > -----Original Message-----
> > From: Conor Dooley <conor@kernel.org>

> > Sent: Thursday, July 20, 2023 6:19 PM
> > To: Biju Das <biju.das.jz@bp.renesas.com>
> > Cc: Rob Herring <robh+dt@kernel.org>; Krzysztof Kozlowski
> > <krzysztof.kozlowski+dt@linaro.org>; Conor Dooley <conor+dt@kernel.org>;
> > Daniel Lezcano <daniel.lezcano@linaro.org>; Thomas Gleixner
> > <tglx@linutronix.de>; Geert Uytterhoeven <geert+renesas@glider.be>;
> > Magnus Damm <magnus.damm@gmail.com>; Lee Jones <lee@kernel.org>; linux-
> > iio@vger.kernel.org; linux-renesas-soc@vger.kernel.org;
> > devicetree@vger.kernel.org; Fabrizio Castro
> > <fabrizio.castro.jz@renesas.com>; Prabhakar Mahadev Lad
> > <prabhakar.mahadev-lad.rj@bp.renesas.com>; stable@kernel.org

btw, please trim this stuff :)

> > Subject: Re: [PATCH 2/6] dt-bindings: timer: renesas,rz-mtu3: Fix
> > overflow/underflow interrupt names
> > 
> > On Thu, Jul 20, 2023 at 02:10:12PM +0100, Biju Das wrote:
> > > As per R01UH0914EJ0130 Rev.1.30 HW manual the MTU3 overflow/underflow
> > > interrupt names starts with 'tci' instead of 'tgi'.
> > >
> > > Fix this documentation issue by replacing below overflow/underflow
> > > interrupt names:
> > >  - tgiv0->tciv0
> > >  - tgiv1->tciv1
> > >  - tgiu1->tciu1
> > >  - tgiv2->tciv2
> > >  - tgiu2->tciu2
> > >  - tgiv3->tciv3
> > >  - tgiv4->tciv4
> > >  - tgiv6->tciv6
> > >  - tgiv7->tciv7
> > >  - tgiv8->tciv8
> > >  - tgiu8->tciu8
> > >
> > > Fixes: 0a9d6b54297e ("dt-bindings: timer: Document RZ/G2L MTU3a
> > > bindings")
> > > Cc: stable@kernel.org
> > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> > 
> > I assume this means that nothing is actually using these interrupt
> > names?
> 
> Yes, That is correct. Corresponding driver doesn't have interrupt support.

Okay, if it is not being used anywhere:
Acked-by: Conor Dooley <conor.dooley@microchip.com>

Thanks,
Conor.
Biju Das July 24, 2023, 8:04 a.m. UTC | #4
Hi Conor Dooley, 

> Subject: Re: [PATCH 2/6] dt-bindings: timer: renesas,rz-mtu3: Fix
> overflow/underflow interrupt names
> 
> On Thu, Jul 20, 2023 at 05:52:00PM +0000, Biju Das wrote:
> > > -----Original Message-----
> > > From: Conor Dooley <conor@kernel.org>
> 
> > > Sent: Thursday, July 20, 2023 6:19 PM
> > > To: Biju Das <biju.das.jz@bp.renesas.com>
> > > Cc: Rob Herring <robh+dt@kernel.org>; Krzysztof Kozlowski
> > > <krzysztof.kozlowski+dt@linaro.org>; Conor Dooley
> > > <conor+dt@kernel.org>; Daniel Lezcano <daniel.lezcano@linaro.org>;
> > > Thomas Gleixner <tglx@linutronix.de>; Geert Uytterhoeven
> > > <geert+renesas@glider.be>; Magnus Damm <magnus.damm@gmail.com>; Lee
> > > Jones <lee@kernel.org>; linux- iio@vger.kernel.org;
> > > linux-renesas-soc@vger.kernel.org;
> > > devicetree@vger.kernel.org; Fabrizio Castro
> > > <fabrizio.castro.jz@renesas.com>; Prabhakar Mahadev Lad
> > > <prabhakar.mahadev-lad.rj@bp.renesas.com>; stable@kernel.org
> 
> btw, please trim this stuff :)

You mean trim the recipient list?

Cheers,
Biju

> 
> > > Subject: Re: [PATCH 2/6] dt-bindings: timer: renesas,rz-mtu3: Fix
> > > overflow/underflow interrupt names
> > >
> > > On Thu, Jul 20, 2023 at 02:10:12PM +0100, Biju Das wrote:
> > > > As per R01UH0914EJ0130 Rev.1.30 HW manual the MTU3
> > > > overflow/underflow interrupt names starts with 'tci' instead of
> 'tgi'.
> > > >
> > > > Fix this documentation issue by replacing below overflow/underflow
> > > > interrupt names:
> > > >  - tgiv0->tciv0
> > > >  - tgiv1->tciv1
> > > >  - tgiu1->tciu1
> > > >  - tgiv2->tciv2
> > > >  - tgiu2->tciu2
> > > >  - tgiv3->tciv3
> > > >  - tgiv4->tciv4
> > > >  - tgiv6->tciv6
> > > >  - tgiv7->tciv7
> > > >  - tgiv8->tciv8
> > > >  - tgiu8->tciu8
> > > >
> > > > Fixes: 0a9d6b54297e ("dt-bindings: timer: Document RZ/G2L MTU3a
> > > > bindings")
> > > > Cc: stable@kernel.org
> > > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> > >
> > > I assume this means that nothing is actually using these interrupt
> > > names?
> >
> > Yes, That is correct. Corresponding driver doesn't have interrupt
> support.
> 
> Okay, if it is not being used anywhere:
> Acked-by: Conor Dooley <conor.dooley@microchip.com>
> 
> Thanks,
> Conor.
Conor Dooley July 24, 2023, 8:15 a.m. UTC | #5
On Mon, Jul 24, 2023 at 08:04:08AM +0000, Biju Das wrote:
> Hi Conor Dooley, 
> 
> > Subject: Re: [PATCH 2/6] dt-bindings: timer: renesas,rz-mtu3: Fix
> > overflow/underflow interrupt names
> > 
> > On Thu, Jul 20, 2023 at 05:52:00PM +0000, Biju Das wrote:
> > > > -----Original Message-----
> > > > From: Conor Dooley <conor@kernel.org>
> > 
> > > > Sent: Thursday, July 20, 2023 6:19 PM
> > > > To: Biju Das <biju.das.jz@bp.renesas.com>
> > > > Cc: Rob Herring <robh+dt@kernel.org>; Krzysztof Kozlowski
> > > > <krzysztof.kozlowski+dt@linaro.org>; Conor Dooley
> > > > <conor+dt@kernel.org>; Daniel Lezcano <daniel.lezcano@linaro.org>;
> > > > Thomas Gleixner <tglx@linutronix.de>; Geert Uytterhoeven
> > > > <geert+renesas@glider.be>; Magnus Damm <magnus.damm@gmail.com>; Lee
> > > > Jones <lee@kernel.org>; linux- iio@vger.kernel.org;
> > > > linux-renesas-soc@vger.kernel.org;
> > > > devicetree@vger.kernel.org; Fabrizio Castro
> > > > <fabrizio.castro.jz@renesas.com>; Prabhakar Mahadev Lad
> > > > <prabhakar.mahadev-lad.rj@bp.renesas.com>; stable@kernel.org
> > 
> > btw, please trim this stuff :)
> 
> You mean trim the recipient list?

Not the actual recipient list, this junk that outlook adds to emails :)
Biju Das July 24, 2023, 8:21 a.m. UTC | #6
Hi Conor Dooley,

> On Mon, Jul 24, 2023 at 08:04:08AM +0000, Biju Das wrote:
> > Hi Conor Dooley,
> >
> > > Subject: Re: [PATCH 2/6] dt-bindings: timer: renesas,rz-mtu3: Fix
> > > overflow/underflow interrupt names
> > >
> > > On Thu, Jul 20, 2023 at 05:52:00PM +0000, Biju Das wrote:
> > > > > -----Original Message-----
> > > > > From: Conor Dooley <conor@kernel.org>
> > >
> > >
> > > btw, please trim this stuff :)
> >
> > You mean trim the recipient list?
> 
> Not the actual recipient list, this junk that outlook adds to emails :)

Ah OK got it, like above.

Cheers,
Biju
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/timer/renesas,rz-mtu3.yaml b/Documentation/devicetree/bindings/timer/renesas,rz-mtu3.yaml
index eb2d5ebe4df0..670a2ebaacdb 100644
--- a/Documentation/devicetree/bindings/timer/renesas,rz-mtu3.yaml
+++ b/Documentation/devicetree/bindings/timer/renesas,rz-mtu3.yaml
@@ -169,27 +169,27 @@  properties:
       - const: tgib0
       - const: tgic0
       - const: tgid0
-      - const: tgiv0
+      - const: tciv0
       - const: tgie0
       - const: tgif0
       - const: tgia1
       - const: tgib1
-      - const: tgiv1
-      - const: tgiu1
+      - const: tciv1
+      - const: tciu1
       - const: tgia2
       - const: tgib2
-      - const: tgiv2
-      - const: tgiu2
+      - const: tciv2
+      - const: tciu2
       - const: tgia3
       - const: tgib3
       - const: tgic3
       - const: tgid3
-      - const: tgiv3
+      - const: tciv3
       - const: tgia4
       - const: tgib4
       - const: tgic4
       - const: tgid4
-      - const: tgiv4
+      - const: tciv4
       - const: tgiu5
       - const: tgiv5
       - const: tgiw5
@@ -197,18 +197,18 @@  properties:
       - const: tgib6
       - const: tgic6
       - const: tgid6
-      - const: tgiv6
+      - const: tciv6
       - const: tgia7
       - const: tgib7
       - const: tgic7
       - const: tgid7
-      - const: tgiv7
+      - const: tciv7
       - const: tgia8
       - const: tgib8
       - const: tgic8
       - const: tgid8
-      - const: tgiv8
-      - const: tgiu8
+      - const: tciv8
+      - const: tciu8
 
   clocks:
     maxItems: 1
@@ -285,16 +285,16 @@  examples:
                    <GIC_SPI 211 IRQ_TYPE_EDGE_RISING>,
                    <GIC_SPI 212 IRQ_TYPE_EDGE_RISING>,
                    <GIC_SPI 213 IRQ_TYPE_EDGE_RISING>;
-      interrupt-names = "tgia0", "tgib0", "tgic0", "tgid0", "tgiv0", "tgie0",
+      interrupt-names = "tgia0", "tgib0", "tgic0", "tgid0", "tciv0", "tgie0",
                         "tgif0",
-                        "tgia1", "tgib1", "tgiv1", "tgiu1",
-                        "tgia2", "tgib2", "tgiv2", "tgiu2",
-                        "tgia3", "tgib3", "tgic3", "tgid3", "tgiv3",
-                        "tgia4", "tgib4", "tgic4", "tgid4", "tgiv4",
+                        "tgia1", "tgib1", "tciv1", "tciu1",
+                        "tgia2", "tgib2", "tciv2", "tciu2",
+                        "tgia3", "tgib3", "tgic3", "tgid3", "tciv3",
+                        "tgia4", "tgib4", "tgic4", "tgid4", "tciv4",
                         "tgiu5", "tgiv5", "tgiw5",
-                        "tgia6", "tgib6", "tgic6", "tgid6", "tgiv6",
-                        "tgia7", "tgib7", "tgic7", "tgid7", "tgiv7",
-                        "tgia8", "tgib8", "tgic8", "tgid8", "tgiv8", "tgiu8";
+                        "tgia6", "tgib6", "tgic6", "tgid6", "tciv6",
+                        "tgia7", "tgib7", "tgic7", "tgid7", "tciv7",
+                        "tgia8", "tgib8", "tgic8", "tgid8", "tciv8", "tciu8";
       clocks = <&cpg CPG_MOD R9A07G044_MTU_X_MCK_MTU3>;
       power-domains = <&cpg>;
       resets = <&cpg R9A07G044_MTU_X_PRESET_MTU3>;