diff mbox series

iio: light: opt4001: Use i2c_get_match_data()

Message ID 20230812151908.188696-1-biju.das.jz@bp.renesas.com (mailing list archive)
State Accepted
Delegated to: Geert Uytterhoeven
Headers show
Series iio: light: opt4001: Use i2c_get_match_data() | expand

Commit Message

Biju Das Aug. 12, 2023, 3:19 p.m. UTC
Replace device_get_match_data()->i2c_get_match_data() to extend matching
support for ID table.

Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
---
 drivers/iio/light/opt4001.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jonathan Cameron Aug. 28, 2023, 4:23 p.m. UTC | #1
On Sat, 12 Aug 2023 16:19:08 +0100
Biju Das <biju.das.jz@bp.renesas.com> wrote:

> Replace device_get_match_data()->i2c_get_match_data() to extend matching
> support for ID table.
> 
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>

This is fairly harmless (I think) but if Stefan or anyone else has a comment
I won't be pushing this out as non rebasing until after rc1.

Applied to the togreg branch of iio.git and pushed out as testing.

Thanks,

Jonathan

> ---
>  drivers/iio/light/opt4001.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/light/opt4001.c b/drivers/iio/light/opt4001.c
> index 502946bf9f94..6cf60151b3d8 100644
> --- a/drivers/iio/light/opt4001.c
> +++ b/drivers/iio/light/opt4001.c
> @@ -412,7 +412,7 @@ static int opt4001_probe(struct i2c_client *client)
>  	if (dev_id != OPT4001_DEVICE_ID_VAL)
>  		dev_warn(&client->dev, "Device ID: %#04x unknown\n", dev_id);
>  
> -	chip->chip_info = device_get_match_data(&client->dev);
> +	chip->chip_info = i2c_get_match_data(client);
>  
>  	indio_dev->channels = opt4001_channels;
>  	indio_dev->num_channels = ARRAY_SIZE(opt4001_channels);
Stefan Windfeldt-Prytz Aug. 30, 2023, 8:17 a.m. UTC | #2
On 8/12/23 17:19, Biju Das wrote:
> Replace device_get_match_data()->i2c_get_match_data() to extend matching
> support for ID table.
> 
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> ---
>   drivers/iio/light/opt4001.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/light/opt4001.c b/drivers/iio/light/opt4001.c
> index 502946bf9f94..6cf60151b3d8 100644
> --- a/drivers/iio/light/opt4001.c
> +++ b/drivers/iio/light/opt4001.c
> @@ -412,7 +412,7 @@ static int opt4001_probe(struct i2c_client *client)
>   	if (dev_id != OPT4001_DEVICE_ID_VAL)
>   		dev_warn(&client->dev, "Device ID: %#04x unknown\n", dev_id);
>   
> -	chip->chip_info = device_get_match_data(&client->dev);
> +	chip->chip_info = i2c_get_match_data(client);
>   
>   	indio_dev->channels = opt4001_channels;
>   	indio_dev->num_channels = ARRAY_SIZE(opt4001_channels);

Reviewed-by: Stefan Windfeldt-Prytz <stefan.windfeldt-prytz@axis.com>
Tested-by: Stefan Windfeldt-Prytz <stefan.windfeldt-prytz@axis.com>
diff mbox series

Patch

diff --git a/drivers/iio/light/opt4001.c b/drivers/iio/light/opt4001.c
index 502946bf9f94..6cf60151b3d8 100644
--- a/drivers/iio/light/opt4001.c
+++ b/drivers/iio/light/opt4001.c
@@ -412,7 +412,7 @@  static int opt4001_probe(struct i2c_client *client)
 	if (dev_id != OPT4001_DEVICE_ID_VAL)
 		dev_warn(&client->dev, "Device ID: %#04x unknown\n", dev_id);
 
-	chip->chip_info = device_get_match_data(&client->dev);
+	chip->chip_info = i2c_get_match_data(client);
 
 	indio_dev->channels = opt4001_channels;
 	indio_dev->num_channels = ARRAY_SIZE(opt4001_channels);