| Message ID | 20230812162222.200004-1-biju.das.jz@bp.renesas.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
| Series | iio: mlx90614: Use i2c_get_match_data() | expand |
It should not break some backwards compatibility so: Acked-by: "Crt Mori <cmo@melexis.com>" On Sat, 12 Aug 2023 at 18:22, Biju Das <biju.das.jz@bp.renesas.com> wrote: > > Replace device_get_match_data()->i2c_get_match_data() to extend matching > support for ID table. > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> > --- > drivers/iio/temperature/mlx90614.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iio/temperature/mlx90614.c b/drivers/iio/temperature/mlx90614.c > index 07bb5df24ab3..740018d4b3df 100644 > --- a/drivers/iio/temperature/mlx90614.c > +++ b/drivers/iio/temperature/mlx90614.c > @@ -600,7 +600,7 @@ static int mlx90614_probe(struct i2c_client *client) > data->client = client; > mutex_init(&data->lock); > data->wakeup_gpio = mlx90614_probe_wakeup(client); > - data->chip_info = device_get_match_data(&client->dev); > + data->chip_info = i2c_get_match_data(client); > > mlx90614_wakeup(data); > > -- > 2.25.1 >
Hi Crt Mori, > Subject: Re: [PATCH] iio: mlx90614: Use i2c_get_match_data() > > It should not break some backwards compatibility so: You mean, Fixes: 3d5ead238bc8 ("iio: mlx90614: Factor our register IO and constants into model specific descriptor") Hi Jonathan, Is it some thing you can do while applying Cc ing stable@kernel.org ? Cheers, Biju > Acked-by: "Crt Mori <cmo@melexis.com>" > > On Sat, 12 Aug 2023 at 18:22, Biju Das <biju.das.jz@bp.renesas.com> wrote: > > > > Replace device_get_match_data()->i2c_get_match_data() to extend > > matching support for ID table. > > > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> > > --- > > drivers/iio/temperature/mlx90614.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/iio/temperature/mlx90614.c > > b/drivers/iio/temperature/mlx90614.c > > index 07bb5df24ab3..740018d4b3df 100644 > > --- a/drivers/iio/temperature/mlx90614.c > > +++ b/drivers/iio/temperature/mlx90614.c > > @@ -600,7 +600,7 @@ static int mlx90614_probe(struct i2c_client *client) > > data->client = client; > > mutex_init(&data->lock); > > data->wakeup_gpio = mlx90614_probe_wakeup(client); > > - data->chip_info = device_get_match_data(&client->dev); > > + data->chip_info = i2c_get_match_data(client); > > > > mlx90614_wakeup(data); > > > > -- > > 2.25.1 > >
Hi Jonathan Cameron, > Subject: Re: [PATCH] iio: mlx90614: Use i2c_get_match_data() > > On Mon, 14 Aug 2023 08:28:28 +0000 > Biju Das <biju.das.jz@bp.renesas.com> wrote: > > > Hi Crt Mori, > > > > > Subject: Re: [PATCH] iio: mlx90614: Use i2c_get_match_data() > > > > > > It should not break some backwards compatibility so: > > > > You mean, > > > > Fixes: 3d5ead238bc8 ("iio: mlx90614: Factor our register IO and > > constants into model specific descriptor") > > > > Hi Jonathan, > > > > Is it some thing you can do while applying Cc ing stable@kernel.org ? > > You've lost me. > > I think Crt was just saying this patch is fine, not referring to any other > changes. Ok, Biju > > Biju > > > > > Acked-by: "Crt Mori <cmo@melexis.com>" > > > > > > On Sat, 12 Aug 2023 at 18:22, Biju Das <biju.das.jz@bp.renesas.com> > wrote: > > > > > > > > Replace device_get_match_data()->i2c_get_match_data() to extend > > > > matching support for ID table. > > > > > > > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> > > > > --- > > > > drivers/iio/temperature/mlx90614.c | 2 +- > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > diff --git a/drivers/iio/temperature/mlx90614.c > > > > b/drivers/iio/temperature/mlx90614.c > > > > index 07bb5df24ab3..740018d4b3df 100644 > > > > --- a/drivers/iio/temperature/mlx90614.c > > > > +++ b/drivers/iio/temperature/mlx90614.c > > > > @@ -600,7 +600,7 @@ static int mlx90614_probe(struct i2c_client > *client) > > > > data->client = client; > > > > mutex_init(&data->lock); > > > > data->wakeup_gpio = mlx90614_probe_wakeup(client); > > > > - data->chip_info = device_get_match_data(&client->dev); > > > > + data->chip_info = i2c_get_match_data(client); > > > > > > > > mlx90614_wakeup(data); > > > > > > > > -- > > > > 2.25.1 > > > >
diff --git a/drivers/iio/temperature/mlx90614.c b/drivers/iio/temperature/mlx90614.c index 07bb5df24ab3..740018d4b3df 100644 --- a/drivers/iio/temperature/mlx90614.c +++ b/drivers/iio/temperature/mlx90614.c @@ -600,7 +600,7 @@ static int mlx90614_probe(struct i2c_client *client) data->client = client; mutex_init(&data->lock); data->wakeup_gpio = mlx90614_probe_wakeup(client); - data->chip_info = device_get_match_data(&client->dev); + data->chip_info = i2c_get_match_data(client); mlx90614_wakeup(data);
Replace device_get_match_data()->i2c_get_match_data() to extend matching support for ID table. Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> --- drivers/iio/temperature/mlx90614.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)