| Message ID | 20230819183155.22335-1-biju.das.jz@bp.renesas.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
| Series | mfd: mc13xxx: Simplify probe() | expand |
On Sat, 19 Aug 2023 19:31:55 +0100, Biju Das wrote: > Simplify probe() by replacing of_match_device() and ID lookup > for retrieving match data by i2c_get_match_data(). > > Applied, thanks! [1/1] mfd: mc13xxx: Simplify probe() commit: 2c1375064ea6e62d529e9d545292537a0b21dbdf -- Lee Jones [李琼斯]
On Sat, 19 Aug 2023, Biju Das wrote: > Simplify probe() by replacing of_match_device() and ID lookup > for retrieving match data by i2c_get_match_data(). > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> > --- > Note: > * This patch is only compile tested. > --- > drivers/mfd/mc13xxx-i2c.c | 9 +-------- > 1 file changed, 1 insertion(+), 8 deletions(-) I improved the inadequate subject line before applying. Please ensure subject lines are both succinct and forthcoming.
Hi Lee Jones, Thanks for the feedback. > Subject: Re: [PATCH] mfd: mc13xxx: Simplify probe() > > On Sat, 19 Aug 2023, Biju Das wrote: > > > Simplify probe() by replacing of_match_device() and ID lookup for > > retrieving match data by i2c_get_match_data(). > > > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> > > --- > > Note: > > * This patch is only compile tested. > > --- > > drivers/mfd/mc13xxx-i2c.c | 9 +-------- > > 1 file changed, 1 insertion(+), 8 deletions(-) > > I improved the inadequate subject line before applying. > > Please ensure subject lines are both succinct and forthcoming. My bad, will take care next time. Cheers, Biju
diff --git a/drivers/mfd/mc13xxx-i2c.c b/drivers/mfd/mc13xxx-i2c.c index de59b498c925..6bc0e755ba34 100644 --- a/drivers/mfd/mc13xxx-i2c.c +++ b/drivers/mfd/mc13xxx-i2c.c @@ -53,7 +53,6 @@ static const struct regmap_config mc13xxx_regmap_i2c_config = { static int mc13xxx_i2c_probe(struct i2c_client *client) { - const struct i2c_device_id *id = i2c_client_get_device_id(client); struct mc13xxx *mc13xxx; int ret; @@ -73,13 +72,7 @@ static int mc13xxx_i2c_probe(struct i2c_client *client) return ret; } - if (client->dev.of_node) { - const struct of_device_id *of_id = - of_match_device(mc13xxx_dt_ids, &client->dev); - mc13xxx->variant = of_id->data; - } else { - mc13xxx->variant = (void *)id->driver_data; - } + mc13xxx->variant = i2c_get_match_data(client); return mc13xxx_common_init(&client->dev); }
Simplify probe() by replacing of_match_device() and ID lookup for retrieving match data by i2c_get_match_data(). Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> --- Note: * This patch is only compile tested. --- drivers/mfd/mc13xxx-i2c.c | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-)