diff mbox series

soc: renesas: Kconfig: For ARCH_R9A07G043 select the required configs if dependencies are met

Message ID 20230901110936.313171-1-prabhakar.mahadev-lad.rj@bp.renesas.com (mailing list archive)
State Accepted
Delegated to: Geert Uytterhoeven
Headers show
Series soc: renesas: Kconfig: For ARCH_R9A07G043 select the required configs if dependencies are met | expand

Commit Message

Lad, Prabhakar Sept. 1, 2023, 11:09 a.m. UTC
From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

To prevent randconfig build issues when enabling the RZ/Five SoC, consider
selecting specific configurations only when their dependencies are
satisfied.

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202308311610.ec6bm2G8-lkp@intel.com/
Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
---
 drivers/soc/renesas/Kconfig | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

Comments

Geert Uytterhoeven Sept. 1, 2023, 11:44 a.m. UTC | #1
Hi Prabhakar,

On Fri, Sep 1, 2023 at 1:10 PM Prabhakar <prabhakar.csengg@gmail.com> wrote:
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>
> To prevent randconfig build issues when enabling the RZ/Five SoC, consider
> selecting specific configurations only when their dependencies are
> satisfied.

Thanks for your patch!

> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202308311610.ec6bm2G8-lkp@intel.com/
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

Fixes: ed1a8872ff839de0 ("soc: renesas: Kconfig: Select the required
configs for RZ/Five SoC")

> --- a/drivers/soc/renesas/Kconfig
> +++ b/drivers/soc/renesas/Kconfig
> @@ -334,10 +334,11 @@ if RISCV
>  config ARCH_R9A07G043
>         bool "RISC-V Platform support for RZ/Five"
>         select ARCH_RZG2L
> -       select AX45MP_L2_CACHE
> +       select AX45MP_L2_CACHE if RISCV_DMA_NONCOHERENT
>         select DMA_GLOBAL_POOL
> -       select ERRATA_ANDES
> -       select ERRATA_ANDES_CMO
> +       select ERRATA_ANDES if RISCV_SBI
> +       select ERRATA_ANDES_CMO if ERRATA_ANDES
> +
>         help
>           This enables support for the Renesas RZ/Five SoC.

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

As the offending commit won't be in my tree until v6.6-rc1, I cannot
take it now, and risc/for-next sounds like the best target.
Acked-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert
Lad, Prabhakar Sept. 1, 2023, 11:53 a.m. UTC | #2
Hi Geert,

Thank you for the review.

On Fri, Sep 1, 2023 at 12:44 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
>
> Hi Prabhakar,
>
> On Fri, Sep 1, 2023 at 1:10 PM Prabhakar <prabhakar.csengg@gmail.com> wrote:
> > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> >
> > To prevent randconfig build issues when enabling the RZ/Five SoC, consider
> > selecting specific configurations only when their dependencies are
> > satisfied.
>
> Thanks for your patch!
>
> > Reported-by: kernel test robot <lkp@intel.com>
> > Closes: https://lore.kernel.org/oe-kbuild-all/202308311610.ec6bm2G8-lkp@intel.com/
> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>
> Fixes: ed1a8872ff839de0 ("soc: renesas: Kconfig: Select the required
> configs for RZ/Five SoC")
>
> > --- a/drivers/soc/renesas/Kconfig
> > +++ b/drivers/soc/renesas/Kconfig
> > @@ -334,10 +334,11 @@ if RISCV
> >  config ARCH_R9A07G043
> >         bool "RISC-V Platform support for RZ/Five"
> >         select ARCH_RZG2L
> > -       select AX45MP_L2_CACHE
> > +       select AX45MP_L2_CACHE if RISCV_DMA_NONCOHERENT
> >         select DMA_GLOBAL_POOL
> > -       select ERRATA_ANDES
> > -       select ERRATA_ANDES_CMO
> > +       select ERRATA_ANDES if RISCV_SBI
> > +       select ERRATA_ANDES_CMO if ERRATA_ANDES
> > +
> >         help
> >           This enables support for the Renesas RZ/Five SoC.
>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> As the offending commit won't be in my tree until v6.6-rc1, I cannot
> take it now, and risc/for-next sounds like the best target.
> Acked-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
Agreed.

Palmer, can you please pick this patch via riscv tree?

Cheers,
Prabhakar
patchwork-bot+linux-riscv@kernel.org Sept. 6, 2023, 2:50 a.m. UTC | #3
Hello:

This patch was applied to riscv/linux.git (for-next)
by Palmer Dabbelt <palmer@rivosinc.com>:

On Fri,  1 Sep 2023 12:09:36 +0100 you wrote:
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> 
> To prevent randconfig build issues when enabling the RZ/Five SoC, consider
> selecting specific configurations only when their dependencies are
> satisfied.
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202308311610.ec6bm2G8-lkp@intel.com/
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> 
> [...]

Here is the summary with links:
  - soc: renesas: Kconfig: For ARCH_R9A07G043 select the required configs if dependencies are met
    https://git.kernel.org/riscv/c/9e2864968816

You are awesome, thank you!
diff mbox series

Patch

diff --git a/drivers/soc/renesas/Kconfig b/drivers/soc/renesas/Kconfig
index 67604f24973e..5a75ab64d1ed 100644
--- a/drivers/soc/renesas/Kconfig
+++ b/drivers/soc/renesas/Kconfig
@@ -334,10 +334,11 @@  if RISCV
 config ARCH_R9A07G043
 	bool "RISC-V Platform support for RZ/Five"
 	select ARCH_RZG2L
-	select AX45MP_L2_CACHE
+	select AX45MP_L2_CACHE if RISCV_DMA_NONCOHERENT
 	select DMA_GLOBAL_POOL
-	select ERRATA_ANDES
-	select ERRATA_ANDES_CMO
+	select ERRATA_ANDES if RISCV_SBI
+	select ERRATA_ANDES_CMO if ERRATA_ANDES
+
 	help
 	  This enables support for the Renesas RZ/Five SoC.