| Message ID | 20230922080421.35145-4-wsa+renesas@sang-engineering.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 4b910840f9f3f5e04c98cbca5b0229d0575a407e |
| Delegated to: | Kieran Bingham |
| Headers | show |
| Series | treewide: drop check because i2c_unregister_device() is NULL safe | expand |
Quoting Wolfram Sang (2023-09-22 09:04:20) > No need to check the argument of i2c_unregister_device() because the > function itself does it. > Having reviewed the RDACM20 patch, I think I can say this looks accurate too. Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> > --- > Build tested only. Please apply to your tree. > > drivers/media/dvb-frontends/m88ds3103.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/media/dvb-frontends/m88ds3103.c b/drivers/media/dvb-frontends/m88ds3103.c > index cf037b61b226..26c67ef05d13 100644 > --- a/drivers/media/dvb-frontends/m88ds3103.c > +++ b/drivers/media/dvb-frontends/m88ds3103.c > @@ -1920,8 +1920,7 @@ static void m88ds3103_remove(struct i2c_client *client) > > dev_dbg(&client->dev, "\n"); > > - if (dev->dt_client) > - i2c_unregister_device(dev->dt_client); > + i2c_unregister_device(dev->dt_client); > > i2c_mux_del_adapters(dev->muxc); > > -- > 2.30.2 >
On Fri, Sep 22, 2023 at 1:45 PM Wolfram Sang <wsa+renesas@sang-engineering.com> wrote: > No need to check the argument of i2c_unregister_device() because the > function itself does it. > > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert
diff --git a/drivers/media/dvb-frontends/m88ds3103.c b/drivers/media/dvb-frontends/m88ds3103.c index cf037b61b226..26c67ef05d13 100644 --- a/drivers/media/dvb-frontends/m88ds3103.c +++ b/drivers/media/dvb-frontends/m88ds3103.c @@ -1920,8 +1920,7 @@ static void m88ds3103_remove(struct i2c_client *client) dev_dbg(&client->dev, "\n"); - if (dev->dt_client) - i2c_unregister_device(dev->dt_client); + i2c_unregister_device(dev->dt_client); i2c_mux_del_adapters(dev->muxc);
No need to check the argument of i2c_unregister_device() because the function itself does it. Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> --- Build tested only. Please apply to your tree. drivers/media/dvb-frontends/m88ds3103.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)