[v3,2/4] clk: rs9: Limit check to vendor ID in VID register

Commit Message

Marek Vasut Nov. 13, 2023, 10:18 p.m. UTC

Extract only vendor ID from VID register, the top 4 bits are
revision ID which are not useful for the vendor ID check.

Reviewed-by: Biju Das <[e-mail]>
Signed-off-by: Marek Vasut <[e-mail]>
---
Cc: Alexander Stein <[e-mail]>
Cc: Conor Dooley <[e-mail]>
Cc: Geert Uytterhoeven <[e-mail]>
Cc: Krzysztof Kozlowski <[e-mail]>
Cc: Michael Turquette <[e-mail]>
Cc: Rob Herring <[e-mail]>
Cc: Stephen Boyd <[e-mail]>
Cc: [e-mail]
Cc: [e-mail]
Cc: [e-mail]
---
V2: Split off patch from 4/4
V3: Add RB from Biju
---
 drivers/clk/clk-renesas-pcie.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Stephen Boyd Dec. 17, 2023, 11:28 p.m. UTC | #1

Quoting Marek Vasut (2023-11-13 14:18:52)
> Extract only vendor ID from VID register, the top 4 bits are
> revision ID which are not useful for the vendor ID check.
> 
> Reviewed-by: Biju Das <[e-mail]>
> Signed-off-by: Marek Vasut <[e-mail]>
> ---

Applied to clk-next

Patch

diff --git a/drivers/clk/clk-renesas-pcie.c b/drivers/clk/clk-renesas-pcie.c
index 6606aba253c5..b5c430e4899c 100644
--- a/drivers/clk/clk-renesas-pcie.c
+++ b/drivers/clk/clk-renesas-pcie.c
@@ -42,6 +42,7 @@ 
 #define RS9_REG_DID				0x6
 #define RS9_REG_BCP				0x7
 
+#define RS9_REG_VID_MASK			GENMASK(3, 0)
 #define RS9_REG_VID_IDT				0x01
 
 #define RS9_REG_DID_TYPE_FGV			(0x0 << RS9_REG_DID_TYPE_SHIFT)
@@ -333,6 +334,7 @@  static int rs9_probe(struct i2c_client *client)
 	if (ret < 0)
 		return ret;
 
+	vid &= RS9_REG_VID_MASK;
 	if (vid != RS9_REG_VID_IDT || did != rs9->chip_info->did)
 		return dev_err_probe(&client->dev, -ENODEV,
 				     "Incorrect VID/DID: %#02x, %#02x. Expected %#02x, %#02x\n",