diff mbox series

[v3.1,3/8] dt-bindings: watchdog: dlg,da9062-watchdog: Document DA9063 watchdog

Message ID 20231204172510.35041-4-biju.das.jz@bp.renesas.com (mailing list archive)
State Superseded
Delegated to: Geert Uytterhoeven
Headers show
Series Convert DA906{1,2} bindings to json-schema | expand

Commit Message

Biju Das Dec. 4, 2023, 5:25 p.m. UTC 
Document DA9063 watchdog device as it is similar to DA9062 watchdog.

Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
Acked-by: Conor Dooley <conor.dooley@microchip.com>
---
v3->v3.1:
 * Added Ack from Conor Dooley.
 * Updated title DA9062/61->DA906{1,2,3} as it supports DA9063.
 * Retained Rb tag since the changes are trivial.
v2->v3:
 * No change
v2:
 * New patch
---
 .../devicetree/bindings/watchdog/dlg,da9062-watchdog.yaml      | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Geert Uytterhoeven Dec. 5, 2023, 8:47 a.m. UTC | #1 
Hi Biju,

On Mon, Dec 4, 2023 at 6:25 PM Biju Das <biju.das.jz@bp.renesas.com> wrote:
> Document DA9063 watchdog device as it is similar to DA9062 watchdog.
>
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> Acked-by: Conor Dooley <conor.dooley@microchip.com>
> ---
> v3->v3.1:
>  * Added Ack from Conor Dooley.
>  * Updated title DA9062/61->DA906{1,2,3} as it supports DA9063.
>  * Retained Rb tag since the changes are trivial.

Thanks for the update!

> --- a/Documentation/devicetree/bindings/watchdog/dlg,da9062-watchdog.yaml
> +++ b/Documentation/devicetree/bindings/watchdog/dlg,da9062-watchdog.yaml

> @@ -18,6 +18,7 @@ properties:
>        - items:
>            - enum:
>                - dlg,da9062-watchdog
> +              - dlg,da9063-watchdog
>        - items:
>            - const: dlg,da9061-watchdog
>            - const: dlg,da9062-watchdog

This matches the existing usage in DT, so
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

However, I believe we do have a runtime issue here, as the driver
currently matches against dlg,da9062-watchdog only, so the watchdog
must be non-functional on DA9063?

Gr{oetje,eeting}s,

                        Geert


--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
Biju Das Dec. 5, 2023, 9:01 a.m. UTC | #2 
Hi Geert,

Thanks for the feedback.

> -----Original Message-----
> From: Geert Uytterhoeven <geert@linux-m68k.org>
> Sent: Tuesday, December 5, 2023 8:47 AM
> Subject: Re: [PATCH v3.1 3/8] dt-bindings: watchdog: dlg,da9062-watchdog:
> Document DA9063 watchdog
> 
> Hi Biju,
> 
> On Mon, Dec 4, 2023 at 6:25 PM Biju Das <biju.das.jz@bp.renesas.com>
> wrote:
> > Document DA9063 watchdog device as it is similar to DA9062 watchdog.
> >
> > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> > Acked-by: Conor Dooley <conor.dooley@microchip.com>
> > ---
> > v3->v3.1:
> >  * Added Ack from Conor Dooley.
> >  * Updated title DA9062/61->DA906{1,2,3} as it supports DA9063.
> >  * Retained Rb tag since the changes are trivial.
> 
> Thanks for the update!
> 
> > ---
> > a/Documentation/devicetree/bindings/watchdog/dlg,da9062-watchdog.yaml
> > +++ b/Documentation/devicetree/bindings/watchdog/dlg,da9062-watchdog.y
> > +++ aml
> 
> > @@ -18,6 +18,7 @@ properties:
> >        - items:
> >            - enum:
> >                - dlg,da9062-watchdog
> > +              - dlg,da9063-watchdog
> >        - items:
> >            - const: dlg,da9061-watchdog
> >            - const: dlg,da9062-watchdog
> 
> This matches the existing usage in DT, so
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> 
> However, I believe we do have a runtime issue here, as the driver
> currently matches against dlg,da9062-watchdog only, so the watchdog must
> be non-functional on DA9063?

Of_compatible is defined in [1], but the corresponding driver[2] is missing the compatible
[1]
drivers/mfd/da9063-core.c:		.of_compatible	= "dlg,da9063-watchdog",

[2]
drivers/watchdog/da9063_wdt.c

Not sure of_compaible in MFD will instantiate driver [2] or not?

Cheers,
Biju
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/watchdog/dlg,da9062-watchdog.yaml b/Documentation/devicetree/bindings/watchdog/dlg,da9062-watchdog.yaml
index 7c63b99dac85..d2088e308b45 100644
--- a/Documentation/devicetree/bindings/watchdog/dlg,da9062-watchdog.yaml
+++ b/Documentation/devicetree/bindings/watchdog/dlg,da9062-watchdog.yaml
@@ -4,7 +4,7 @@ 
 $id: http://devicetree.org/schemas/watchdog/dlg,da9062-watchdog.yaml#
 $schema: http://devicetree.org/meta-schemas/core.yaml#
 
-title: Dialog Semiconductor DA9062/61 Watchdog Timer
+title: Dialog Semiconductor DA906{1,2,3} Watchdog Timer
 
 maintainers:
   - Steve Twiss <stwiss.opensource@diasemi.com>
@@ -18,6 +18,7 @@  properties:
       - items:
           - enum:
               - dlg,da9062-watchdog
+              - dlg,da9063-watchdog
       - items:
           - const: dlg,da9061-watchdog
           - const: dlg,da9062-watchdog