diff mbox series

[1/4] dt-bindings: soc: renesas: Document Renesas RZ/V2H{P} SoC variants

Message ID 20240219160912.1206647-2-prabhakar.mahadev-lad.rj@bp.renesas.com (mailing list archive)
State Under Review
Delegated to: Geert Uytterhoeven
Headers show
Series Add new Renesas RZ/V2H SoC | expand

Commit Message

Lad, Prabhakar Feb. 19, 2024, 4:09 p.m. UTC 
From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

Document Renesas RZ/V2H{P} (R9A09G057) SoC variants.

Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Reviewed-by: Fabrizio Castro <fabrizio.castro.jz@renesas.com>
---
 .../devicetree/bindings/soc/renesas/renesas.yaml          | 8 ++++++++
 1 file changed, 8 insertions(+)

Comments

Krzysztof Kozlowski Feb. 20, 2024, 9:50 a.m. UTC | #1 
On 19/02/2024 17:09, Prabhakar wrote:
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> 
> Document Renesas RZ/V2H{P} (R9A09G057) SoC variants.
> 
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> Reviewed-by: Fabrizio Castro <fabrizio.castro.jz@renesas.com>
> ---

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof
Geert Uytterhoeven Feb. 26, 2024, 1:41 p.m. UTC | #2 
Hi Prabhakar,

Thanks for your patch!

On Mon, Feb 19, 2024 at 5:10 PM Prabhakar <prabhakar.csengg@gmail.com> wrote:
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>
> Document Renesas RZ/V2H{P} (R9A09G057) SoC variants.

I think "RZ/V2H(P)" would be better, as curly braces are usually used
to group multiple values (e.g. "RZ/G2{L,LC}").

> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> Reviewed-by: Fabrizio Castro <fabrizio.castro.jz@renesas.com>
> ---
>  .../devicetree/bindings/soc/renesas/renesas.yaml          | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/soc/renesas/renesas.yaml b/Documentation/devicetree/bindings/soc/renesas/renesas.yaml
> index c1ce4da2dc32..109fbc8d48db 100644
> --- a/Documentation/devicetree/bindings/soc/renesas/renesas.yaml
> +++ b/Documentation/devicetree/bindings/soc/renesas/renesas.yaml
> @@ -513,6 +513,14 @@ properties:
>                - renesas,rzv2mevk2   # RZ/V2M Eval Board v2.0
>            - const: renesas,r9a09g011
>
> +      - description: RZ/V2H{P} (R9A09G057)

RZ/V2H(P)

> +        items:
> +          - enum:
> +              - renesas,r9a09g057h41 # RZ/V2H
> +              - renesas,r9a09g057h42 # RZ/V2H with Mali-G31 support
> +              - renesas,r9a09g057h44 # RZ/V2HP with Mali-G31 + Mali-C55 support
> +          - const: renesas,r9a09g057
> +
>  additionalProperties: true

The rest LGTM, so
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert


--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
Lad, Prabhakar Feb. 26, 2024, 1:55 p.m. UTC | #3 
Hi Geert,

Thank you for the review.

On Mon, Feb 26, 2024 at 1:41 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
>
> Hi Prabhakar,
>
> Thanks for your patch!
>
> On Mon, Feb 19, 2024 at 5:10 PM Prabhakar <prabhakar.csengg@gmail.com> wrote:
> > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> >
> > Document Renesas RZ/V2H{P} (R9A09G057) SoC variants.
>
> I think "RZ/V2H(P)" would be better, as curly braces are usually used
> to group multiple values (e.g. "RZ/G2{L,LC}").
>
Agreed, I will use "RZ/V2H(P)" (here and in rest of the other patches)

> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> > Reviewed-by: Fabrizio Castro <fabrizio.castro.jz@renesas.com>
> > ---
> >  .../devicetree/bindings/soc/renesas/renesas.yaml          | 8 ++++++++
> >  1 file changed, 8 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/soc/renesas/renesas.yaml b/Documentation/devicetree/bindings/soc/renesas/renesas.yaml
> > index c1ce4da2dc32..109fbc8d48db 100644
> > --- a/Documentation/devicetree/bindings/soc/renesas/renesas.yaml
> > +++ b/Documentation/devicetree/bindings/soc/renesas/renesas.yaml
> > @@ -513,6 +513,14 @@ properties:
> >                - renesas,rzv2mevk2   # RZ/V2M Eval Board v2.0
> >            - const: renesas,r9a09g011
> >
> > +      - description: RZ/V2H{P} (R9A09G057)
>
> RZ/V2H(P)
>
OK.

Cheers,
Prabhakar

> > +        items:
> > +          - enum:
> > +              - renesas,r9a09g057h41 # RZ/V2H
> > +              - renesas,r9a09g057h42 # RZ/V2H with Mali-G31 support
> > +              - renesas,r9a09g057h44 # RZ/V2HP with Mali-G31 + Mali-C55 support
> > +          - const: renesas,r9a09g057
> > +
> >  additionalProperties: true
>
> The rest LGTM, so
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> Gr{oetje,eeting}s,
>
>                         Geert
>
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/soc/renesas/renesas.yaml b/Documentation/devicetree/bindings/soc/renesas/renesas.yaml
index c1ce4da2dc32..109fbc8d48db 100644
--- a/Documentation/devicetree/bindings/soc/renesas/renesas.yaml
+++ b/Documentation/devicetree/bindings/soc/renesas/renesas.yaml
@@ -513,6 +513,14 @@  properties:
               - renesas,rzv2mevk2   # RZ/V2M Eval Board v2.0
           - const: renesas,r9a09g011
 
+      - description: RZ/V2H{P} (R9A09G057)
+        items:
+          - enum:
+              - renesas,r9a09g057h41 # RZ/V2H
+              - renesas,r9a09g057h42 # RZ/V2H with Mali-G31 support
+              - renesas,r9a09g057h44 # RZ/V2HP with Mali-G31 + Mali-C55 support
+          - const: renesas,r9a09g057
+
 additionalProperties: true
 
 ...