| Message ID | 20240226194715.427597-2-biju.das.jz@bp.renesas.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | a74b9d4ab0ce199c4b39cb12b6114390604b8fe4 |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
| Series | Enable DA9062 PMIC and built-in RTC, GPIO and ONKEY | expand |
Hi Biju, On Mon, Feb 26, 2024 at 8:47 PM Biju Das <biju.das.jz@bp.renesas.com> wrote: > Enable PMIC DA9062 and the built-in RTC, GPIO and ONKEY modules on the > RZ/{G2UL,Five} SMARC EVK development boards. > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> > --- > v1->v2: > * Dropped disabled status from gpio and onkey nodes. > * Added gpio hog nodes. Thanks for the update! > --- a/arch/arm64/boot/dts/renesas/rzg2ul-smarc.dtsi > +++ b/arch/arm64/boot/dts/renesas/rzg2ul-smarc.dtsi > @@ -5,6 +5,7 @@ > * Copyright (C) 2022 Renesas Electronics Corp. > */ > > +#include <dt-bindings/gpio/gpio.h> Yep, we need this... > #include "rzg2ul-smarc-pinfunction.dtsi" > #include "rz-smarc-common.dtsi" > > @@ -23,6 +24,63 @@ &cpu_dai { > &i2c0 { > clock-frequency = <400000>; > > + da9062: pmic@58 { > + compatible = "dlg,da9062"; > + reg = <0x58>; > + gpio-controller; > + #gpio-cells = <2>; > + > + gpio { > + compatible = "dlg,da9062-gpio"; > + }; > + > + onkey { > + compatible = "dlg,da9062-onkey"; > + }; > + > + pmic-good-hog { > + gpio-hog; > + gpios = <4 0>; ... so this can be replaced by <4 GPIO_ACTIVE_HIGH> ;-) > + output-high; > + line-name = "PMIC_PGOOD"; > + }; Same for the other gpios. Anyway, LGTM Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> i.e. will queue in renesas-devel for v6.10, with s/0/GPIO_ACTIVE_HIGH/. Gr{oetje,eeting}s, Geert
diff --git a/arch/arm64/boot/dts/renesas/rzg2ul-smarc.dtsi b/arch/arm64/boot/dts/renesas/rzg2ul-smarc.dtsi index de590996e10a..f6f6f8280df6 100644 --- a/arch/arm64/boot/dts/renesas/rzg2ul-smarc.dtsi +++ b/arch/arm64/boot/dts/renesas/rzg2ul-smarc.dtsi @@ -5,6 +5,7 @@ * Copyright (C) 2022 Renesas Electronics Corp. */ +#include <dt-bindings/gpio/gpio.h> #include "rzg2ul-smarc-pinfunction.dtsi" #include "rz-smarc-common.dtsi" @@ -23,6 +24,63 @@ &cpu_dai { &i2c0 { clock-frequency = <400000>; + da9062: pmic@58 { + compatible = "dlg,da9062"; + reg = <0x58>; + gpio-controller; + #gpio-cells = <2>; + + gpio { + compatible = "dlg,da9062-gpio"; + }; + + onkey { + compatible = "dlg,da9062-onkey"; + }; + + pmic-good-hog { + gpio-hog; + gpios = <4 0>; + output-high; + line-name = "PMIC_PGOOD"; + }; + + rtc { + compatible = "dlg,da9062-rtc"; + }; + + sd0-pwr-sel-hog { + gpio-hog; + gpios = <1 0>; + input; + line-name = "SD0_PWR_SEL"; + }; + + sd1-pwr-sel-hog { + gpio-hog; + gpios = <2 0>; + input; + line-name = "SD1_PWR_SEL"; + }; + + sw-et0-en-hog { + gpio-hog; + gpios = <3 0>; + input; + line-name = "SW_ET0_EN#"; + }; + + thermal { + compatible = "dlg,da9062-thermal"; + status = "disabled"; + }; + + watchdog { + compatible = "dlg,da9062-watchdog"; + status = "disabled"; + }; + }; + versa3: clock-generator@68 { compatible = "renesas,5p35023"; reg = <0x68>;
Enable PMIC DA9062 and the built-in RTC, GPIO and ONKEY modules on the RZ/{G2UL,Five} SMARC EVK development boards. Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> --- v1->v2: * Dropped disabled status from gpio and onkey nodes. * Added gpio hog nodes. --- arch/arm64/boot/dts/renesas/rzg2ul-smarc.dtsi | 58 +++++++++++++++++++ 1 file changed, 58 insertions(+)