| Message ID | 20240227034539.193573-2-aford173@gmail.com (mailing list archive) |
|---|---|
| State | Under Review |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
| Series | gpu: powervr-rogue: Add PowerVR support for some Renesas devices | expand |
Hi Adam, On Tue, Feb 27, 2024 at 4:46 AM Adam Ford <aford173@gmail.com> wrote: > Update the binding to add support for various Renesas SoC's with PowerVR > Rogue GX6250 and GX6650 GPUs. These devices only need one clock, so update > the table to indicate such like what was done for the ti,am62-gpu. > > Signed-off-by: Adam Ford <aford173@gmail.com> Thanks for your patch! > --- a/Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml > +++ b/Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml > @@ -14,6 +14,11 @@ properties: > compatible: > items: > - enum: > + - renesas,r8a774a1-gpu I would add a comment like this: - renesas,r8a774a1-gpu # PowerVR Series 6XT GX6650 on RZ/G2M > + - renesas,r8a774e1-gpu .. # PowerVR Series 6XT GX6650 on RZ/G2H > + - renesas,r8a77951-gpu ... # PowerVR Series 6XT GX6650 on R-Car H3 ES2.0+ > + - renesas,r8a77960-gpu ... # PowerVR Series 6XT GX6250 on R-Car M3-W > + - renesas,r8a77961-gpu ... # PowerVR Series 6XT GX6250 on R-Car M3-W+ > - ti,am62-gpu > - const: img,img-axe # IMG AXE GPU model/revision is fully discoverable > > @@ -51,7 +56,13 @@ allOf: > properties: > compatible: > contains: > - const: ti,am62-gpu > + enum: > + - ti,am62-gpu > + - renesas,r8a774a1-gpu > + - renesas,r8a774e1-gpu > + - renesas,r8a77951-gpu > + - renesas,r8a77960-gpu > + - renesas,r8a77961-gpu Please preserve alphabetical sort order. > then: > properties: > clocks: > -- > 2.43.0 Gr{oetje,eeting}s, Geert
On Tue, Feb 27, 2024 at 8:48 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote: > > Hi Adam, > > On Tue, Feb 27, 2024 at 4:46 AM Adam Ford <aford173@gmail.com> wrote: > > Update the binding to add support for various Renesas SoC's with PowerVR > > Rogue GX6250 and GX6650 GPUs. These devices only need one clock, so update > > the table to indicate such like what was done for the ti,am62-gpu. > > > > Signed-off-by: Adam Ford <aford173@gmail.com> > > Thanks for your patch! > > > --- a/Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml > > +++ b/Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml > > @@ -14,6 +14,11 @@ properties: > > compatible: > > items: > > - enum: > > + - renesas,r8a774a1-gpu > > I would add a comment like this: > > - renesas,r8a774a1-gpu # PowerVR Series 6XT GX6650 on RZ/G2M After reading [1], s/Series 6XT/Series6XT/g. [1] "[PATCH 00/11] Device tree support for Imagination Series5 GPU" https://lore.kernel.org/all/20240109171950.31010-1-afd@ti.com/ Gr{oetje,eeting}s, Geert
Hi Adam, On Tue, Feb 27, 2024 at 8:48 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote: > On Tue, Feb 27, 2024 at 4:46 AM Adam Ford <aford173@gmail.com> wrote: > > Update the binding to add support for various Renesas SoC's with PowerVR > > Rogue GX6250 and GX6650 GPUs. These devices only need one clock, so update > > the table to indicate such like what was done for the ti,am62-gpu. > > > > Signed-off-by: Adam Ford <aford173@gmail.com> > > --- a/Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml > > +++ b/Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml > > + - renesas,r8a77951-gpu > > ... # PowerVR Series 6XT GX6650 on R-Car H3 ES2.0+ All compatible values for R-Car H3 variants use the r8a7795 "base" value, so that should be: - renesas,r8a7795-gpu # PowerVR Series 6XT GX6650 on R-Car H3 Gr{oetje,eeting}s, Geert
On Tue, Feb 27, 2024 at 9:09 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote: > On Tue, Feb 27, 2024 at 8:48 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote: > > On Tue, Feb 27, 2024 at 4:46 AM Adam Ford <aford173@gmail.com> wrote: > > > Update the binding to add support for various Renesas SoC's with PowerVR > > > Rogue GX6250 and GX6650 GPUs. These devices only need one clock, so update > > > the table to indicate such like what was done for the ti,am62-gpu. > > > > > > Signed-off-by: Adam Ford <aford173@gmail.com> > > > > --- a/Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml > > > +++ b/Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml > > > > + - renesas,r8a77951-gpu > > > > ... # PowerVR Series 6XT GX6650 on R-Car H3 ES2.0+ > > All compatible values for R-Car H3 variants use the r8a7795 "base" value, > so that should be: > > - renesas,r8a7795-gpu # PowerVR Series 6XT GX6650 on R-Car H3 Same for R-Car M3-W, so - renesas,r8a77960-gpu # PowerVR Series 6XT GX6250 on R-Car M3-W Gr{oetje,eeting}s, Geert
Hi Adam, On Mon, 2024-02-26 at 21:45 -0600, Adam Ford wrote: > Update the binding to add support for various Renesas SoC's with PowerVR > Rogue GX6250 and GX6650 GPUs. These devices only need one clock, so update > the table to indicate such like what was done for the ti,am62-gpu. > > Signed-off-by: Adam Ford <aford173@gmail.com> > > diff --git a/Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml b/Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml > index 256e252f8087..7c75104df09f 100644 > --- a/Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml > +++ b/Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml > @@ -14,6 +14,11 @@ properties: > compatible: > items: > - enum: > + - renesas,r8a774a1-gpu > + - renesas,r8a774e1-gpu > + - renesas,r8a77951-gpu > + - renesas,r8a77960-gpu > + - renesas,r8a77961-gpu > - ti,am62-gpu > - const: img,img-axe # IMG AXE GPU model/revision is fully discoverable A new set of items should be added for 'img,powervr-series6xt' and the Renesas models along the lines of [1]. Thanks Frank [1] https://gitlab.freedesktop.org/imagination/linux/-/blob/powervr-next/Documentation/devicetree/bindings/gpu/img,powervr.yaml?ref_type=heads#L16-19 > > @@ -51,7 +56,13 @@ allOf: > properties: > compatible: > contains: > - const: ti,am62-gpu > + enum: > + - ti,am62-gpu > + - renesas,r8a774a1-gpu > + - renesas,r8a774e1-gpu > + - renesas,r8a77951-gpu > + - renesas,r8a77960-gpu > + - renesas,r8a77961-gpu > then: > properties: > clocks:
On Thu, Mar 7, 2024 at 6:41 AM Frank Binns <Frank.Binns@imgtec.com> wrote: > > Hi Adam, > > On Mon, 2024-02-26 at 21:45 -0600, Adam Ford wrote: > > Update the binding to add support for various Renesas SoC's with PowerVR > > Rogue GX6250 and GX6650 GPUs. These devices only need one clock, so update > > the table to indicate such like what was done for the ti,am62-gpu. > > > > Signed-off-by: Adam Ford <aford173@gmail.com> > > > > diff --git a/Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml b/Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml > > index 256e252f8087..7c75104df09f 100644 > > --- a/Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml > > +++ b/Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml > > @@ -14,6 +14,11 @@ properties: > > compatible: > > items: > > - enum: > > + - renesas,r8a774a1-gpu > > + - renesas,r8a774e1-gpu > > + - renesas,r8a77951-gpu > > + - renesas,r8a77960-gpu > > + - renesas,r8a77961-gpu > > - ti,am62-gpu > > - const: img,img-axe # IMG AXE GPU model/revision is fully discoverable > > A new set of items should be added for 'img,powervr-series6xt' and the Renesas > models along the lines of [1]. Should I rebase my binding off the one below, so it applies to your branch or should I attempt to base it off the mainline? > > Thanks > Frank > > [1] > https://gitlab.freedesktop.org/imagination/linux/-/blob/powervr-next/Documentation/devicetree/bindings/gpu/img,powervr.yaml?ref_type=heads#L16-19 > > > > > @@ -51,7 +56,13 @@ allOf: > > properties: > > compatible: > > contains: > > - const: ti,am62-gpu > > + enum: > > + - ti,am62-gpu > > + - renesas,r8a774a1-gpu > > + - renesas,r8a774e1-gpu > > + - renesas,r8a77951-gpu > > + - renesas,r8a77960-gpu > > + - renesas,r8a77961-gpu > > then: > > properties: > > clocks:
diff --git a/Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml b/Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml index 256e252f8087..7c75104df09f 100644 --- a/Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml +++ b/Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml @@ -14,6 +14,11 @@ properties: compatible: items: - enum: + - renesas,r8a774a1-gpu + - renesas,r8a774e1-gpu + - renesas,r8a77951-gpu + - renesas,r8a77960-gpu + - renesas,r8a77961-gpu - ti,am62-gpu - const: img,img-axe # IMG AXE GPU model/revision is fully discoverable @@ -51,7 +56,13 @@ allOf: properties: compatible: contains: - const: ti,am62-gpu + enum: + - ti,am62-gpu + - renesas,r8a774a1-gpu + - renesas,r8a774e1-gpu + - renesas,r8a77951-gpu + - renesas,r8a77960-gpu + - renesas,r8a77961-gpu then: properties: clocks:
Update the binding to add support for various Renesas SoC's with PowerVR Rogue GX6250 and GX6650 GPUs. These devices only need one clock, so update the table to indicate such like what was done for the ti,am62-gpu. Signed-off-by: Adam Ford <aford173@gmail.com>