| Message ID | 20240308224237.496924-1-niklas.soderlund+renesas@ragnatech.se (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
| Series | [net-next] ravb: Correct buffer size to map for R-Car Rx | expand |
On 3/9/24 1:42 AM, Niklas Söderlund wrote: > When creating a helper to allocate and align an skb one location where > the skb data size was updated was missed. This can lead to a warning > being printed when the memory is being unmapped as it now always unmap > the maximum frame size, instead of the size after it have been > aligned. > > This was correctly done for RZ/G2L but missed for R-Car. > > Fixes: cfbad64706c1 ("ravb: Create helper to allocate skb and align it") > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> Reviewed-by: Sergey Shtylyov <s.shtylyov@omp.ru> [...] MBR, Sergey
On Fri, Mar 08, 2024 at 11:42:37PM +0100, Niklas Söderlund wrote: > When creating a helper to allocate and align an skb one location where > the skb data size was updated was missed. This can lead to a warning > being printed when the memory is being unmapped as it now always unmap > the maximum frame size, instead of the size after it have been > aligned. > > This was correctly done for RZ/G2L but missed for R-Car. > > Fixes: cfbad64706c1 ("ravb: Create helper to allocate skb and align it") > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> Reviewed-by: Simon Horman <horms@kernel.org>
On Fri, Mar 8, 2024 at 11:43 PM Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> wrote: > When creating a helper to allocate and align an skb one location where > the skb data size was updated was missed. This can lead to a warning > being printed when the memory is being unmapped as it now always unmap > the maximum frame size, instead of the size after it have been > aligned. > > This was correctly done for RZ/G2L but missed for R-Car. > > Fixes: cfbad64706c1 ("ravb: Create helper to allocate skb and align it") > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert
Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <kuba@kernel.org>: On Fri, 8 Mar 2024 23:42:37 +0100 you wrote: > When creating a helper to allocate and align an skb one location where > the skb data size was updated was missed. This can lead to a warning > being printed when the memory is being unmapped as it now always unmap > the maximum frame size, instead of the size after it have been > aligned. > > This was correctly done for RZ/G2L but missed for R-Car. > > [...] Here is the summary with links: - [net-next] ravb: Correct buffer size to map for R-Car Rx https://git.kernel.org/netdev/net-next/c/a290d4cb892d You are awesome, thank you!
diff --git a/drivers/net/ethernet/renesas/ravb_main.c b/drivers/net/ethernet/renesas/ravb_main.c index fa48ff4aba2d..d1be030c8848 100644 --- a/drivers/net/ethernet/renesas/ravb_main.c +++ b/drivers/net/ethernet/renesas/ravb_main.c @@ -979,7 +979,7 @@ static bool ravb_rx_rcar(struct net_device *ndev, int *quota, int q) if (!skb) break; /* Better luck next round. */ dma_addr = dma_map_single(ndev->dev.parent, skb->data, - le16_to_cpu(desc->ds_cc), + priv->info->rx_max_frame_size, DMA_FROM_DEVICE); skb_checksum_none_assert(skb); /* We just set the data size to 0 for a failed mapping
When creating a helper to allocate and align an skb one location where the skb data size was updated was missed. This can lead to a warning being printed when the memory is being unmapped as it now always unmap the maximum frame size, instead of the size after it have been aligned. This was correctly done for RZ/G2L but missed for R-Car. Fixes: cfbad64706c1 ("ravb: Create helper to allocate skb and align it") Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> --- drivers/net/ethernet/renesas/ravb_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)