| Message ID | 20240610150420.2279-2-wsa+renesas@sang-engineering.com (mailing list archive) |
|---|---|
| State | New |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
| Series | [v2] checkpatch: really skip LONG_LINE_* when LONG_LINE is ignored | expand |
On Mon, 2024-06-10 at 17:02 +0200, Wolfram Sang wrote: > For a printout to happen, all types must be set to "show". So, AND is needed > for the flags, not OR, if we want to ignore something. Right. One day I'll learn... As the comment above the block shows: 47e0c88b37a5c3 (Joe Perches 2015-06-25 15:02:57 -0700 3821) # if LONG_LINE is ignored, the other 2 types are also ignored Acked-by: Joe Perches <joe@perches.com> > > Fixes: 47e0c88b37a5 ("checkpatch: categorize some long line length checks") > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> > --- > > Change since v1: > * removed now unneeded pair of braces (Thanks, Geert!) > * reworded commit message > > scripts/checkpatch.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl > index 2b812210b412..375749e0a174 100755 > --- a/scripts/checkpatch.pl > +++ b/scripts/checkpatch.pl > @@ -3858,7 +3858,7 @@ sub process { > } > > if ($msg_type ne "" && > - (show_type("LONG_LINE") || show_type($msg_type))) { > + show_type("LONG_LINE") && show_type($msg_type)) { > my $msg_level = \&WARN; > $msg_level = \&CHK if ($file); > &{$msg_level}($msg_type,
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 2b812210b412..375749e0a174 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -3858,7 +3858,7 @@ sub process { } if ($msg_type ne "" && - (show_type("LONG_LINE") || show_type($msg_type))) { + show_type("LONG_LINE") && show_type($msg_type)) { my $msg_level = \&WARN; $msg_level = \&CHK if ($file); &{$msg_level}($msg_type,
For a printout to happen, all types must be set to "show". So, AND is needed for the flags, not OR, if we want to ignore something. Fixes: 47e0c88b37a5 ("checkpatch: categorize some long line length checks") Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> --- Change since v1: * removed now unneeded pair of braces (Thanks, Geert!) * reworded commit message scripts/checkpatch.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)