| Message ID | 20240611110402.58104-7-biju.das.jz@bp.renesas.com (mailing list archive) |
|---|---|
| State | New |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
| Series | Add support for USB VBUS control for RZ/G2L SoCs | expand |
On 11/06/2024 13:04, Biju Das wrote: > &phyrst { > status = "okay"; > + usb0_vbus_otg: regulator-vbus { > + regulator-name = "vbus"; > + regulator-min-microvolt = <5000000>; > + regulator-max-microvolt = <5000000>; These two voltages look unnecessary. You know the voltage of your LDO, don't you? It's fixed, cannot be anything else. Best regards, Krzysztof
Hi Krzysztof Kozlowski, Thanks for the feedback. > -----Original Message----- > From: Krzysztof Kozlowski <krzk@kernel.org> > Sent: Wednesday, June 12, 2024 7:38 AM > Subject: Re: [PATCH v3 6/6] arm64: dts: renesas: rz-smarc: Replace fixed regulator for USB VBUS > > On 11/06/2024 13:04, Biju Das wrote: > > &phyrst { > > status = "okay"; > > + usb0_vbus_otg: regulator-vbus { > > + regulator-name = "vbus"; > > + regulator-min-microvolt = <5000000>; > > + regulator-max-microvolt = <5000000>; > > These two voltages look unnecessary. You know the voltage of your LDO, don't you? It's fixed, > cannot be anything else. Agreed, Will drop the same. Cheers, Biju
diff --git a/arch/arm64/boot/dts/renesas/rz-smarc-common.dtsi b/arch/arm64/boot/dts/renesas/rz-smarc-common.dtsi index b7a3e6caa386..a444cb6507d3 100644 --- a/arch/arm64/boot/dts/renesas/rz-smarc-common.dtsi +++ b/arch/arm64/boot/dts/renesas/rz-smarc-common.dtsi @@ -54,14 +54,6 @@ codec_dai: simple-audio-card,codec { }; }; - usb0_vbus_otg: regulator-usb0-vbus-otg { - compatible = "regulator-fixed"; - - regulator-name = "USB0_VBUS_OTG"; - regulator-min-microvolt = <5000000>; - regulator-max-microvolt = <5000000>; - }; - vccq_sdhi1: regulator-vccq-sdhi1 { compatible = "regulator-gpio"; regulator-name = "SDHI1 VccQ"; @@ -139,6 +131,11 @@ &ohci1 { &phyrst { status = "okay"; + usb0_vbus_otg: regulator-vbus { + regulator-name = "vbus"; + regulator-min-microvolt = <5000000>; + regulator-max-microvolt = <5000000>; + }; }; &scif0 {
Replace the fixed regulator for USB VBUS. Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> --- v2->v3: * Upated label name * Updated node and regulator name that matches with the bindings. v1->v2: * New patch. --- arch/arm64/boot/dts/renesas/rz-smarc-common.dtsi | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-)