| Message ID | 20240627111445.29751-5-wsa+renesas@sang-engineering.com (mailing list archive) |
|---|---|
| State | New |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
| Series | i2c: testunit: regression fixes | expand |
On Thu, Jun 27, 2024 at 01:14:47PM GMT, Wolfram Sang wrote: > STOP fallsthrough to WRITE_REQUESTED but this became problematic when > clearing the testunit registers was added to the latter. Actually, there > is no reason to clear the testunit state after STOP. Doing it when a new > WRITE_REQUESTED arrives is enough. So, no need to fallthrough, at all. > > Fixes: b39ab96aa894 ("i2c: testunit: add support for block process calls") > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> Reviewed-by: Andi Shyti <andi.shyti@kernel.org> Thanks, Andi
On Thu, Jun 27, 2024 at 01:14:47PM +0200, Wolfram Sang wrote: > STOP fallsthrough to WRITE_REQUESTED but this became problematic when > clearing the testunit registers was added to the latter. Actually, there > is no reason to clear the testunit state after STOP. Doing it when a new > WRITE_REQUESTED arrives is enough. So, no need to fallthrough, at all. > > Fixes: b39ab96aa894 ("i2c: testunit: add support for block process calls") > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> Applied to for-current, thanks!
diff --git a/drivers/i2c/i2c-slave-testunit.c b/drivers/i2c/i2c-slave-testunit.c index a49642bbae4b..a5dcbc3c2c14 100644 --- a/drivers/i2c/i2c-slave-testunit.c +++ b/drivers/i2c/i2c-slave-testunit.c @@ -118,7 +118,7 @@ static int i2c_slave_testunit_slave_cb(struct i2c_client *client, queue_delayed_work(system_long_wq, &tu->worker, msecs_to_jiffies(10 * tu->regs[TU_REG_DELAY])); } - fallthrough; + break; case I2C_SLAVE_WRITE_REQUESTED: memset(tu->regs, 0, TU_NUM_REGS);
STOP fallsthrough to WRITE_REQUESTED but this became problematic when clearing the testunit registers was added to the latter. Actually, there is no reason to clear the testunit state after STOP. Doing it when a new WRITE_REQUESTED arrives is enough. So, no need to fallthrough, at all. Fixes: b39ab96aa894 ("i2c: testunit: add support for block process calls") Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> --- drivers/i2c/i2c-slave-testunit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)