| Message ID | 20240630034649.173229-2-marex@denx.de (mailing list archive) |
|---|---|
| State | New |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
| Series | [1/2] ARM: dts: renesas: Drop ethernet-phy-ieee802.3-c22 from PHY compatible string on all RZ boards | expand |
On Sun, Jun 30, 2024 at 05:46:18AM +0200, Marek Vasut wrote: > The rtl82xx DT bindings do not require ethernet-phy-ieee802.3-c22 > as the fallback compatible string. There are fewer users of the > Realtek PHY compatible string with fallback compatible string than > there are users without fallback compatible string, so drop the > fallback compatible string from the few remaining users: > > $ git grep -ho ethernet-phy-id001c....... | sort | uniq -c > 1 ethernet-phy-id001c.c816", > 2 ethernet-phy-id001c.c915", > 2 ethernet-phy-id001c.c915"; > 5 ethernet-phy-id001c.c916", > 13 ethernet-phy-id001c.c916"; > > Reported-by: kernel test robot <lkp@intel.com> > Closes: https://lore.kernel.org/oe-kbuild-all/202406290316.YvZdvLxu-lkp@intel.com/ > Signed-off-by: Marek Vasut <marex@denx.de> "ethernet-phy-ieee802.3-c22" is pretty much pointless. I don't remember seeing a DT description which actually needs it. It is in the binding more for completion, since "ethernet-phy-ieee802.3-c45" is needed sometimes, and -c22 just completes the list. Reviewed-by: Andrew Lunn <andrew@lunn.ch> Andrew
Hi Marek, On Sun, Jun 30, 2024 at 5:47 AM Marek Vasut <marex@denx.de> wrote: > The rtl82xx DT bindings do not require ethernet-phy-ieee802.3-c22 > as the fallback compatible string. There are fewer users of the > Realtek PHY compatible string with fallback compatible string than > there are users without fallback compatible string, so drop the > fallback compatible string from the few remaining users: > > $ git grep -ho ethernet-phy-id001c....... | sort | uniq -c > 1 ethernet-phy-id001c.c816", > 2 ethernet-phy-id001c.c915", > 2 ethernet-phy-id001c.c915"; > 5 ethernet-phy-id001c.c916", > 13 ethernet-phy-id001c.c916"; > > Reported-by: kernel test robot <lkp@intel.com> > Closes: https://lore.kernel.org/oe-kbuild-all/202406290316.YvZdvLxu-lkp@intel.com/ > Signed-off-by: Marek Vasut <marex@denx.de> Thanks for your patch! > Note: this closes only part of the report In that case you should use a Link: instead of a Closes: tag? > --- a/arch/arm64/boot/dts/renesas/cat875.dtsi > +++ b/arch/arm64/boot/dts/renesas/cat875.dtsi > @@ -22,8 +22,7 @@ &avb { > status = "okay"; > > phy0: ethernet-phy@0 { > - compatible = "ethernet-phy-id001c.c915", > - "ethernet-phy-ieee802.3-c22"; > + compatible = "ethernet-phy-id001c.c915"; > reg = <0>; > interrupt-parent = <&gpio2>; > interrupts = <21 IRQ_TYPE_LEVEL_LOW>; What about moving the PHYs inside an mdio subnode, and removing the compatible properties instead? That would protect against different board revisions using different PHYs or PHY revisions. According to Niklas[1], using an mdio subnode cancels the original reason (failure to identify the PHY in reset state after unbind/rebind or kexec) for adding the compatible values[2]. [1] https://lore.kernel.org/linux-renesas-soc/20240625171445.GF3655345@ragnatech.se [2] commit d45ba2a5f718346e ("arm64: dts: renesas: Add compatible properties to RTL8211E Ethernet PHYs"). Gr{oetje,eeting}s, Geert
diff --git a/arch/arm64/boot/dts/renesas/cat875.dtsi b/arch/arm64/boot/dts/renesas/cat875.dtsi index 8c9da8b4bd60b..502764aef210b 100644 --- a/arch/arm64/boot/dts/renesas/cat875.dtsi +++ b/arch/arm64/boot/dts/renesas/cat875.dtsi @@ -22,8 +22,7 @@ &avb { status = "okay"; phy0: ethernet-phy@0 { - compatible = "ethernet-phy-id001c.c915", - "ethernet-phy-ieee802.3-c22"; + compatible = "ethernet-phy-id001c.c915"; reg = <0>; interrupt-parent = <&gpio2>; interrupts = <21 IRQ_TYPE_LEVEL_LOW>; diff --git a/arch/arm64/boot/dts/renesas/hihope-rzg2-ex.dtsi b/arch/arm64/boot/dts/renesas/hihope-rzg2-ex.dtsi index ad898c6db4e62..d7a8de2619263 100644 --- a/arch/arm64/boot/dts/renesas/hihope-rzg2-ex.dtsi +++ b/arch/arm64/boot/dts/renesas/hihope-rzg2-ex.dtsi @@ -24,8 +24,7 @@ &avb { status = "okay"; phy0: ethernet-phy@0 { - compatible = "ethernet-phy-id001c.c915", - "ethernet-phy-ieee802.3-c22"; + compatible = "ethernet-phy-id001c.c915"; reg = <0>; interrupt-parent = <&gpio2>; interrupts = <11 IRQ_TYPE_LEVEL_LOW>; diff --git a/arch/arm64/boot/dts/renesas/r9a09g011-v2mevk2.dts b/arch/arm64/boot/dts/renesas/r9a09g011-v2mevk2.dts index 39fe3f94991e3..07147743de93f 100644 --- a/arch/arm64/boot/dts/renesas/r9a09g011-v2mevk2.dts +++ b/arch/arm64/boot/dts/renesas/r9a09g011-v2mevk2.dts @@ -100,8 +100,7 @@ &avb { status = "okay"; phy0: ethernet-phy@0 { - compatible = "ethernet-phy-id001c.c916", - "ethernet-phy-ieee802.3-c22"; + compatible = "ethernet-phy-id001c.c916"; reg = <0>; }; };
The rtl82xx DT bindings do not require ethernet-phy-ieee802.3-c22 as the fallback compatible string. There are fewer users of the Realtek PHY compatible string with fallback compatible string than there are users without fallback compatible string, so drop the fallback compatible string from the few remaining users: $ git grep -ho ethernet-phy-id001c....... | sort | uniq -c 1 ethernet-phy-id001c.c816", 2 ethernet-phy-id001c.c915", 2 ethernet-phy-id001c.c915"; 5 ethernet-phy-id001c.c916", 13 ethernet-phy-id001c.c916"; Reported-by: kernel test robot <lkp@intel.com> Closes: https://lore.kernel.org/oe-kbuild-all/202406290316.YvZdvLxu-lkp@intel.com/ Signed-off-by: Marek Vasut <marex@denx.de> --- Cc: Conor Dooley <conor+dt@kernel.org> Cc: Geert Uytterhoeven <geert+renesas@glider.be> Cc: Khuong Dinh <khuong@os.amperecomputing.com> Cc: Krzysztof Kozlowski <krzk+dt@kernel.org> Cc: Magnus Damm <magnus.damm@gmail.com> Cc: Rob Herring <robh@kernel.org> Cc: devicetree@vger.kernel.org Cc: linux-renesas-soc@vger.kernel.org --- Note: this closes only part of the report --- arch/arm64/boot/dts/renesas/cat875.dtsi | 3 +-- arch/arm64/boot/dts/renesas/hihope-rzg2-ex.dtsi | 3 +-- arch/arm64/boot/dts/renesas/r9a09g011-v2mevk2.dts | 3 +-- 3 files changed, 3 insertions(+), 6 deletions(-)