| Message ID | 20240818173003.122025-2-krzysztof.kozlowski@linaro.org (mailing list archive) |
|---|---|
| State | New |
| Delegated to: | Kieran Bingham |
| Headers | show |
| Series | [1/2] dt-bindings: display: renesas,du: narrow interrupts and resets per variants | expand |
Hi Krzysztof, Thank you for the patch. On Sun, Aug 18, 2024 at 07:30:03PM +0200, Krzysztof Kozlowski wrote: > Properties with variable number of items per each device are expected to > have widest constraints in top-level "properties:" block and further > customized (narrowed) in "if:then:". Add missing top-level constraints > for clocks, clock-names, interrupts, resets, reset-names, renesas,cmms > and renesas,vsps. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> > --- > .../bindings/display/renesas,du.yaml | 26 ++++++++++++++++--- > 1 file changed, 22 insertions(+), 4 deletions(-) > > diff --git a/Documentation/devicetree/bindings/display/renesas,du.yaml b/Documentation/devicetree/bindings/display/renesas,du.yaml > index 147842b6465a..9a2d1c08cb1f 100644 > --- a/Documentation/devicetree/bindings/display/renesas,du.yaml > +++ b/Documentation/devicetree/bindings/display/renesas,du.yaml > @@ -46,12 +46,26 @@ properties: > maxItems: 1 > > # See compatible-specific constraints below. > - clocks: true > - clock-names: true > + clocks: > + minItems: 1 > + maxItems: 8 > + > + clock-names: > + minItems: 1 > + maxItems: 8 > + > interrupts: > + minItems: 1 > + maxItems: 4 > description: Interrupt specifiers, one per DU channel > - resets: true > - reset-names: true > + > + resets: > + minItems: 1 > + maxItems: 2 > + > + reset-names: > + minItems: 1 > + maxItems: 2 > > power-domains: > maxItems: 1 > @@ -77,6 +91,8 @@ properties: > > renesas,cmms: > $ref: /schemas/types.yaml#/definitions/phandle-array > + minItems: 2 > + maxItems: 4 > items: > maxItems: 1 > description: > @@ -85,6 +101,8 @@ properties: > > renesas,vsps: > $ref: /schemas/types.yaml#/definitions/phandle-array > + minItems: 1 > + maxItems: 4 > items: > items: > - description: phandle to VSP instance that serves the DU channel
On Sun, Aug 18, 2024 at 07:30:03PM +0200, Krzysztof Kozlowski wrote: > Properties with variable number of items per each device are expected to > have widest constraints in top-level "properties:" block and further > customized (narrowed) in "if:then:". Add missing top-level constraints > for clocks, clock-names, interrupts, resets, reset-names, renesas,cmms > and renesas,vsps. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Acked-by: Conor Dooley <conor.dooley@microchip.com> > --- > .../bindings/display/renesas,du.yaml | 26 ++++++++++++++++--- > 1 file changed, 22 insertions(+), 4 deletions(-) > > diff --git a/Documentation/devicetree/bindings/display/renesas,du.yaml b/Documentation/devicetree/bindings/display/renesas,du.yaml > index 147842b6465a..9a2d1c08cb1f 100644 > --- a/Documentation/devicetree/bindings/display/renesas,du.yaml > +++ b/Documentation/devicetree/bindings/display/renesas,du.yaml > @@ -46,12 +46,26 @@ properties: > maxItems: 1 > > # See compatible-specific constraints below. > - clocks: true > - clock-names: true > + clocks: > + minItems: 1 > + maxItems: 8 > + > + clock-names: > + minItems: 1 > + maxItems: 8 > + > interrupts: > + minItems: 1 > + maxItems: 4 > description: Interrupt specifiers, one per DU channel > - resets: true > - reset-names: true > + > + resets: > + minItems: 1 > + maxItems: 2 > + > + reset-names: > + minItems: 1 > + maxItems: 2 > > power-domains: > maxItems: 1 > @@ -77,6 +91,8 @@ properties: > > renesas,cmms: > $ref: /schemas/types.yaml#/definitions/phandle-array > + minItems: 2 > + maxItems: 4 > items: > maxItems: 1 > description: > @@ -85,6 +101,8 @@ properties: > > renesas,vsps: > $ref: /schemas/types.yaml#/definitions/phandle-array > + minItems: 1 > + maxItems: 4 > items: > items: > - description: phandle to VSP instance that serves the DU channel > -- > 2.43.0 >
diff --git a/Documentation/devicetree/bindings/display/renesas,du.yaml b/Documentation/devicetree/bindings/display/renesas,du.yaml index 147842b6465a..9a2d1c08cb1f 100644 --- a/Documentation/devicetree/bindings/display/renesas,du.yaml +++ b/Documentation/devicetree/bindings/display/renesas,du.yaml @@ -46,12 +46,26 @@ properties: maxItems: 1 # See compatible-specific constraints below. - clocks: true - clock-names: true + clocks: + minItems: 1 + maxItems: 8 + + clock-names: + minItems: 1 + maxItems: 8 + interrupts: + minItems: 1 + maxItems: 4 description: Interrupt specifiers, one per DU channel - resets: true - reset-names: true + + resets: + minItems: 1 + maxItems: 2 + + reset-names: + minItems: 1 + maxItems: 2 power-domains: maxItems: 1 @@ -77,6 +91,8 @@ properties: renesas,cmms: $ref: /schemas/types.yaml#/definitions/phandle-array + minItems: 2 + maxItems: 4 items: maxItems: 1 description: @@ -85,6 +101,8 @@ properties: renesas,vsps: $ref: /schemas/types.yaml#/definitions/phandle-array + minItems: 1 + maxItems: 4 items: items: - description: phandle to VSP instance that serves the DU channel
Properties with variable number of items per each device are expected to have widest constraints in top-level "properties:" block and further customized (narrowed) in "if:then:". Add missing top-level constraints for clocks, clock-names, interrupts, resets, reset-names, renesas,cmms and renesas,vsps. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- .../bindings/display/renesas,du.yaml | 26 ++++++++++++++++--- 1 file changed, 22 insertions(+), 4 deletions(-)