| Message ID | 20240819102348.1592171-8-claudiu.beznea.uj@bp.renesas.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
| Series | i2c: riic: Add support for Renesas RZ/G3S | expand |
On Mon, Aug 19, 2024 at 01:23:44PM +0300, Claudiu wrote: > From: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com> > > Document the Renesas RZ/G3S (R9A08G045) RIIC IP. This is compatible with > the version available on Renesas RZ/V2H (R9A09G075). > > Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com> > --- > > Changes in v4: > - added comment near the fallback for RZ/G3S; because of this > dropped Conor's tag That's not a reason to request a re-review. Best regards, Krzysztof
On 19.08.2024 14:05, Krzysztof Kozlowski wrote: > On Mon, Aug 19, 2024 at 01:23:44PM +0300, Claudiu wrote: >> From: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com> >> >> Document the Renesas RZ/G3S (R9A08G045) RIIC IP. This is compatible with >> the version available on Renesas RZ/V2H (R9A09G075). >> >> Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com> >> --- >> >> Changes in v4: >> - added comment near the fallback for RZ/G3S; because of this >> dropped Conor's tag > > That's not a reason to request a re-review. Sorry for that, I wasn't aware of the procedure for this on bindings. Thank you, Claudiu Beznea > > Best regards, > Krzysztof >
On 19/08/2024 13:10, claudiu beznea wrote: > > > On 19.08.2024 14:05, Krzysztof Kozlowski wrote: >> On Mon, Aug 19, 2024 at 01:23:44PM +0300, Claudiu wrote: >>> From: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com> >>> >>> Document the Renesas RZ/G3S (R9A08G045) RIIC IP. This is compatible with >>> the version available on Renesas RZ/V2H (R9A09G075). >>> >>> Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com> >>> --- >>> >>> Changes in v4: >>> - added comment near the fallback for RZ/G3S; because of this >>> dropped Conor's tag >> >> That's not a reason to request a re-review. > > Sorry for that, I wasn't aware of the procedure for this on bindings. There is no difference. Please read carefully submitting patches, including the chapter about tags. Best regards, Krzysztof
On Mon, Aug 19, 2024 at 01:22:39PM +0200, Krzysztof Kozlowski wrote: > On 19/08/2024 13:10, claudiu beznea wrote: > > > > > > On 19.08.2024 14:05, Krzysztof Kozlowski wrote: > >> On Mon, Aug 19, 2024 at 01:23:44PM +0300, Claudiu wrote: > >>> From: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com> > >>> > >>> Document the Renesas RZ/G3S (R9A08G045) RIIC IP. This is compatible with > >>> the version available on Renesas RZ/V2H (R9A09G075). > >>> > >>> Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com> > >>> --- > >>> > >>> Changes in v4: > >>> - added comment near the fallback for RZ/G3S; because of this > >>> dropped Conor's tag > >> > >> That's not a reason to request a re-review. FWIW, I don't care about how many binding patches I do or do not get credit for reviewing. Feel free to give a tag yourself Krzysztof in the future if you come across these situations and I'll happily hit ctrl+d and remove the thread from my mailbox rather than reply :) > > > > Sorry for that, I wasn't aware of the procedure for this on bindings. > > There is no difference. Please read carefully submitting patches, > including the chapter about tags. Yeah, I don't think this patch is materially different on those grounds... Acked-by: Conor Dooley <conor.dooley@microchip.com> Cheers, Conor.
Hi, On Mon, Aug 19, 2024 at 05:39:35PM GMT, Conor Dooley wrote: > On Mon, Aug 19, 2024 at 01:22:39PM +0200, Krzysztof Kozlowski wrote: > > On 19/08/2024 13:10, claudiu beznea wrote: > > > On 19.08.2024 14:05, Krzysztof Kozlowski wrote: > > >> On Mon, Aug 19, 2024 at 01:23:44PM +0300, Claudiu wrote: > > >>> From: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com> > > >>> > > >>> Document the Renesas RZ/G3S (R9A08G045) RIIC IP. This is compatible with > > >>> the version available on Renesas RZ/V2H (R9A09G075). > > >>> > > >>> Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com> > > >>> --- > > >>> > > >>> Changes in v4: > > >>> - added comment near the fallback for RZ/G3S; because of this > > >>> dropped Conor's tag > > >> > > >> That's not a reason to request a re-review. > > FWIW, I don't care about how many binding patches I do or do not get > credit for reviewing. Feel free to give a tag yourself Krzysztof in the > future if you come across these situations and I'll happily hit ctrl+d > and remove the thread from my mailbox rather than reply :) I'm OK with third parties tags as long as the person is Cc'ed and it happens in the mailing list. It's not unusual and I check they really happened, anyway. Thanks, Andi
On 19.08.2024 19:39, Conor Dooley wrote: > On Mon, Aug 19, 2024 at 01:22:39PM +0200, Krzysztof Kozlowski wrote: >> On 19/08/2024 13:10, claudiu beznea wrote: >>> >>> >>> On 19.08.2024 14:05, Krzysztof Kozlowski wrote: >>>> On Mon, Aug 19, 2024 at 01:23:44PM +0300, Claudiu wrote: >>>>> From: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com> >>>>> >>>>> Document the Renesas RZ/G3S (R9A08G045) RIIC IP. This is compatible with >>>>> the version available on Renesas RZ/V2H (R9A09G075). >>>>> >>>>> Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com> >>>>> --- >>>>> >>>>> Changes in v4: >>>>> - added comment near the fallback for RZ/G3S; because of this >>>>> dropped Conor's tag >>>> >>>> That's not a reason to request a re-review. > > FWIW, I don't care about how many binding patches I do or do not get > credit for reviewing. I had no intention to drop your credit for reviewing this. In the past I went though situations where reviewer complained due to keeping the tag and doing very simple adjustment on the next version. I dropped your tag to avoid that situation here too and mentioned it in the change log. Thank you, Claudiu Beznea > Feel free to give a tag yourself Krzysztof in the > future if you come across these situations and I'll happily hit ctrl+d > and remove the thread from my mailbox rather than reply :) > >>> >>> Sorry for that, I wasn't aware of the procedure for this on bindings. >> >> There is no difference. Please read carefully submitting patches, >> including the chapter about tags. > > Yeah, I don't think this patch is materially different on those > grounds... > > Acked-by: Conor Dooley <conor.dooley@microchip.com> > > Cheers, > Conor.
On Tue, Aug 20, 2024 at 10:45:43AM +0300, claudiu beznea wrote: > > > On 19.08.2024 19:39, Conor Dooley wrote: > > On Mon, Aug 19, 2024 at 01:22:39PM +0200, Krzysztof Kozlowski wrote: > >> On 19/08/2024 13:10, claudiu beznea wrote: > >>> > >>> > >>> On 19.08.2024 14:05, Krzysztof Kozlowski wrote: > >>>> On Mon, Aug 19, 2024 at 01:23:44PM +0300, Claudiu wrote: > >>>>> From: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com> > >>>>> > >>>>> Document the Renesas RZ/G3S (R9A08G045) RIIC IP. This is compatible with > >>>>> the version available on Renesas RZ/V2H (R9A09G075). > >>>>> > >>>>> Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com> > >>>>> --- > >>>>> > >>>>> Changes in v4: > >>>>> - added comment near the fallback for RZ/G3S; because of this > >>>>> dropped Conor's tag > >>>> > >>>> That's not a reason to request a re-review. > > > > FWIW, I don't care about how many binding patches I do or do not get > > credit for reviewing. > > I had no intention to drop your credit for reviewing this. In the past I That comment was meant for Krzysztof, so that he wouldn't feel like he should avoid acking so that I could re-ack in similar situations in the future. > went though situations where reviewer complained due to keeping the tag and > doing very simple adjustment on the next version. I dropped your tag to > avoid that situation here too and mentioned it in the change log. Ye, I did note that you'd not dropped it confusingly :)
diff --git a/Documentation/devicetree/bindings/i2c/renesas,riic.yaml b/Documentation/devicetree/bindings/i2c/renesas,riic.yaml index 7993fe463c4c..505a8ec92266 100644 --- a/Documentation/devicetree/bindings/i2c/renesas,riic.yaml +++ b/Documentation/devicetree/bindings/i2c/renesas,riic.yaml @@ -25,6 +25,10 @@ properties: - renesas,riic-r9a07g054 # RZ/V2L - const: renesas,riic-rz # RZ/A or RZ/G2L + - items: + - const: renesas,riic-r9a08g045 # RZ/G3S + - const: renesas,riic-r9a09g057 # RZ/V2H(P) + - const: renesas,riic-r9a09g057 # RZ/V2H(P) reg: