| Message ID | 20240822140413.65369-3-rongqianfeng@vivo.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
| Series | Use devm_clk_get_enabled() helpers | expand |
Hi Rong Qianfeng, > -----Original Message----- > From: Rong Qianfeng <rongqianfeng@vivo.com> > Sent: Thursday, August 22, 2024 3:04 PM > Subject: [PATCH v2 2/3] i2c: emev2: Drop sclk from struct em_i2c_device > > For no need to save clk pointer, drop sclk from struct em_i2c_device. > > Signed-off-by: Rong Qianfeng <rongqianfeng@vivo.com> Reviewed-by: Biju Das <biju.das.jz@bp.renesas.com> Cheers, Biju > --- > drivers/i2c/busses/i2c-emev2.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-emev2.c b/drivers/i2c/busses/i2c-emev2.c index > 20efe0b0cb85..2a5d9d658246 100644 > --- a/drivers/i2c/busses/i2c-emev2.c > +++ b/drivers/i2c/busses/i2c-emev2.c > @@ -67,7 +67,6 @@ struct em_i2c_device { > void __iomem *base; > struct i2c_adapter adap; > struct completion msg_done; > - struct clk *sclk; > struct i2c_client *slave; > int irq; > }; > @@ -361,6 +360,7 @@ static const struct i2c_algorithm em_i2c_algo = { static int em_i2c_probe(struct > platform_device *pdev) { > struct em_i2c_device *priv; > + struct clk *sclk; > int ret; > > priv = devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL); @@ -373,9 +373,9 @@ static int > em_i2c_probe(struct platform_device *pdev) > > strscpy(priv->adap.name, "EMEV2 I2C", sizeof(priv->adap.name)); > > - priv->sclk = devm_clk_get_enabled(&pdev->dev, "sclk"); > - if (IS_ERR(priv->sclk)) > - return PTR_ERR(priv->sclk); > + sclk = devm_clk_get_enabled(&pdev->dev, "sclk"); > + if (IS_ERR(sclk)) > + return PTR_ERR(sclk); > > priv->adap.timeout = msecs_to_jiffies(100); > priv->adap.retries = 5; > -- > 2.39.0
diff --git a/drivers/i2c/busses/i2c-emev2.c b/drivers/i2c/busses/i2c-emev2.c index 20efe0b0cb85..2a5d9d658246 100644 --- a/drivers/i2c/busses/i2c-emev2.c +++ b/drivers/i2c/busses/i2c-emev2.c @@ -67,7 +67,6 @@ struct em_i2c_device { void __iomem *base; struct i2c_adapter adap; struct completion msg_done; - struct clk *sclk; struct i2c_client *slave; int irq; }; @@ -361,6 +360,7 @@ static const struct i2c_algorithm em_i2c_algo = { static int em_i2c_probe(struct platform_device *pdev) { struct em_i2c_device *priv; + struct clk *sclk; int ret; priv = devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL); @@ -373,9 +373,9 @@ static int em_i2c_probe(struct platform_device *pdev) strscpy(priv->adap.name, "EMEV2 I2C", sizeof(priv->adap.name)); - priv->sclk = devm_clk_get_enabled(&pdev->dev, "sclk"); - if (IS_ERR(priv->sclk)) - return PTR_ERR(priv->sclk); + sclk = devm_clk_get_enabled(&pdev->dev, "sclk"); + if (IS_ERR(sclk)) + return PTR_ERR(sclk); priv->adap.timeout = msecs_to_jiffies(100); priv->adap.retries = 5;
For no need to save clk pointer, drop sclk from struct em_i2c_device. Signed-off-by: Rong Qianfeng <rongqianfeng@vivo.com> --- drivers/i2c/busses/i2c-emev2.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)