| Message ID | 20240905112508.160560-1-biju.das.jz@bp.renesas.com (mailing list archive) |
|---|---|
| State | New |
| Delegated to: | Kieran Bingham |
| Headers | show |
| Series | media: platform: rzg2l-cru: rzg2l-video: Fix the comment in rzg2l_cru_start_streaming_vq() | expand |
Hi Biju, Thank you for the patch. On Thu, Sep 05, 2024 at 12:25:05PM +0100, Biju Das wrote: > Replace "buffer." -> "buffer", for consistency with rest of the > comment blocks in rzg2l_cru_start_streaming_vq(). I usually go the other way around, sentences should end with a period. You can go either way as it's your driver. > Reported-by: Pavel Machek <pavel@denx.de> > Closes: https://lore.kernel.org/all/ZtWNFuw70nkB37EK@duo.ucw.cz/ > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> > --- > This patch have merge dependency on [1] > [1] https://lore.kernel.org/all/20240826110740.271212-1-biju.das.jz@bp.renesas.com/ > --- > drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c > index bbf4674f888d..d17e3eac4177 100644 > --- a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c > +++ b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c > @@ -648,7 +648,7 @@ static int rzg2l_cru_start_streaming_vq(struct vb2_queue *vq, unsigned int count > goto assert_aresetn; > } > > - /* Allocate scratch buffer. */ > + /* Allocate scratch buffer */ > cru->scratch = dma_alloc_coherent(cru->dev, cru->format.sizeimage, > &cru->scratch_phys, GFP_KERNEL); > if (!cru->scratch) {
Hi Laurent, Thanks for the feedback. > -----Original Message----- > From: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > Sent: Saturday, September 7, 2024 1:05 AM > Subject: Re: [PATCH] media: platform: rzg2l-cru: rzg2l-video: Fix the comment in > rzg2l_cru_start_streaming_vq() > > Hi Biju, > > Thank you for the patch. > > On Thu, Sep 05, 2024 at 12:25:05PM +0100, Biju Das wrote: > > Replace "buffer." -> "buffer", for consistency with rest of the > > comment blocks in rzg2l_cru_start_streaming_vq(). > > I usually go the other way around, sentences should end with a period. > You can go either way as it's your driver. Ok, I will send next version with sentences end with a period. Cheers, Biju > > > Reported-by: Pavel Machek <pavel@denx.de> > > Closes: https://lore.kernel.org/all/ZtWNFuw70nkB37EK@duo.ucw.cz/ > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> > > --- > > This patch have merge dependency on [1] [1] > > https://lore.kernel.org/all/20240826110740.271212-1-biju.das.jz@bp.ren > > esas.com/ > > --- > > drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c > > b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c > > index bbf4674f888d..d17e3eac4177 100644 > > --- a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c > > +++ b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c > > @@ -648,7 +648,7 @@ static int rzg2l_cru_start_streaming_vq(struct vb2_queue *vq, unsigned int count > > goto assert_aresetn; > > } > > > > - /* Allocate scratch buffer. */ > > + /* Allocate scratch buffer */ > > cru->scratch = dma_alloc_coherent(cru->dev, cru->format.sizeimage, > > &cru->scratch_phys, GFP_KERNEL); > > if (!cru->scratch) { > > -- > Regards, > > Laurent Pinchart
On Sat, Sep 07, 2024 at 07:28:13AM +0000, Biju Das wrote: > Hi Laurent, > > Thanks for the feedback. > > > -----Original Message----- > > From: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > Sent: Saturday, September 7, 2024 1:05 AM > > Subject: Re: [PATCH] media: platform: rzg2l-cru: rzg2l-video: Fix the comment in > > rzg2l_cru_start_streaming_vq() > > > > Hi Biju, > > > > Thank you for the patch. > > > > On Thu, Sep 05, 2024 at 12:25:05PM +0100, Biju Das wrote: > > > Replace "buffer." -> "buffer", for consistency with rest of the > > > comment blocks in rzg2l_cru_start_streaming_vq(). > > > > I usually go the other way around, sentences should end with a period. > > You can go either way as it's your driver. > > Ok, I will send next version with sentences end with a period. It's really up to you, and I mean it :-) What I favour the most is consistency. I personally think sentences are better with a trailing period, but if you prefer considering all those comments as titles and drop the period, I'm OK with it too. As long as it doesn't conflict with subsystem-wide rules, your driver, your preferences. > > > Reported-by: Pavel Machek <pavel@denx.de> > > > Closes: https://lore.kernel.org/all/ZtWNFuw70nkB37EK@duo.ucw.cz/ > > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> > > > --- > > > This patch have merge dependency on [1] [1] > > > https://lore.kernel.org/all/20240826110740.271212-1-biju.das.jz@bp.ren > > > esas.com/ > > > --- > > > drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c > > > b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c > > > index bbf4674f888d..d17e3eac4177 100644 > > > --- a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c > > > +++ b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c > > > @@ -648,7 +648,7 @@ static int rzg2l_cru_start_streaming_vq(struct vb2_queue *vq, unsigned int count > > > goto assert_aresetn; > > > } > > > > > > - /* Allocate scratch buffer. */ > > > + /* Allocate scratch buffer */ > > > cru->scratch = dma_alloc_coherent(cru->dev, cru->format.sizeimage, > > > &cru->scratch_phys, GFP_KERNEL); > > > if (!cru->scratch) {
diff --git a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c index bbf4674f888d..d17e3eac4177 100644 --- a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c +++ b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c @@ -648,7 +648,7 @@ static int rzg2l_cru_start_streaming_vq(struct vb2_queue *vq, unsigned int count goto assert_aresetn; } - /* Allocate scratch buffer. */ + /* Allocate scratch buffer */ cru->scratch = dma_alloc_coherent(cru->dev, cru->format.sizeimage, &cru->scratch_phys, GFP_KERNEL); if (!cru->scratch) {
Replace "buffer." -> "buffer", for consistency with rest of the comment blocks in rzg2l_cru_start_streaming_vq(). Reported-by: Pavel Machek <pavel@denx.de> Closes: https://lore.kernel.org/all/ZtWNFuw70nkB37EK@duo.ucw.cz/ Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> --- This patch have merge dependency on [1] [1] https://lore.kernel.org/all/20240826110740.271212-1-biju.das.jz@bp.renesas.com/ --- drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)